Re: [PATCH/RFC v2 3/7] spi: core: Add support for registering SPI slave controllers

On Mon, Dec 19, 2016 at 11:02:07AM +0100, Geert Uytterhoeven wrote: > On Thu, Dec 15, 2016 at 6:53 PM, Mark Brown wrote: > > On Mon, Sep 12, 2016 at 10:50:42PM +0200, Geert Uytterhoeven wrote: > >> TBD: > >> - s/spi_master/spi_controller/ where appropriate, > >> - Provide

Re: [PATCH/RFC v2 3/7] spi: core: Add support for registering SPI slave controllers

On Mon, Dec 19, 2016 at 11:02:07AM +0100, Geert Uytterhoeven wrote: > On Thu, Dec 15, 2016 at 6:53 PM, Mark Brown wrote: > > On Mon, Sep 12, 2016 at 10:50:42PM +0200, Geert Uytterhoeven wrote: > >> TBD: > >> - s/spi_master/spi_controller/ where appropriate, > >> - Provide wrappers (e.g.

Re: [PATCH/RFC v2 3/7] spi: core: Add support for registering SPI slave controllers

Hi Mark, On Thu, Dec 15, 2016 at 6:53 PM, Mark Brown wrote: > On Mon, Sep 12, 2016 at 10:50:42PM +0200, Geert Uytterhoeven wrote: >> TBD: >> - s/spi_master/spi_controller/ where appropriate, >> - Provide wrappers (e.g. "#define spi_master spi_controller" until all >>

Re: [PATCH/RFC v2 3/7] spi: core: Add support for registering SPI slave controllers

Hi Mark, On Thu, Dec 15, 2016 at 6:53 PM, Mark Brown wrote: > On Mon, Sep 12, 2016 at 10:50:42PM +0200, Geert Uytterhoeven wrote: >> TBD: >> - s/spi_master/spi_controller/ where appropriate, >> - Provide wrappers (e.g. "#define spi_master spi_controller" until all >> SPI drivers have

Re: [PATCH/RFC v2 3/7] spi: core: Add support for registering SPI slave controllers

On Mon, Sep 12, 2016 at 10:50:42PM +0200, Geert Uytterhoeven wrote: > TBD: > - s/spi_master/spi_controller/ where appropriate, > - Provide wrappers (e.g. "#define spi_master spi_controller" until all > SPI drivers have been converted), > - Do we want a separate spi_register_slave()

Re: [PATCH/RFC v2 3/7] spi: core: Add support for registering SPI slave controllers

On Mon, Sep 12, 2016 at 10:50:42PM +0200, Geert Uytterhoeven wrote: > TBD: > - s/spi_master/spi_controller/ where appropriate, > - Provide wrappers (e.g. "#define spi_master spi_controller" until all > SPI drivers have been converted), > - Do we want a separate spi_register_slave()

Re: [PATCH/RFC v2 3/7] spi: core: Add support for registering SPI slave controllers

On Sun, Sep 18, 2016 at 11:04:18AM +0200, Geert Uytterhoeven wrote: > This is caused by moving the setup of master->dev.class. > To fix this, I can > 1) Introduce a separate spi_alloc_slave() function, which sets up > spi_slave_class instead of spi_master class, This seems more idiomatic.

Re: [PATCH/RFC v2 3/7] spi: core: Add support for registering SPI slave controllers

On Sun, Sep 18, 2016 at 11:04:18AM +0200, Geert Uytterhoeven wrote: > This is caused by moving the setup of master->dev.class. > To fix this, I can > 1) Introduce a separate spi_alloc_slave() function, which sets up > spi_slave_class instead of spi_master class, This seems more idiomatic.

Re: [PATCH/RFC v2 3/7] spi: core: Add support for registering SPI slave controllers

On Mon, Sep 12, 2016 at 10:50 PM, Geert Uytterhoeven wrote: > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1477,15 +1477,6 @@ static int of_spi_parse_dt(struct spi_master *master, > struct spi_device *spi, > @@ -1799,7 +1908,6 @@ struct spi_master

Re: [PATCH/RFC v2 3/7] spi: core: Add support for registering SPI slave controllers

On Mon, Sep 12, 2016 at 10:50 PM, Geert Uytterhoeven wrote: > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1477,15 +1477,6 @@ static int of_spi_parse_dt(struct spi_master *master, > struct spi_device *spi, > @@ -1799,7 +1908,6 @@ struct spi_master *spi_alloc_master(struct device