Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

2017-02-07 Thread David Miller 
From: Arnd Bergmann 
Date: Mon,  6 Feb 2017 17:26:30 +0100

> When PSAMPLE is a loadable module, spectrum must not be built-in:
> 
> drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
> spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
> 
> This adds a Kconfig dependency to enforce usable configurations.
> 
> Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
> Signed-off-by: Arnd Bergmann 

Applied.

Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

2017-02-07 Thread David Miller 
From: Arnd Bergmann 
Date: Mon,  6 Feb 2017 17:26:30 +0100

> When PSAMPLE is a loadable module, spectrum must not be built-in:
> 
> drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
> spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
> 
> This adds a Kconfig dependency to enforce usable configurations.
> 
> Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
> Signed-off-by: Arnd Bergmann 

Applied.

Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

2017-02-07 Thread Jiri Pirko 
Mon, Feb 06, 2017 at 05:26:30PM CET, a...@arndb.de wrote:
>When PSAMPLE is a loadable module, spectrum must not be built-in:
>
>drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
>spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
>
>This adds a Kconfig dependency to enforce usable configurations.
>
>Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
>Signed-off-by: Arnd Bergmann 

Acked-by: Jiri Pirko

Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

2017-02-07 Thread Jiri Pirko 
Mon, Feb 06, 2017 at 05:26:30PM CET, a...@arndb.de wrote:
>When PSAMPLE is a loadable module, spectrum must not be built-in:
>
>drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
>spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
>
>This adds a Kconfig dependency to enforce usable configurations.
>
>Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
>Signed-off-by: Arnd Bergmann 

Acked-by: Jiri Pirko

RE: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

2017-02-06 Thread Yotam Gigi 
>-Original Message-
>From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
>Behalf Of Arnd Bergmann
>Sent: Monday, February 06, 2017 6:27 PM
>To: Jiri Pirko ; Ido Schimmel 
>Cc: Arnd Bergmann ; David S. Miller ;
>Vadim Pasternak ; Elad Raz ; Ivan
>Vecera ; net...@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: [PATCH] [net-next] mlxsw: add psample dependency for spectrum
>
>When PSAMPLE is a loadable module, spectrum must not be built-in:
>
>drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
>spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
>
>This adds a Kconfig dependency to enforce usable configurations.
>
>Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
>Signed-off-by: Arnd Bergmann 

Acked-by: Yotam Gigi 

>---
> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>index 76a7574c3c7d..ef23eaedc2ff 100644
>--- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>+++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>@@ -73,6 +73,7 @@ config MLXSW_SWITCHX2
> config MLXSW_SPECTRUM
>   tristate "Mellanox Technologies Spectrum support"
>   depends on MLXSW_CORE && MLXSW_PCI && NET_SWITCHDEV &&
>VLAN_8021Q
>+  depends on PSAMPLE || PSAMPLE=n
>   select PARMAN
>   default m
>   ---help---
>--
>2.9.0

RE: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

2017-02-06 Thread Yotam Gigi 
>-Original Message-
>From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
>Behalf Of Arnd Bergmann
>Sent: Monday, February 06, 2017 6:27 PM
>To: Jiri Pirko ; Ido Schimmel 
>Cc: Arnd Bergmann ; David S. Miller ;
>Vadim Pasternak ; Elad Raz ; Ivan
>Vecera ; net...@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: [PATCH] [net-next] mlxsw: add psample dependency for spectrum
>
>When PSAMPLE is a loadable module, spectrum must not be built-in:
>
>drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
>spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
>
>This adds a Kconfig dependency to enforce usable configurations.
>
>Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
>Signed-off-by: Arnd Bergmann 

Acked-by: Yotam Gigi 

>---
> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>index 76a7574c3c7d..ef23eaedc2ff 100644
>--- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>+++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>@@ -73,6 +73,7 @@ config MLXSW_SWITCHX2
> config MLXSW_SPECTRUM
>   tristate "Mellanox Technologies Spectrum support"
>   depends on MLXSW_CORE && MLXSW_PCI && NET_SWITCHDEV &&
>VLAN_8021Q
>+  depends on PSAMPLE || PSAMPLE=n
>   select PARMAN
>   default m
>   ---help---
>--
>2.9.0