Re: [PATCH] ARM: dts: imx: Add ZII SCU3 ESB
On Wed, Jul 11, 2018 at 7:57 AM Andrew Lunn wrote:
>
> On Tue, Jul 10, 2018 at 10:07:04PM -0700, Andrey Smirnov wrote:
> > + switch@0 {
> > + compatible = "marvell,mv88e6085";
> > + reg = <0>;
> > + dsa,member = <0 0>;
> > + eeprom-length = <512>;
> > + interrupt-parent = <>;
> > + interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-controller;
> > + #interrupt-cells = <2>;
>
> Hi Andrey
>
> I don't see a pinmux for this GPIO. Is one needed?
I got lucky and this pin is configured in GPIO mode out of reset. But
strictly speaking, yeah, I think there should be a pinmux entry for
this. Since things are working as is, I'll send a separate patch
adding that instead of re-spinning this one.
Thanks
Andrey Smirnov
Re: [PATCH] ARM: dts: imx: Add ZII SCU3 ESB
On Wed, Jul 11, 2018 at 7:57 AM Andrew Lunn wrote:
>
> On Tue, Jul 10, 2018 at 10:07:04PM -0700, Andrey Smirnov wrote:
> > + switch@0 {
> > + compatible = "marvell,mv88e6085";
> > + reg = <0>;
> > + dsa,member = <0 0>;
> > + eeprom-length = <512>;
> > + interrupt-parent = <>;
> > + interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-controller;
> > + #interrupt-cells = <2>;
>
> Hi Andrey
>
> I don't see a pinmux for this GPIO. Is one needed?
I got lucky and this pin is configured in GPIO mode out of reset. But
strictly speaking, yeah, I think there should be a pinmux entry for
this. Since things are working as is, I'll send a separate patch
adding that instead of re-spinning this one.
Thanks
Andrey Smirnov
Re: [PATCH] ARM: dts: imx: Add ZII SCU3 ESB
On Tue, Jul 10, 2018 at 10:07:04PM -0700, Andrey Smirnov wrote:
> + switch@0 {
> + compatible = "marvell,mv88e6085";
> + reg = <0>;
> + dsa,member = <0 0>;
> + eeprom-length = <512>;
> + interrupt-parent = <>;
> + interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
Hi Andrey
I don't see a pinmux for this GPIO. Is one needed?
Andrew
Re: [PATCH] ARM: dts: imx: Add ZII SCU3 ESB
On Tue, Jul 10, 2018 at 10:07:04PM -0700, Andrey Smirnov wrote:
> + switch@0 {
> + compatible = "marvell,mv88e6085";
> + reg = <0>;
> + dsa,member = <0 0>;
> + eeprom-length = <512>;
> + interrupt-parent = <>;
> + interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
Hi Andrey
I don't see a pinmux for this GPIO. Is one needed?
Andrew
Re: [PATCH] ARM: dts: imx: Add ZII SCU3 ESB
On Tue, Jul 10, 2018 at 10:07:04PM -0700, Andrey Smirnov wrote: > Add support for the Zodiac Inflight Innovations i.MX51-base SCU3 Ethernet > Switch Board (ESB) > > Cc: Fabio Estevam > Cc: Nikita Yushchenko > Cc: Lucas Stach > Cc: cphe...@gmail.com > Cc: Shawn Guo > Cc: Rob Herring > Cc: Mark Rutland > Cc: linux-arm-ker...@lists.infradead.org > Cc: devicet...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Reviewed-by: Fabio Estevam > Signed-off-by: Andrey Gusakov > Signed-off-by: Andrey Smirnov Applied, thanks.
Re: [PATCH] ARM: dts: imx: Add ZII SCU3 ESB
On Tue, Jul 10, 2018 at 10:07:04PM -0700, Andrey Smirnov wrote: > Add support for the Zodiac Inflight Innovations i.MX51-base SCU3 Ethernet > Switch Board (ESB) > > Cc: Fabio Estevam > Cc: Nikita Yushchenko > Cc: Lucas Stach > Cc: cphe...@gmail.com > Cc: Shawn Guo > Cc: Rob Herring > Cc: Mark Rutland > Cc: linux-arm-ker...@lists.infradead.org > Cc: devicet...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Reviewed-by: Fabio Estevam > Signed-off-by: Andrey Gusakov > Signed-off-by: Andrey Smirnov Applied, thanks.
