Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-05 Thread Yung-Ching LIN 
Hi Shawn,

Will apply all the changes required to the v2.
Thank you for your comments and detailed reviews.

On Mon, Feb 5, 2018 at 6:12 AM, Shawn Guo  wrote:
> On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote:
>> Add support for Advantech DMS-BA16 board, which use
>> the Advantech BA-16 module.
>>
>> Signed-off-by: Ken Lin 
>> ---
>>  arch/arm/boot/dts/Makefile   |   1 +
>>  arch/arm/boot/dts/imx6q-dms-ba16.dts | 154 
>> +++
>>  2 files changed, 155 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index ade7a38543dc..d97511273f30 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -428,6 +428,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>>   imx6q-b450v3.dtb \
>>   imx6q-b650v3.dtb \
>>   imx6q-b850v3.dtb \
>> + imx6q-dms-ba16.dtb \
>>   imx6q-cm-fx6.dtb \
>>   imx6q-cubox-i.dtb \
>>   imx6q-cubox-i-emmc-som-v15.dtb \
>> diff --git a/arch/arm/boot/dts/imx6q-dms-ba16.dts 
>> b/arch/arm/boot/dts/imx6q-dms-ba16.dts
>> new file mode 100644
>> index ..4c5e17a17cbd
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx6q-dms-ba16.dts
>> @@ -0,0 +1,154 @@
>> +/*
>> + * Copyright 2018 Advantech Corporation
>> + *
>> + * The code contained herein is licensed under the GNU General Public
>> + * License. You may obtain a copy of the GNU General Public License
>> + * Version 2 or later at the following locations:
>> + *
>> + * http://www.opensource.org/licenses/gpl-license.html
>> + * http://www.gnu.org/copyleft/gpl.html
>> + */
>
> Please use SPDX tag.
>
>> +
>> +/dts-v1/;
>> +
>> +#include 
>> +#include "imx6q-ba16.dtsi"
>> +
>> +/ {
>> + model = "Advantech DMS-BA16";
>> + compatible = "fsl,imx6q-dms-ba16", "fsl,imx6q";
>> +
>> + clocks {
>> + mclk: clock@0 {
>
> Please give it an unique name like clock-xxx and put it directly under
> root, and drop unit-address and 'reg' property.
>
>> + compatible = "fixed-clock";
>> + reg = <0>;
>> + #clock-cells = <0>;
>> + clock-frequency = <2200>;
>> + };
>> + };
>> +
>> + sound {
>> + compatible = "fsl,imx6q-ba16-sgtl5000",
>> +  "fsl,imx-audio-sgtl5000";
>> + model = "imx6q-ba16-sgtl5000";
>> + ssi-controller = <>;
>> + audio-codec = <>;
>> + audio-routing =
>> + "MIC_IN", "Mic Jack",
>> + "Mic Jack", "Mic Bias",
>> + "Headphone Jack", "HP_OUT";
>> + mux-int-port = <1>;
>> + mux-ext-port = <4>;
>> + };
>> +
>> + reg_usb_otg_vbus: regulator-usbotgvbus {
>> + compatible = "regulator-fixed";
>> + regulator-name = "usb_otg_vbus";
>> + regulator-min-microvolt = <500>;
>> + regulator-max-microvolt = <500>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <_usbotgvbus>;
>> + gpio = < 15 GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + };
>> +};
>> +
>> + {
>> +
>> + pinctrl_usbotgvbus: usbotgvbusgrp {
>
> Please sort pinctrl entries alphabetically.
>
>> + fsl,pins = <
>> + MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x000b0
>> + MX6QDL_PAD_GPIO_1__USB_OTG_ID   0x17059
>> + >;
>> + };
>> +
>> + pinctrl_i2c1_gpio: i2c1gpiogrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_CSI0_DAT8__GPIO5_IO260x1b0b0
>> + MX6QDL_PAD_CSI0_DAT9__GPIO5_IO270x1b0b0
>> + >;
>> + };
>> +
>> + pinctrl_i2c2_gpio: i2c2gpiogrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x1b0b0
>> + MX6QDL_PAD_KEY_ROW3__GPIO4_IO13 0x1b0b0
>> + >;
>> + };
>> +
>> + pinctrl_i2c3_gpio: i2c3gpiogrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_GPIO_3__GPIO1_IO03   0x1b0b0
>> + MX6QDL_PAD_GPIO_6__GPIO1_IO06   0x1b0b0
>> + >;
>> + };
>> +};
>> +
>> + {
>> + fsl,spi-num-chipselects = <1>;
>
> The property is obsoleted, and shouldn't be needed any more.
>
>> + cs-gpios = < 17 0>;
>
> Use polarity defines in dt-bindings/gpio/gpio.h.
>
>> + pinctrl-names = "default";
>> + pinctrl-0 = <_ecspi5>;
>> + status = "okay";
>> +
>> + m25_eeprom: m25p80@0 {
>> + compatible = "atmel,at25";
>> + spi-max-frequency = <2000>;
>> + size = <0x8000>;
>> + pagesize = <64>;
>> + reg = <0>;
>> + address-width = <16>;
>> + };
>> +};
>> +
>> + {
>> + clock-frequency = <10>;
>> + pinctrl-names = "default";
>> +

Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-05 Thread Yung-Ching LIN 
Hi Shawn,

Will apply all the changes required to the v2.
Thank you for your comments and detailed reviews.

On Mon, Feb 5, 2018 at 6:12 AM, Shawn Guo  wrote:
> On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote:
>> Add support for Advantech DMS-BA16 board, which use
>> the Advantech BA-16 module.
>>
>> Signed-off-by: Ken Lin 
>> ---
>>  arch/arm/boot/dts/Makefile   |   1 +
>>  arch/arm/boot/dts/imx6q-dms-ba16.dts | 154 
>> +++
>>  2 files changed, 155 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index ade7a38543dc..d97511273f30 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -428,6 +428,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>>   imx6q-b450v3.dtb \
>>   imx6q-b650v3.dtb \
>>   imx6q-b850v3.dtb \
>> + imx6q-dms-ba16.dtb \
>>   imx6q-cm-fx6.dtb \
>>   imx6q-cubox-i.dtb \
>>   imx6q-cubox-i-emmc-som-v15.dtb \
>> diff --git a/arch/arm/boot/dts/imx6q-dms-ba16.dts 
>> b/arch/arm/boot/dts/imx6q-dms-ba16.dts
>> new file mode 100644
>> index ..4c5e17a17cbd
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx6q-dms-ba16.dts
>> @@ -0,0 +1,154 @@
>> +/*
>> + * Copyright 2018 Advantech Corporation
>> + *
>> + * The code contained herein is licensed under the GNU General Public
>> + * License. You may obtain a copy of the GNU General Public License
>> + * Version 2 or later at the following locations:
>> + *
>> + * http://www.opensource.org/licenses/gpl-license.html
>> + * http://www.gnu.org/copyleft/gpl.html
>> + */
>
> Please use SPDX tag.
>
>> +
>> +/dts-v1/;
>> +
>> +#include 
>> +#include "imx6q-ba16.dtsi"
>> +
>> +/ {
>> + model = "Advantech DMS-BA16";
>> + compatible = "fsl,imx6q-dms-ba16", "fsl,imx6q";
>> +
>> + clocks {
>> + mclk: clock@0 {
>
> Please give it an unique name like clock-xxx and put it directly under
> root, and drop unit-address and 'reg' property.
>
>> + compatible = "fixed-clock";
>> + reg = <0>;
>> + #clock-cells = <0>;
>> + clock-frequency = <2200>;
>> + };
>> + };
>> +
>> + sound {
>> + compatible = "fsl,imx6q-ba16-sgtl5000",
>> +  "fsl,imx-audio-sgtl5000";
>> + model = "imx6q-ba16-sgtl5000";
>> + ssi-controller = <>;
>> + audio-codec = <>;
>> + audio-routing =
>> + "MIC_IN", "Mic Jack",
>> + "Mic Jack", "Mic Bias",
>> + "Headphone Jack", "HP_OUT";
>> + mux-int-port = <1>;
>> + mux-ext-port = <4>;
>> + };
>> +
>> + reg_usb_otg_vbus: regulator-usbotgvbus {
>> + compatible = "regulator-fixed";
>> + regulator-name = "usb_otg_vbus";
>> + regulator-min-microvolt = <500>;
>> + regulator-max-microvolt = <500>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <_usbotgvbus>;
>> + gpio = < 15 GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + };
>> +};
>> +
>> + {
>> +
>> + pinctrl_usbotgvbus: usbotgvbusgrp {
>
> Please sort pinctrl entries alphabetically.
>
>> + fsl,pins = <
>> + MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x000b0
>> + MX6QDL_PAD_GPIO_1__USB_OTG_ID   0x17059
>> + >;
>> + };
>> +
>> + pinctrl_i2c1_gpio: i2c1gpiogrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_CSI0_DAT8__GPIO5_IO260x1b0b0
>> + MX6QDL_PAD_CSI0_DAT9__GPIO5_IO270x1b0b0
>> + >;
>> + };
>> +
>> + pinctrl_i2c2_gpio: i2c2gpiogrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x1b0b0
>> + MX6QDL_PAD_KEY_ROW3__GPIO4_IO13 0x1b0b0
>> + >;
>> + };
>> +
>> + pinctrl_i2c3_gpio: i2c3gpiogrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_GPIO_3__GPIO1_IO03   0x1b0b0
>> + MX6QDL_PAD_GPIO_6__GPIO1_IO06   0x1b0b0
>> + >;
>> + };
>> +};
>> +
>> + {
>> + fsl,spi-num-chipselects = <1>;
>
> The property is obsoleted, and shouldn't be needed any more.
>
>> + cs-gpios = < 17 0>;
>
> Use polarity defines in dt-bindings/gpio/gpio.h.
>
>> + pinctrl-names = "default";
>> + pinctrl-0 = <_ecspi5>;
>> + status = "okay";
>> +
>> + m25_eeprom: m25p80@0 {
>> + compatible = "atmel,at25";
>> + spi-max-frequency = <2000>;
>> + size = <0x8000>;
>> + pagesize = <64>;
>> + reg = <0>;
>> + address-width = <16>;
>> + };
>> +};
>> +
>> + {
>> + clock-frequency = <10>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <_i2c1>;
>> + status =

Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-05 Thread Shawn Guo 
On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote:
> Add support for Advantech DMS-BA16 board, which use
> the Advantech BA-16 module.
> 
> Signed-off-by: Ken Lin 
> ---
>  arch/arm/boot/dts/Makefile   |   1 +
>  arch/arm/boot/dts/imx6q-dms-ba16.dts | 154 
> +++
>  2 files changed, 155 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ade7a38543dc..d97511273f30 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -428,6 +428,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>   imx6q-b450v3.dtb \
>   imx6q-b650v3.dtb \
>   imx6q-b850v3.dtb \
> + imx6q-dms-ba16.dtb \
>   imx6q-cm-fx6.dtb \
>   imx6q-cubox-i.dtb \
>   imx6q-cubox-i-emmc-som-v15.dtb \
> diff --git a/arch/arm/boot/dts/imx6q-dms-ba16.dts 
> b/arch/arm/boot/dts/imx6q-dms-ba16.dts
> new file mode 100644
> index ..4c5e17a17cbd
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6q-dms-ba16.dts
> @@ -0,0 +1,154 @@
> +/*
> + * Copyright 2018 Advantech Corporation
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */

Please use SPDX tag.

> +
> +/dts-v1/;
> +
> +#include 
> +#include "imx6q-ba16.dtsi"
> +
> +/ {
> + model = "Advantech DMS-BA16";
> + compatible = "fsl,imx6q-dms-ba16", "fsl,imx6q";
> +
> + clocks {
> + mclk: clock@0 {

Please give it an unique name like clock-xxx and put it directly under
root, and drop unit-address and 'reg' property.

> + compatible = "fixed-clock";
> + reg = <0>;
> + #clock-cells = <0>;
> + clock-frequency = <2200>;
> + };
> + };
> +
> + sound {
> + compatible = "fsl,imx6q-ba16-sgtl5000",
> +  "fsl,imx-audio-sgtl5000";
> + model = "imx6q-ba16-sgtl5000";
> + ssi-controller = <>;
> + audio-codec = <>;
> + audio-routing =
> + "MIC_IN", "Mic Jack",
> + "Mic Jack", "Mic Bias",
> + "Headphone Jack", "HP_OUT";
> + mux-int-port = <1>;
> + mux-ext-port = <4>;
> + };
> +
> + reg_usb_otg_vbus: regulator-usbotgvbus {
> + compatible = "regulator-fixed";
> + regulator-name = "usb_otg_vbus";
> + regulator-min-microvolt = <500>;
> + regulator-max-microvolt = <500>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_usbotgvbus>;
> + gpio = < 15 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +};
> +
> + {
> +
> + pinctrl_usbotgvbus: usbotgvbusgrp {

Please sort pinctrl entries alphabetically.

> + fsl,pins = <
> + MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x000b0
> + MX6QDL_PAD_GPIO_1__USB_OTG_ID   0x17059
> + >;
> + };
> +
> + pinctrl_i2c1_gpio: i2c1gpiogrp {
> + fsl,pins = <
> + MX6QDL_PAD_CSI0_DAT8__GPIO5_IO260x1b0b0
> + MX6QDL_PAD_CSI0_DAT9__GPIO5_IO270x1b0b0
> + >;
> + };
> +
> + pinctrl_i2c2_gpio: i2c2gpiogrp {
> + fsl,pins = <
> + MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x1b0b0
> + MX6QDL_PAD_KEY_ROW3__GPIO4_IO13 0x1b0b0
> + >;
> + };
> +
> + pinctrl_i2c3_gpio: i2c3gpiogrp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_3__GPIO1_IO03   0x1b0b0
> + MX6QDL_PAD_GPIO_6__GPIO1_IO06   0x1b0b0
> + >;
> + };
> +};
> +
> + {
> + fsl,spi-num-chipselects = <1>;

The property is obsoleted, and shouldn't be needed any more.

> + cs-gpios = < 17 0>;

Use polarity defines in dt-bindings/gpio/gpio.h.

> + pinctrl-names = "default";
> + pinctrl-0 = <_ecspi5>;
> + status = "okay";
> +
> + m25_eeprom: m25p80@0 {
> + compatible = "atmel,at25";
> + spi-max-frequency = <2000>;
> + size = <0x8000>;
> + pagesize = <64>;
> + reg = <0>;
> + address-width = <16>;
> + };
> +};
> +
> + {
> + clock-frequency = <10>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c1>;
> + status = "okay";
> +
> + sgtl5000: codec@0a {

Drop the leading zeros in unit-address.

> + compatible = "fsl,sgtl5000";
> + reg = <0x0a>;
> + clocks = <>;
> + lrclk-strength = <0x3>;
> + VDDA-supply = <_1p8v>;
> + VDDIO-supply =

Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-05 Thread Shawn Guo 
On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote:
> Add support for Advantech DMS-BA16 board, which use
> the Advantech BA-16 module.
> 
> Signed-off-by: Ken Lin 
> ---
>  arch/arm/boot/dts/Makefile   |   1 +
>  arch/arm/boot/dts/imx6q-dms-ba16.dts | 154 
> +++
>  2 files changed, 155 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ade7a38543dc..d97511273f30 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -428,6 +428,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>   imx6q-b450v3.dtb \
>   imx6q-b650v3.dtb \
>   imx6q-b850v3.dtb \
> + imx6q-dms-ba16.dtb \
>   imx6q-cm-fx6.dtb \
>   imx6q-cubox-i.dtb \
>   imx6q-cubox-i-emmc-som-v15.dtb \
> diff --git a/arch/arm/boot/dts/imx6q-dms-ba16.dts 
> b/arch/arm/boot/dts/imx6q-dms-ba16.dts
> new file mode 100644
> index ..4c5e17a17cbd
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6q-dms-ba16.dts
> @@ -0,0 +1,154 @@
> +/*
> + * Copyright 2018 Advantech Corporation
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */

Please use SPDX tag.

> +
> +/dts-v1/;
> +
> +#include 
> +#include "imx6q-ba16.dtsi"
> +
> +/ {
> + model = "Advantech DMS-BA16";
> + compatible = "fsl,imx6q-dms-ba16", "fsl,imx6q";
> +
> + clocks {
> + mclk: clock@0 {

Please give it an unique name like clock-xxx and put it directly under
root, and drop unit-address and 'reg' property.

> + compatible = "fixed-clock";
> + reg = <0>;
> + #clock-cells = <0>;
> + clock-frequency = <2200>;
> + };
> + };
> +
> + sound {
> + compatible = "fsl,imx6q-ba16-sgtl5000",
> +  "fsl,imx-audio-sgtl5000";
> + model = "imx6q-ba16-sgtl5000";
> + ssi-controller = <>;
> + audio-codec = <>;
> + audio-routing =
> + "MIC_IN", "Mic Jack",
> + "Mic Jack", "Mic Bias",
> + "Headphone Jack", "HP_OUT";
> + mux-int-port = <1>;
> + mux-ext-port = <4>;
> + };
> +
> + reg_usb_otg_vbus: regulator-usbotgvbus {
> + compatible = "regulator-fixed";
> + regulator-name = "usb_otg_vbus";
> + regulator-min-microvolt = <500>;
> + regulator-max-microvolt = <500>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_usbotgvbus>;
> + gpio = < 15 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +};
> +
> + {
> +
> + pinctrl_usbotgvbus: usbotgvbusgrp {

Please sort pinctrl entries alphabetically.

> + fsl,pins = <
> + MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x000b0
> + MX6QDL_PAD_GPIO_1__USB_OTG_ID   0x17059
> + >;
> + };
> +
> + pinctrl_i2c1_gpio: i2c1gpiogrp {
> + fsl,pins = <
> + MX6QDL_PAD_CSI0_DAT8__GPIO5_IO260x1b0b0
> + MX6QDL_PAD_CSI0_DAT9__GPIO5_IO270x1b0b0
> + >;
> + };
> +
> + pinctrl_i2c2_gpio: i2c2gpiogrp {
> + fsl,pins = <
> + MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x1b0b0
> + MX6QDL_PAD_KEY_ROW3__GPIO4_IO13 0x1b0b0
> + >;
> + };
> +
> + pinctrl_i2c3_gpio: i2c3gpiogrp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_3__GPIO1_IO03   0x1b0b0
> + MX6QDL_PAD_GPIO_6__GPIO1_IO06   0x1b0b0
> + >;
> + };
> +};
> +
> + {
> + fsl,spi-num-chipselects = <1>;

The property is obsoleted, and shouldn't be needed any more.

> + cs-gpios = < 17 0>;

Use polarity defines in dt-bindings/gpio/gpio.h.

> + pinctrl-names = "default";
> + pinctrl-0 = <_ecspi5>;
> + status = "okay";
> +
> + m25_eeprom: m25p80@0 {
> + compatible = "atmel,at25";
> + spi-max-frequency = <2000>;
> + size = <0x8000>;
> + pagesize = <64>;
> + reg = <0>;
> + address-width = <16>;
> + };
> +};
> +
> + {
> + clock-frequency = <10>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c1>;
> + status = "okay";
> +
> + sgtl5000: codec@0a {

Drop the leading zeros in unit-address.

> + compatible = "fsl,sgtl5000";
> + reg = <0x0a>;
> + clocks = <>;
> + lrclk-strength = <0x3>;
> + VDDA-supply = <_1p8v>;
> + VDDIO-supply = <_3p3v>;
> + };
> +};
>

Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-04 Thread Yung-Ching LIN 
Hi Andrew,

Will provide the v2 for all the fixes.
Thank you for the comments.

On Sun, Feb 4, 2018 at 11:22 AM, Andrew Lunn  wrote:
> On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote:
>> Add support for Advantech DMS-BA16 board, which use
>> the Advantech BA-16 module.
>>
>> Signed-off-by: Ken Lin 
>> ---
>>  arch/arm/boot/dts/Makefile   |   1 +
>>  arch/arm/boot/dts/imx6q-dms-ba16.dts | 154 
>> +++
>>  2 files changed, 155 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index ade7a38543dc..d97511273f30 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -428,6 +428,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>>   imx6q-b450v3.dtb \
>>   imx6q-b650v3.dtb \
>>   imx6q-b850v3.dtb \
>> + imx6q-dms-ba16.dtb \
>>   imx6q-cm-fx6.dtb \
>>   imx6q-cubox-i.dtb \
>>   imx6q-cubox-i-emmc-som-v15.dtb \
>
> Hi Ken
>
> I think the intention is to keep this list sorted. So dms puts it
> later, after cubox.
>

Thanks. will fix the order issue in the v2.

>> @@ -0,0 +1,154 @@
>> +/*
>> + * Copyright 2018 Advantech Corporation
>> + *
>> + * The code contained herein is licensed under the GNU General Public
>> + * License. You may obtain a copy of the GNU General Public License
>> + * Version 2 or later at the following locations:
>> + *
>> + * http://www.opensource.org/licenses/gpl-license.html
>> + * http://www.gnu.org/copyleft/gpl.html
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include 
>> +#include "imx6q-ba16.dtsi"
>> +
>> +/ {
>> + model = "Advantech DMS-BA16";
>> + compatible = "fsl,imx6q-dms-ba16", "fsl,imx6q";
>
> This looks wrong. I would expect "advantech,imx6q-dms-ba16".
>
>  Andrew

Thanks. will fix the board comptability issue in the v2.

Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-04 Thread Yung-Ching LIN 
Hi Andrew,

Will provide the v2 for all the fixes.
Thank you for the comments.

On Sun, Feb 4, 2018 at 11:22 AM, Andrew Lunn  wrote:
> On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote:
>> Add support for Advantech DMS-BA16 board, which use
>> the Advantech BA-16 module.
>>
>> Signed-off-by: Ken Lin 
>> ---
>>  arch/arm/boot/dts/Makefile   |   1 +
>>  arch/arm/boot/dts/imx6q-dms-ba16.dts | 154 
>> +++
>>  2 files changed, 155 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index ade7a38543dc..d97511273f30 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -428,6 +428,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>>   imx6q-b450v3.dtb \
>>   imx6q-b650v3.dtb \
>>   imx6q-b850v3.dtb \
>> + imx6q-dms-ba16.dtb \
>>   imx6q-cm-fx6.dtb \
>>   imx6q-cubox-i.dtb \
>>   imx6q-cubox-i-emmc-som-v15.dtb \
>
> Hi Ken
>
> I think the intention is to keep this list sorted. So dms puts it
> later, after cubox.
>

Thanks. will fix the order issue in the v2.

>> @@ -0,0 +1,154 @@
>> +/*
>> + * Copyright 2018 Advantech Corporation
>> + *
>> + * The code contained herein is licensed under the GNU General Public
>> + * License. You may obtain a copy of the GNU General Public License
>> + * Version 2 or later at the following locations:
>> + *
>> + * http://www.opensource.org/licenses/gpl-license.html
>> + * http://www.gnu.org/copyleft/gpl.html
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include 
>> +#include "imx6q-ba16.dtsi"
>> +
>> +/ {
>> + model = "Advantech DMS-BA16";
>> + compatible = "fsl,imx6q-dms-ba16", "fsl,imx6q";
>
> This looks wrong. I would expect "advantech,imx6q-dms-ba16".
>
>  Andrew

Thanks. will fix the board comptability issue in the v2.

Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-04 Thread Andrew Lunn 
On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote:
> Add support for Advantech DMS-BA16 board, which use
> the Advantech BA-16 module.
> 
> Signed-off-by: Ken Lin 
> ---
>  arch/arm/boot/dts/Makefile   |   1 +
>  arch/arm/boot/dts/imx6q-dms-ba16.dts | 154 
> +++
>  2 files changed, 155 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ade7a38543dc..d97511273f30 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -428,6 +428,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>   imx6q-b450v3.dtb \
>   imx6q-b650v3.dtb \
>   imx6q-b850v3.dtb \
> + imx6q-dms-ba16.dtb \
>   imx6q-cm-fx6.dtb \
>   imx6q-cubox-i.dtb \
>   imx6q-cubox-i-emmc-som-v15.dtb \

Hi Ken

I think the intention is to keep this list sorted. So dms puts it
later, after cubox.

> @@ -0,0 +1,154 @@
> +/*
> + * Copyright 2018 Advantech Corporation
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/dts-v1/;
> +
> +#include 
> +#include "imx6q-ba16.dtsi"
> +
> +/ {
> + model = "Advantech DMS-BA16";
> + compatible = "fsl,imx6q-dms-ba16", "fsl,imx6q";

This looks wrong. I would expect "advantech,imx6q-dms-ba16".

 Andrew

Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-04 Thread Andrew Lunn 
On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote:
> Add support for Advantech DMS-BA16 board, which use
> the Advantech BA-16 module.
> 
> Signed-off-by: Ken Lin 
> ---
>  arch/arm/boot/dts/Makefile   |   1 +
>  arch/arm/boot/dts/imx6q-dms-ba16.dts | 154 
> +++
>  2 files changed, 155 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ade7a38543dc..d97511273f30 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -428,6 +428,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>   imx6q-b450v3.dtb \
>   imx6q-b650v3.dtb \
>   imx6q-b850v3.dtb \
> + imx6q-dms-ba16.dtb \
>   imx6q-cm-fx6.dtb \
>   imx6q-cubox-i.dtb \
>   imx6q-cubox-i-emmc-som-v15.dtb \

Hi Ken

I think the intention is to keep this list sorted. So dms puts it
later, after cubox.

> @@ -0,0 +1,154 @@
> +/*
> + * Copyright 2018 Advantech Corporation
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/dts-v1/;
> +
> +#include 
> +#include "imx6q-ba16.dtsi"
> +
> +/ {
> + model = "Advantech DMS-BA16";
> + compatible = "fsl,imx6q-dms-ba16", "fsl,imx6q";

This looks wrong. I would expect "advantech,imx6q-dms-ba16".

 Andrew