Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-13 Thread Russell King - ARM Linux
On Thu, Sep 13, 2012 at 10:20:30AM +0800, Raul Xiong wrote: > I have several questions: > 1. Even we call flush_calche_all in __cpu_suspend_save, since later we > will outer_clean_range which may cause cache operations so we still > need to flush again in finisher, right? Why would it? Any data

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-13 Thread Russell King - ARM Linux
On Thu, Sep 13, 2012 at 10:20:30AM +0800, Raul Xiong wrote: I have several questions: 1. Even we call flush_calche_all in __cpu_suspend_save, since later we will outer_clean_range which may cause cache operations so we still need to flush again in finisher, right? Why would it? Any data

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Raul Xiong
2012/9/12 Russell King - ARM Linux : > On Wed, Sep 12, 2012 at 02:40:45PM +0530, Shilimkar, Santosh wrote: >> On Wed, Sep 12, 2012 at 2:24 PM, Russell King - ARM Linux >> wrote: >> > On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote: >> >> On Wed, Sep 12, 2012 at 12:48 PM, wzch

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Shilimkar, Santosh
On Wed, Sep 12, 2012 at 3:16 PM, Russell King - ARM Linux wrote: > On Wed, Sep 12, 2012 at 02:40:45PM +0530, Shilimkar, Santosh wrote: >> On Wed, Sep 12, 2012 at 2:24 PM, Russell King - ARM Linux >> wrote: >> > On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote: >> >> On Wed, Sep

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Russell King - ARM Linux
On Wed, Sep 12, 2012 at 02:40:45PM +0530, Shilimkar, Santosh wrote: > On Wed, Sep 12, 2012 at 2:24 PM, Russell King - ARM Linux > wrote: > > On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote: > >> On Wed, Sep 12, 2012 at 12:48 PM, wzch wrote: > >> > void __cpu_suspend_save(u32

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Shilimkar, Santosh
On Wed, Sep 12, 2012 at 2:28 PM, Lorenzo Pieralisi wrote: > On Wed, Sep 12, 2012 at 08:43:33AM +0100, Shilimkar, Santosh wrote: >> + Lorenzo, >> >> On Wed, Sep 12, 2012 at 12:48 PM, wzch wrote: >> > From: Wenzeng Chen >> > >> > In cpu suspend function __cpu_suspend_save(), we save cp15

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Shilimkar, Santosh
On Wed, Sep 12, 2012 at 2:24 PM, Russell King - ARM Linux wrote: > On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote: >> On Wed, Sep 12, 2012 at 12:48 PM, wzch wrote: >> > void __cpu_suspend_save(u32 *ptr, u32 ptrsz, u32 sp, u32 *save_ptr) >> > { >> > + u32 *ptr_orig =

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Lorenzo Pieralisi
On Wed, Sep 12, 2012 at 08:43:33AM +0100, Shilimkar, Santosh wrote: > + Lorenzo, > > On Wed, Sep 12, 2012 at 12:48 PM, wzch wrote: > > From: Wenzeng Chen > > > > In cpu suspend function __cpu_suspend_save(), we save cp15 registers, > > resume function, sp and suspend_pgd, then flush the data to

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Russell King - ARM Linux
On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote: > On Wed, Sep 12, 2012 at 12:48 PM, wzch wrote: > > void __cpu_suspend_save(u32 *ptr, u32 ptrsz, u32 sp, u32 *save_ptr) > > { > > + u32 *ptr_orig = ptr; > > *save_ptr = virt_to_phys(ptr); > > > > /* This

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Shilimkar, Santosh
+ Lorenzo, On Wed, Sep 12, 2012 at 12:48 PM, wzch wrote: > From: Wenzeng Chen > > In cpu suspend function __cpu_suspend_save(), we save cp15 registers, > resume function, sp and suspend_pgd, then flush the data to DDR, but > no need to flush all D cache, only need to flush range. > > Change-Id:

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Shilimkar, Santosh
+ Lorenzo, On Wed, Sep 12, 2012 at 12:48 PM, wzch w...@marvell.com wrote: From: Wenzeng Chen w...@marvell.com In cpu suspend function __cpu_suspend_save(), we save cp15 registers, resume function, sp and suspend_pgd, then flush the data to DDR, but no need to flush all D cache, only need to

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Russell King - ARM Linux
On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote: On Wed, Sep 12, 2012 at 12:48 PM, wzch w...@marvell.com wrote: void __cpu_suspend_save(u32 *ptr, u32 ptrsz, u32 sp, u32 *save_ptr) { + u32 *ptr_orig = ptr; *save_ptr = virt_to_phys(ptr); /*

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Lorenzo Pieralisi
On Wed, Sep 12, 2012 at 08:43:33AM +0100, Shilimkar, Santosh wrote: + Lorenzo, On Wed, Sep 12, 2012 at 12:48 PM, wzch w...@marvell.com wrote: From: Wenzeng Chen w...@marvell.com In cpu suspend function __cpu_suspend_save(), we save cp15 registers, resume function, sp and suspend_pgd,

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Shilimkar, Santosh
On Wed, Sep 12, 2012 at 2:24 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote: On Wed, Sep 12, 2012 at 12:48 PM, wzch w...@marvell.com wrote: void __cpu_suspend_save(u32 *ptr, u32 ptrsz, u32 sp, u32 *save_ptr) {

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Shilimkar, Santosh
On Wed, Sep 12, 2012 at 2:28 PM, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote: On Wed, Sep 12, 2012 at 08:43:33AM +0100, Shilimkar, Santosh wrote: + Lorenzo, On Wed, Sep 12, 2012 at 12:48 PM, wzch w...@marvell.com wrote: From: Wenzeng Chen w...@marvell.com In cpu suspend function

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Russell King - ARM Linux
On Wed, Sep 12, 2012 at 02:40:45PM +0530, Shilimkar, Santosh wrote: On Wed, Sep 12, 2012 at 2:24 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote: On Wed, Sep 12, 2012 at 12:48 PM, wzch w...@marvell.com wrote:

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Shilimkar, Santosh
On Wed, Sep 12, 2012 at 3:16 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Sep 12, 2012 at 02:40:45PM +0530, Shilimkar, Santosh wrote: On Wed, Sep 12, 2012 at 2:24 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Sep 12, 2012 at 01:13:33PM +0530,

Re: [PATCH] ARM: suspend: use flush range instead of flush all

2012-09-12 Thread Raul Xiong
2012/9/12 Russell King - ARM Linux li...@arm.linux.org.uk: On Wed, Sep 12, 2012 at 02:40:45PM +0530, Shilimkar, Santosh wrote: On Wed, Sep 12, 2012 at 2:24 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote: On Wed,