Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
On Mon, Aug 7, 2017 at 12:40 PM, Arnd Bergmann wrote:
> When the audio driver selects CONFIG_PXA_SSP to be a loadable
> module on a platform other than PXA, and the PXA SPI driver
> is built-in, we get a link error in the SPI driver:
>
> drivers/spi/spi-pxa2xx.o: In function `pxa2xx_spi_remove':
> spi-pxa2xx.c:(.text+0x5f0): undefined reference to `pxa_ssp_free'
> drivers/spi/spi-pxa2xx.o: In function `pxa2xx_spi_probe':
> spi-pxa2xx.c:(.text+0xeac): undefined reference to `pxa_ssp_request'
> spi-pxa2xx.c:(.text+0x1468): undefined reference to `pxa_ssp_free'
> spi-pxa2xx.c:(.text+0x15bc): undefined reference to `pxa_ssp_free'
>
> Fixes: 73d7ee2e831f ("ASoC: pxa: add COMPILE_TEST on SND_PXA2XX_SOC")
> Signed-off-by: Arnd Bergmann
While trying to write up a better changelog, I found that I had run into this
before and attempted a different fix, see
https://patchwork.kernel.org/patch/8879921/
The commit I referred to in "Fixes:" did not introduce a new problem at
all, but it appears to have made it more likely to run into this situation.
Sending a third patch now, again different.
Mark, let me know if you want something else instead.
Arnd
Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
On Mon, Aug 07, 2017 at 01:58:29PM +0200, Arnd Bergmann wrote: > On Mon, Aug 7, 2017 at 1:48 PM, Mark Brown wrote: > > Still missing a few steps of reasoning here... > Sorry, I just realized that you were trying to point out the incomplete > changelog. I must have accidentally closed the editor while working on > it, and then sent it out today after getting no regressions. > I'll resend with a proper changelog. Thanks! signature.asc Description: PGP signature
Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
On Mon, Aug 7, 2017 at 1:48 PM, Mark Brown wrote: > On Mon, Aug 07, 2017 at 01:36:09PM +0200, Arnd Bergmann wrote: >> On Mon, Aug 7, 2017 at 1:20 PM, Mark Brown wrote: >> > On Mon, Aug 07, 2017 at 12:40:44PM +0200, Arnd Bergmann wrote: >> >> When the audio driver selects CONFIG_PXA_SSP to be a loadable >> >> module on a platform other than PXA, and the PXA SPI driver >> >> is built-in, we get a link error in the SPI driver: > >> > Why doesn't this cause problems on PXA? > >> On PXA, we 'make' descends into arch/arm/plat-pxa/, where ssp.o >> is located. On other ARM platforms (I guess except for MMP), >> PLAT_PXA is not set, and on non-ARM architectures, we can't >> get there anyway. > > Still missing a few steps of reasoning here... Sorry, I just realized that you were trying to point out the incomplete changelog. I must have accidentally closed the editor while working on it, and then sent it out today after getting no regressions. I'll resend with a proper changelog. Arnd
Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
On Mon, Aug 07, 2017 at 01:36:09PM +0200, Arnd Bergmann wrote: > On Mon, Aug 7, 2017 at 1:20 PM, Mark Brown wrote: > > On Mon, Aug 07, 2017 at 12:40:44PM +0200, Arnd Bergmann wrote: > >> When the audio driver selects CONFIG_PXA_SSP to be a loadable > >> module on a platform other than PXA, and the PXA SPI driver > >> is built-in, we get a link error in the SPI driver: > > Why doesn't this cause problems on PXA? > On PXA, we 'make' descends into arch/arm/plat-pxa/, where ssp.o > is located. On other ARM platforms (I guess except for MMP), > PLAT_PXA is not set, and on non-ARM architectures, we can't > get there anyway. Still missing a few steps of reasoning here... signature.asc Description: PGP signature
Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
On Mon, Aug 7, 2017 at 1:20 PM, Mark Brown wrote: > On Mon, Aug 07, 2017 at 12:40:44PM +0200, Arnd Bergmann wrote: >> When the audio driver selects CONFIG_PXA_SSP to be a loadable >> module on a platform other than PXA, and the PXA SPI driver >> is built-in, we get a link error in the SPI driver: > > Why doesn't this cause problems on PXA? On PXA, we 'make' descends into arch/arm/plat-pxa/, where ssp.o is located. On other ARM platforms (I guess except for MMP), PLAT_PXA is not set, and on non-ARM architectures, we can't get there anyway. Arnd
Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
On Mon, Aug 07, 2017 at 12:40:44PM +0200, Arnd Bergmann wrote: > When the audio driver selects CONFIG_PXA_SSP to be a loadable > module on a platform other than PXA, and the PXA SPI driver > is built-in, we get a link error in the SPI driver: Why doesn't this cause problems on PXA? signature.asc Description: PGP signature
