Re: [PATCH] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

[Donglin Peng]

On Fri, Feb 9, 2018 at 9:21 PM, Andy Shevchenko
 wrote:
> On Fri, Feb 9, 2018 at 8:58 AM, Donglin Peng  wrote:
>> There is some duplicate code in soc-core.c,and the kernel provides
>
> 'core.c,and' -> 'core.c, and'
>
>> +static int codec_list_show(struct seq_file *s, void *v)
>
> No need to rename m -> s.
>
>> +static int dai_list_show(struct seq_file *s, void *v)
>
> Ditto.
>
>> +static int platform_list_show(struct seq_file *s, void *v)
>
> Ditto.
>
> After addressing above,
>
> Reviewed-by: Andy Shevchenko 
>
> --
> With Best Regards,
> Andy Shevchenko
Thanks for review, and I will send a patch v2.

Re: [PATCH] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

[Andy Shevchenko]

On Fri, Feb 9, 2018 at 8:58 AM, Donglin Peng  wrote:
> There is some duplicate code in soc-core.c,and the kernel provides

'core.c,and' -> 'core.c, and'

> +static int codec_list_show(struct seq_file *s, void *v)

No need to rename m -> s.

> +static int dai_list_show(struct seq_file *s, void *v)

Ditto.

> +static int platform_list_show(struct seq_file *s, void *v)

Ditto.

After addressing above,

Reviewed-by: Andy Shevchenko 

-- 
With Best Regards,
Andy Shevchenko