Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

2017-07-24 Thread Borislav Petkov
On Sun, Jul 23, 2017 at 01:25:56AM -0500, Gustavo A. R. Silva wrote: > Lesson learned, your original script should remain as is. :) Ok, then please send Julia's script as a separate patch and then in the EDAC patch, reference the path to that coccinelle patch so that it is clear what has been used

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

2017-07-22 Thread Gustavo A. R. Silva
On 07/23/2017 12:53 AM, Julia Lawall wrote: On Sun, 23 Jul 2017, Gustavo A. R. Silva wrote: Hi Julia, On 07/23/2017 12:07 AM, Julia Lawall wrote: On Sat, 22 Jul 2017, Gustavo A. R. Silva wrote: Hi Julia, Borislav, On 07/22/2017 11:22 AM, Gustavo A. R. Silva wrote: Hi all, On 07/22/

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

2017-07-22 Thread Julia Lawall
On Sun, 23 Jul 2017, Gustavo A. R. Silva wrote: > Hi Julia, > > On 07/23/2017 12:07 AM, Julia Lawall wrote: > > > > > > On Sat, 22 Jul 2017, Gustavo A. R. Silva wrote: > > > > > Hi Julia, Borislav, > > > > > > On 07/22/2017 11:22 AM, Gustavo A. R. Silva wrote: > > > > Hi all, > > > > > > > > On

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

2017-07-22 Thread Gustavo A. R. Silva
Hi Julia, On 07/23/2017 12:07 AM, Julia Lawall wrote: On Sat, 22 Jul 2017, Gustavo A. R. Silva wrote: Hi Julia, Borislav, On 07/22/2017 11:22 AM, Gustavo A. R. Silva wrote: Hi all, On 07/22/2017 01:36 AM, Borislav Petkov wrote: On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

2017-07-22 Thread Julia Lawall
On Sat, 22 Jul 2017, Gustavo A. R. Silva wrote: > Hi Julia, Borislav, > > On 07/22/2017 11:22 AM, Gustavo A. R. Silva wrote: > > Hi all, > > > > On 07/22/2017 01:36 AM, Borislav Petkov wrote: > > > On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote: > > > > Someone pointed out that the

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

2017-07-22 Thread Gustavo A. R. Silva
Hi Julia, Borislav, On 07/22/2017 11:22 AM, Gustavo A. R. Silva wrote: Hi all, On 07/22/2017 01:36 AM, Borislav Petkov wrote: On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote: Someone pointed out that the rule is probably not OK when the address of the static variable is taken, be

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

2017-07-22 Thread Gustavo A. R. Silva
Hi all, On 07/22/2017 01:36 AM, Borislav Petkov wrote: On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote: Someone pointed out that the rule is probably not OK when the address of the static variable is taken, because then it is likely being used as permanent storage. Makes sense to

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

2017-07-21 Thread Julia Lawall
On Sat, 22 Jul 2017, Borislav Petkov wrote: > On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote: > > Someone pointed out that the rule is probably not OK when the address of > > the static variable is taken, because then it is likely being used as > > permanent storage. > > Makes sens

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

2017-07-21 Thread Borislav Petkov
On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote: > Someone pointed out that the rule is probably not OK when the address of > the static variable is taken, because then it is likely being used as > permanent storage. Makes sense to me. > An improved rule is: Do you think it is worth

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

2017-07-21 Thread Julia Lawall
On Mon, 17 Jul 2017, Borislav Petkov wrote: > On Tue, Jul 04, 2017 at 04:44:40PM -0500, Gustavo A. R. Silva wrote: > > Remove unnecessary static on local variable _type_. > > Such variable is initialized before being used, > > on every execution path throughout the function. > > The static has n

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

2017-07-17 Thread Borislav Petkov
On Tue, Jul 04, 2017 at 04:44:40PM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variable _type_. > Such variable is initialized before being used, > on every execution path throughout the function. > The static has no benefit and, removing it reduces > the code size. > >