Re: [PATCH] KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

2021-02-18 Thread Paolo Bonzini
On 18/02/21 18:55, Jim Mattson wrote: Got it now. It would sort of help, because while dumping the MSR load/store area you could get hold of the real EFER, and use it to decide whether to dump the PDPTRs. EFER isn't guaranteed to be in the load list, either, e.g. if guest and host have the

Re: [PATCH] KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

2021-02-18 Thread Jim Mattson
On Thu, Feb 18, 2021 at 8:35 AM Sean Christopherson wrote: > > On Thu, Feb 18, 2021, Paolo Bonzini wrote: > > On 18/02/21 13:56, David Edmondson wrote: > > > On Thursday, 2021-02-18 at 12:54:52 +01, Paolo Bonzini wrote: > > > > > > > On 18/02/21 11:04, David Edmondson wrote: > > > > > When

Re: [PATCH] KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

2021-02-18 Thread Sean Christopherson
On Thu, Feb 18, 2021, Paolo Bonzini wrote: > On 18/02/21 13:56, David Edmondson wrote: > > On Thursday, 2021-02-18 at 12:54:52 +01, Paolo Bonzini wrote: > > > > > On 18/02/21 11:04, David Edmondson wrote: > > > > When dumping the VMCS, retrieve the current guest value of EFER from > > > > the

Re: [PATCH] KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

2021-02-18 Thread David Edmondson
On Thursday, 2021-02-18 at 14:01:40 +01, Paolo Bonzini wrote: > On 18/02/21 13:56, David Edmondson wrote: >> On Thursday, 2021-02-18 at 12:54:52 +01, Paolo Bonzini wrote: >> >>> On 18/02/21 11:04, David Edmondson wrote: When dumping the VMCS, retrieve the current guest value of EFER from

Re: [PATCH] KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

2021-02-18 Thread Paolo Bonzini
On 18/02/21 13:56, David Edmondson wrote: On Thursday, 2021-02-18 at 12:54:52 +01, Paolo Bonzini wrote: On 18/02/21 11:04, David Edmondson wrote: When dumping the VMCS, retrieve the current guest value of EFER from the kvm_vcpu structure if neither VM_EXIT_SAVE_IA32_EFER or

Re: [PATCH] KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

2021-02-18 Thread David Edmondson
On Thursday, 2021-02-18 at 12:54:52 +01, Paolo Bonzini wrote: > On 18/02/21 11:04, David Edmondson wrote: >> When dumping the VMCS, retrieve the current guest value of EFER from >> the kvm_vcpu structure if neither VM_EXIT_SAVE_IA32_EFER or >> VM_ENTRY_LOAD_IA32_EFER is set, which can occur if

Re: [PATCH] KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

2021-02-18 Thread Paolo Bonzini
On 18/02/21 11:04, David Edmondson wrote: When dumping the VMCS, retrieve the current guest value of EFER from the kvm_vcpu structure if neither VM_EXIT_SAVE_IA32_EFER or VM_ENTRY_LOAD_IA32_EFER is set, which can occur if the processor does not support the relevant VM-exit/entry controls.