Re: [PATCH] NFC: nfcmrvl: Include unaligned.h instead of access_ok.h
Hi Tobias, On Wed, Oct 26, 2016 at 11:00:12AM +0200, Tobias Klauser wrote: > Including linux/unaligned/access_ok.h causes the allmodconfig build on > ia64 (and maybe others) to fail with the following warnings: > > include/linux/unaligned/access_ok.h:7:19: error: redefinition of > 'get_unaligned_le16' > include/linux/unaligned/access_ok.h:12:19: error: redefinition of > 'get_unaligned_le32' > include/linux/unaligned/access_ok.h:17:19: error: redefinition of > 'get_unaligned_le64' > include/linux/unaligned/access_ok.h:22:19: error: redefinition of > 'get_unaligned_be16' > include/linux/unaligned/access_ok.h:27:19: error: redefinition of > 'get_unaligned_be32' > include/linux/unaligned/access_ok.h:32:19: error: redefinition of > 'get_unaligned_be64' > include/linux/unaligned/access_ok.h:37:20: error: redefinition of > 'put_unaligned_le16' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_le32' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_le64' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be16' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be32' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be64' > > Fix these by including asm/unaligned.h instead and leave it up to the > architecture to decide how to implement unaligned accesses. > > Fixes: 3194c6870158 ("NFC: nfcmrvl: add firmware download support") > Reported-by: kbuild test robot> Link: https://lkml.org/lkml/2016/10/22/247 > Cc: Vincent Cuissard > Signed-off-by: Tobias Klauser > --- > drivers/nfc/nfcmrvl/fw_dnld.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, with Guenter's patches as well. Cheers, Samuel.
Re: [PATCH] NFC: nfcmrvl: Include unaligned.h instead of access_ok.h
Hi Tobias, On Wed, Oct 26, 2016 at 11:00:12AM +0200, Tobias Klauser wrote: > Including linux/unaligned/access_ok.h causes the allmodconfig build on > ia64 (and maybe others) to fail with the following warnings: > > include/linux/unaligned/access_ok.h:7:19: error: redefinition of > 'get_unaligned_le16' > include/linux/unaligned/access_ok.h:12:19: error: redefinition of > 'get_unaligned_le32' > include/linux/unaligned/access_ok.h:17:19: error: redefinition of > 'get_unaligned_le64' > include/linux/unaligned/access_ok.h:22:19: error: redefinition of > 'get_unaligned_be16' > include/linux/unaligned/access_ok.h:27:19: error: redefinition of > 'get_unaligned_be32' > include/linux/unaligned/access_ok.h:32:19: error: redefinition of > 'get_unaligned_be64' > include/linux/unaligned/access_ok.h:37:20: error: redefinition of > 'put_unaligned_le16' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_le32' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_le64' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be16' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be32' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be64' > > Fix these by including asm/unaligned.h instead and leave it up to the > architecture to decide how to implement unaligned accesses. > > Fixes: 3194c6870158 ("NFC: nfcmrvl: add firmware download support") > Reported-by: kbuild test robot > Link: https://lkml.org/lkml/2016/10/22/247 > Cc: Vincent Cuissard > Signed-off-by: Tobias Klauser > --- > drivers/nfc/nfcmrvl/fw_dnld.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, with Guenter's patches as well. Cheers, Samuel.
Re: [PATCH] NFC: nfcmrvl: Include unaligned.h instead of access_ok.h
On 2016-10-26 at 11:00:12 +0200, Tobias Klauserwrote: > Including linux/unaligned/access_ok.h causes the allmodconfig build on > ia64 (and maybe others) to fail with the following warnings: > > include/linux/unaligned/access_ok.h:7:19: error: redefinition of > 'get_unaligned_le16' > include/linux/unaligned/access_ok.h:12:19: error: redefinition of > 'get_unaligned_le32' > include/linux/unaligned/access_ok.h:17:19: error: redefinition of > 'get_unaligned_le64' > include/linux/unaligned/access_ok.h:22:19: error: redefinition of > 'get_unaligned_be16' > include/linux/unaligned/access_ok.h:27:19: error: redefinition of > 'get_unaligned_be32' > include/linux/unaligned/access_ok.h:32:19: error: redefinition of > 'get_unaligned_be64' > include/linux/unaligned/access_ok.h:37:20: error: redefinition of > 'put_unaligned_le16' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_le32' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_le64' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be16' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be32' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be64' > > Fix these by including asm/unaligned.h instead and leave it up to the > architecture to decide how to implement unaligned accesses. > > Fixes: 3194c6870158 ("NFC: nfcmrvl: add firmware download support") > Reported-by: kbuild test robot > Link: https://lkml.org/lkml/2016/10/22/247 > Cc: Vincent Cuissard > Signed-off-by: Tobias Klauser There are two other instances of the same issue in the NFC subsystem, namely in drivers/nfc/nxp-nci/firmware.c and drivers/nfc/nxp-nci/i2c.c Guenter Roeck already sent a patch for these on 2015-08-01. It would be nice if it could be applied as well. [1] https://patchwork.kernel.org/patch/6922341/ Thanks
Re: [PATCH] NFC: nfcmrvl: Include unaligned.h instead of access_ok.h
On 2016-10-26 at 11:00:12 +0200, Tobias Klauser wrote: > Including linux/unaligned/access_ok.h causes the allmodconfig build on > ia64 (and maybe others) to fail with the following warnings: > > include/linux/unaligned/access_ok.h:7:19: error: redefinition of > 'get_unaligned_le16' > include/linux/unaligned/access_ok.h:12:19: error: redefinition of > 'get_unaligned_le32' > include/linux/unaligned/access_ok.h:17:19: error: redefinition of > 'get_unaligned_le64' > include/linux/unaligned/access_ok.h:22:19: error: redefinition of > 'get_unaligned_be16' > include/linux/unaligned/access_ok.h:27:19: error: redefinition of > 'get_unaligned_be32' > include/linux/unaligned/access_ok.h:32:19: error: redefinition of > 'get_unaligned_be64' > include/linux/unaligned/access_ok.h:37:20: error: redefinition of > 'put_unaligned_le16' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_le32' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_le64' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be16' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be32' > include/linux/unaligned/access_ok.h:42:20: error: redefinition of > 'put_unaligned_be64' > > Fix these by including asm/unaligned.h instead and leave it up to the > architecture to decide how to implement unaligned accesses. > > Fixes: 3194c6870158 ("NFC: nfcmrvl: add firmware download support") > Reported-by: kbuild test robot > Link: https://lkml.org/lkml/2016/10/22/247 > Cc: Vincent Cuissard > Signed-off-by: Tobias Klauser There are two other instances of the same issue in the NFC subsystem, namely in drivers/nfc/nxp-nci/firmware.c and drivers/nfc/nxp-nci/i2c.c Guenter Roeck already sent a patch for these on 2015-08-01. It would be nice if it could be applied as well. [1] https://patchwork.kernel.org/patch/6922341/ Thanks