Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-06 Thread Harald Welte
On Tue, Sep 06, 2005 at 09:15:10AM -0700, Roland Dreier wrote: > Harald> Obviously, if HZ would ever go below 100, the code above > Harald> would provide some problems. I'm not sure what the future > Harald> plans with HZ are, but I'll add an #error statement in > Harald> case HZ

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-06 Thread Roland Dreier
Harald> Obviously, if HZ would ever go below 100, the code above Harald> would provide some problems. I'm not sure what the future Harald> plans with HZ are, but I'll add an #error statement in Harald> case HZ goes smaller than that. It might be simpler just to define it to

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-06 Thread Roland Dreier
Harald Obviously, if HZ would ever go below 100, the code above Harald would provide some problems. I'm not sure what the future Harald plans with HZ are, but I'll add an #error statement in Harald case HZ goes smaller than that. It might be simpler just to define it to

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-06 Thread Harald Welte
On Tue, Sep 06, 2005 at 09:15:10AM -0700, Roland Dreier wrote: Harald Obviously, if HZ would ever go below 100, the code above Harald would provide some problems. I'm not sure what the future Harald plans with HZ are, but I'll add an #error statement in Harald case HZ goes

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-05 Thread Harald Welte
On Sat, Sep 03, 2005 at 04:27:00PM -0500, Chase Venters wrote: > > Below you can find a driver for the Omnikey CardMan 4040 PCMCIA > > Smartcard Reader. > > Someone correct me if I'm wrong, but wouldn't these #defines be a problem > with > the new HZ flexibility: > > #define

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-05 Thread Harald Welte
On Sun, Sep 04, 2005 at 12:27:20AM +0200, Jesper Juhl wrote: > On 9/4/05, Harald Welte <[EMAIL PROTECTED]> wrote: > > On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: > > > Hi! > > > > > > Below you can find a driver for the Omnikey CardMan 4040 PCMCIA > > > Smartcard Reader. > > > >

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-05 Thread Harald Welte
On Sun, Sep 04, 2005 at 02:58:27PM +0200, Ingo Oeser wrote: > just use > return nonseekable_open(inode, filp); > > to really disable any file pointer positioning (e.g. pwrite/pread too). > > Addtionally cmx_llseek() is implement already as "no_llseek()" > by the VFS, so you delete it from

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-05 Thread Harald Welte
On Sun, Sep 04, 2005 at 02:58:27PM +0200, Ingo Oeser wrote: just use return nonseekable_open(inode, filp); to really disable any file pointer positioning (e.g. pwrite/pread too). Addtionally cmx_llseek() is implement already as no_llseek() by the VFS, so you delete it from the

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-05 Thread Harald Welte
On Sun, Sep 04, 2005 at 12:27:20AM +0200, Jesper Juhl wrote: On 9/4/05, Harald Welte [EMAIL PROTECTED] wrote: On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: Hi! Below you can find a driver for the Omnikey CardMan 4040 PCMCIA Smartcard Reader. Sorry, the patch was

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-05 Thread Harald Welte
On Sat, Sep 03, 2005 at 04:27:00PM -0500, Chase Venters wrote: Below you can find a driver for the Omnikey CardMan 4040 PCMCIA Smartcard Reader. Someone correct me if I'm wrong, but wouldn't these #defines be a problem with the new HZ flexibility: #define

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-04 Thread Jesper Juhl
On 9/4/05, Horst von Brand <[EMAIL PROTECTED]> wrote: > Jesper Juhl <[EMAIL PROTECTED]> wrote: > > On 9/4/05, Harald Welte <[EMAIL PROTECTED]> wrote: > > > On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: > > > > Hi! > > > > > > > > Below you can find a driver for the Omnikey CardMan

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-04 Thread Horst von Brand
Jesper Juhl <[EMAIL PROTECTED]> wrote: > On 9/4/05, Harald Welte <[EMAIL PROTECTED]> wrote: > > On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: > > > Hi! > > > > > > Below you can find a driver for the Omnikey CardMan 4040 PCMCIA > > > Smartcard Reader. > > > > Sorry, the patch was

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-04 Thread Ingo Oeser
On Sunday 04 September 2005 12:12, Harald Welte wrote: > cmx_llseek just use return nonseekable_open(inode, filp); as your last statement in cmx_open() instead of return 0; to really disable any file pointer positioning (e.g. pwrite/pread too). Addtionally cmx_llseek() is

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-04 Thread Harald Welte
Hi Nish, thanks for your comments. On Sat, Sep 03, 2005 at 03:13:43PM -0700, Nish Aravamudan wrote: > On 9/3/05, Chase Venters <[EMAIL PROTECTED]> wrote: > > > Below you can find a driver for the Omnikey CardMan 4040 PCMCIA > > > Smartcard Reader. > > > > #define

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-04 Thread Harald Welte
Thanks for your comments, Alexey. I've now incorprorated all of the requested changes and am testing the driver. If everything is still fine, I'll repost later today. -- - Harald Welte <[EMAIL PROTECTED]> http://gnumonks.org/

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-04 Thread Harald Welte
Thanks for your comments, Alexey. I've now incorprorated all of the requested changes and am testing the driver. If everything is still fine, I'll repost later today. -- - Harald Welte [EMAIL PROTECTED] http://gnumonks.org/

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-04 Thread Harald Welte
Hi Nish, thanks for your comments. On Sat, Sep 03, 2005 at 03:13:43PM -0700, Nish Aravamudan wrote: On 9/3/05, Chase Venters [EMAIL PROTECTED] wrote: Below you can find a driver for the Omnikey CardMan 4040 PCMCIA Smartcard Reader. #define CCID_DRIVER_BULK_DEFAULT_TIMEOUT

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-04 Thread Ingo Oeser
On Sunday 04 September 2005 12:12, Harald Welte wrote: cmx_llseek just use return nonseekable_open(inode, filp); as your last statement in cmx_open() instead of return 0; to really disable any file pointer positioning (e.g. pwrite/pread too). Addtionally cmx_llseek() is

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-04 Thread Horst von Brand
Jesper Juhl [EMAIL PROTECTED] wrote: On 9/4/05, Harald Welte [EMAIL PROTECTED] wrote: On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: Hi! Below you can find a driver for the Omnikey CardMan 4040 PCMCIA Smartcard Reader. Sorry, the patch was missing a cg-add of the

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-04 Thread Jesper Juhl
On 9/4/05, Horst von Brand [EMAIL PROTECTED] wrote: Jesper Juhl [EMAIL PROTECTED] wrote: On 9/4/05, Harald Welte [EMAIL PROTECTED] wrote: On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: Hi! Below you can find a driver for the Omnikey CardMan 4040 PCMCIA

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Jesper Juhl
On 9/4/05, Harald Welte <[EMAIL PROTECTED]> wrote: > On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: > > Hi! > > > > Below you can find a driver for the Omnikey CardMan 4040 PCMCIA > > Smartcard Reader. > > Sorry, the patch was missing a "cg-add" of the header file. Please use >

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Chase Venters
> Um, 100/100 = 1, not 0? Oh my... it's been a long day. Regards, Chase Venters - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Nish Aravamudan
On 9/3/05, Chase Venters <[EMAIL PROTECTED]> wrote: > > Below you can find a driver for the Omnikey CardMan 4040 PCMCIA > > Smartcard Reader. > > Someone correct me if I'm wrong, but wouldn't these #defines be a problem > with the new HZ flexibility: > > #define CCID_DRIVER_BULK_DEFAULT_TIMEOUT

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Alexey Dobriyan
On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: > Below you can find a driver for the Omnikey CardMan 4040 PCMCIA > Smartcard Reader. > --- /dev/null > +++ b/drivers/char/pcmcia/cm4040_cs.c > +#include Not needed. > +static volatile char *version = Can we lose all volatile

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Harald Welte
On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: > Hi! > > Below you can find a driver for the Omnikey CardMan 4040 PCMCIA > Smartcard Reader. Sorry, the patch was missing a "cg-add" of the header file. Please use the patch below. -- - Harald Welte <[EMAIL PROTECTED]>

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Chase Venters
> Below you can find a driver for the Omnikey CardMan 4040 PCMCIA > Smartcard Reader. Someone correct me if I'm wrong, but wouldn't these #defines be a problem with the new HZ flexibility: #define CCID_DRIVER_BULK_DEFAULT_TIMEOUT(150*HZ) #define CCID_DRIVER_ASYNC_POWERUP_TIMEOUT

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Chase Venters
Below you can find a driver for the Omnikey CardMan 4040 PCMCIA Smartcard Reader. Someone correct me if I'm wrong, but wouldn't these #defines be a problem with the new HZ flexibility: #define CCID_DRIVER_BULK_DEFAULT_TIMEOUT(150*HZ) #define CCID_DRIVER_ASYNC_POWERUP_TIMEOUT

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Harald Welte
On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: Hi! Below you can find a driver for the Omnikey CardMan 4040 PCMCIA Smartcard Reader. Sorry, the patch was missing a cg-add of the header file. Please use the patch below. -- - Harald Welte [EMAIL PROTECTED]

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Alexey Dobriyan
On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: Below you can find a driver for the Omnikey CardMan 4040 PCMCIA Smartcard Reader. --- /dev/null +++ b/drivers/char/pcmcia/cm4040_cs.c +#include linux/config.h Not needed. +static volatile char *version = Can we lose all

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Nish Aravamudan
On 9/3/05, Chase Venters [EMAIL PROTECTED] wrote: Below you can find a driver for the Omnikey CardMan 4040 PCMCIA Smartcard Reader. Someone correct me if I'm wrong, but wouldn't these #defines be a problem with the new HZ flexibility: #define CCID_DRIVER_BULK_DEFAULT_TIMEOUT

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Chase Venters
Um, 100/100 = 1, not 0? Oh my... it's been a long day. Regards, Chase Venters - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

2005-09-03 Thread Jesper Juhl
On 9/4/05, Harald Welte [EMAIL PROTECTED] wrote: On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: Hi! Below you can find a driver for the Omnikey CardMan 4040 PCMCIA Smartcard Reader. Sorry, the patch was missing a cg-add of the header file. Please use the patch below.