RE: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL pointer

2016-10-21 Thread Leo Li 


> -Original Message-
> From: Bjorn Helgaas [mailto:helg...@kernel.org]
> Sent: Friday, October 21, 2016 10:37 AM
> To: Leo Li <leoyang...@nxp.com>
> Cc: Bjorn Helgaas <bhelg...@google.com>; Minghuan Lian
> <minghuan.l...@freescale.com>; Mingkai Hu <mingkai...@freescale.com>;
> Roy Zang <tie-fei.z...@freescale.com>; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Stuart Yoder
> <stuart.yo...@nxp.com>
> Subject: Re: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL 
> pointer
> 
> On Mon, Oct 17, 2016 at 04:44:06PM -0500, Li Yang wrote:
> > Commit fefe6733e added reference to the pcie->drvdata before it is
> > initialized which causes a kernel panic.  Fix the problem by
> > initializing the pcie->drvdata earlier before it is used.
> >
> > Reported-by: Stuart Yoder <stuart.yo...@nxp.com>
> > Signed-off-by: Li Yang <leoyang...@nxp.com>
> 
> I applied Marc Zyngier's identical patch to for-linus for v4.9.  I don't know 
> which
> was posted first, but I saw Marc's first.  Sorry I didn't at least credit you 
> when I
> applied it.

It's ok.  Seems Marc sent the patch earlier and I didn't notice his patch.  
There is no difference as long as the problem is addressed.  :)

Regards,
Leo

RE: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL pointer

2016-10-21 Thread Leo Li 


> -Original Message-
> From: Bjorn Helgaas [mailto:helg...@kernel.org]
> Sent: Friday, October 21, 2016 10:37 AM
> To: Leo Li 
> Cc: Bjorn Helgaas ; Minghuan Lian
> ; Mingkai Hu ;
> Roy Zang ; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Stuart Yoder
> 
> Subject: Re: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL 
> pointer
> 
> On Mon, Oct 17, 2016 at 04:44:06PM -0500, Li Yang wrote:
> > Commit fefe6733e added reference to the pcie->drvdata before it is
> > initialized which causes a kernel panic.  Fix the problem by
> > initializing the pcie->drvdata earlier before it is used.
> >
> > Reported-by: Stuart Yoder 
> > Signed-off-by: Li Yang 
> 
> I applied Marc Zyngier's identical patch to for-linus for v4.9.  I don't know 
> which
> was posted first, but I saw Marc's first.  Sorry I didn't at least credit you 
> when I
> applied it.

It's ok.  Seems Marc sent the patch earlier and I didn't notice his patch.  
There is no difference as long as the problem is addressed.  :)

Regards,
Leo

Re: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL pointer

2016-10-21 Thread Bjorn Helgaas 
On Mon, Oct 17, 2016 at 04:44:06PM -0500, Li Yang wrote:
> Commit fefe6733e added reference to the pcie->drvdata before it is
> initialized which causes a kernel panic.  Fix the problem by
> initializing the pcie->drvdata earlier before it is used.
> 
> Reported-by: Stuart Yoder 
> Signed-off-by: Li Yang 

I applied Marc Zyngier's identical patch to for-linus for v4.9.  I don't
know which was posted first, but I saw Marc's first.  Sorry I didn't at
least credit you when I applied it.

> ---
>  drivers/pci/host/pci-layerscape.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pci-layerscape.c 
> b/drivers/pci/host/pci-layerscape.c
> index 2cb7315..958187f 100644
> --- a/drivers/pci/host/pci-layerscape.c
> +++ b/drivers/pci/host/pci-layerscape.c
> @@ -245,6 +245,7 @@ static int __init ls_pcie_probe(struct platform_device 
> *pdev)
>   if (!pcie)
>   return -ENOMEM;
>  
> + pcie->drvdata = match->data;
>   pp = >pp;
>   pp->dev = dev;
>   pp->ops = pcie->drvdata->ops;
> @@ -256,7 +257,6 @@ static int __init ls_pcie_probe(struct platform_device 
> *pdev)
>   return PTR_ERR(pcie->pp.dbi_base);
>   }
>  
> - pcie->drvdata = match->data;
>   pcie->lut = pcie->pp.dbi_base + pcie->drvdata->lut_offset;
>  
>   if (!ls_pcie_is_bridge(pcie))
> -- 
> 1.9.0
> 
> 
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL pointer

2016-10-21 Thread Bjorn Helgaas 
On Mon, Oct 17, 2016 at 04:44:06PM -0500, Li Yang wrote:
> Commit fefe6733e added reference to the pcie->drvdata before it is
> initialized which causes a kernel panic.  Fix the problem by
> initializing the pcie->drvdata earlier before it is used.
> 
> Reported-by: Stuart Yoder 
> Signed-off-by: Li Yang 

I applied Marc Zyngier's identical patch to for-linus for v4.9.  I don't
know which was posted first, but I saw Marc's first.  Sorry I didn't at
least credit you when I applied it.

> ---
>  drivers/pci/host/pci-layerscape.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pci-layerscape.c 
> b/drivers/pci/host/pci-layerscape.c
> index 2cb7315..958187f 100644
> --- a/drivers/pci/host/pci-layerscape.c
> +++ b/drivers/pci/host/pci-layerscape.c
> @@ -245,6 +245,7 @@ static int __init ls_pcie_probe(struct platform_device 
> *pdev)
>   if (!pcie)
>   return -ENOMEM;
>  
> + pcie->drvdata = match->data;
>   pp = >pp;
>   pp->dev = dev;
>   pp->ops = pcie->drvdata->ops;
> @@ -256,7 +257,6 @@ static int __init ls_pcie_probe(struct platform_device 
> *pdev)
>   return PTR_ERR(pcie->pp.dbi_base);
>   }
>  
> - pcie->drvdata = match->data;
>   pcie->lut = pcie->pp.dbi_base + pcie->drvdata->lut_offset;
>  
>   if (!ls_pcie_is_bridge(pcie))
> -- 
> 1.9.0
> 
> 
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL pointer

2016-10-17 Thread Roy Zang 
On 10/17/2016 04:50 PM, Li Yang wrote:
> Commit fefe6733e added reference to the pcie->drvdata before it is
> initialized which causes a kernel panic.  Fix the problem by
> initializing the pcie->drvdata earlier before it is used.
>
> Reported-by: Stuart Yoder 
> Signed-off-by: Li Yang 
> ---

 Acked-by:  Roy Zang 

Roy

Re: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL pointer

2016-10-17 Thread Roy Zang 
On 10/17/2016 04:50 PM, Li Yang wrote:
> Commit fefe6733e added reference to the pcie->drvdata before it is
> initialized which causes a kernel panic.  Fix the problem by
> initializing the pcie->drvdata earlier before it is used.
>
> Reported-by: Stuart Yoder 
> Signed-off-by: Li Yang 
> ---

 Acked-by:  Roy Zang 

Roy