On 29-May-20 3:53 PM, Lorenzo Pieralisi wrote:
External email: Use caution opening links or attachments
On Wed, May 20, 2020 at 11:39:08PM +0530, Vidya Sagar wrote:
Thanks for pushing a patch to fix it. I've been under the wrong assumption
that a failing pm_runtime_get_sync() wouldn't
On Wed, May 20, 2020 at 11:39:08PM +0530, Vidya Sagar wrote:
> Thanks for pushing a patch to fix it. I've been under the wrong assumption
> that a failing pm_runtime_get_sync() wouldn't increment the usage counter.
> With Thierry's and Bjorn's comments addressed
>
> Acked-by: Vidya Sagar
Thank you for your advice. I will fix these problems in the next edition of
patch.
Thierry Reding thierry.red...@gmail.com写道:
> On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote:
> > pm_runtime_get_sync() increments the runtime PM usage counter even
> > it returns an error code. Thus a
Thank you for your advice. I think tegra194 is a good choice and
I will use it in the next edition of patch.
Bjorn Helgaas helg...@kernel.org写道:
> On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote:
> > On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote:
> > >
Thanks for pushing a patch to fix it. I've been under the wrong
assumption that a failing pm_runtime_get_sync() wouldn't increment the
usage counter.
With Thierry's and Bjorn's comments addressed
Acked-by: Vidya Sagar
On 20-May-20 10:07 PM, Bjorn Helgaas wrote:
External email: Use caution
On Wed, May 20, 2020 at 04:40:12PM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
>
> Also This driver forgets to call
On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote:
> On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote:
> > pm_runtime_get_sync() increments the runtime PM usage counter even
> > it returns an error code. Thus a pairing decrement is needed on
>
> s/even it/even when it/
>
On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> it returns an error code. Thus a pairing decrement is needed on
s/even it/even when it/
Might also be a good idea to use a different subject prefix because I
was
On Wed, May 20, 2020 at 04:40:12PM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> it returns an error code. Thus a pairing decrement is needed on
s/even it/even when it/
> the error handling path to keep the counter balanced.
>
> Also This
9 matches
Mail list logo