Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error

2020-05-29 Thread Vidya Sagar
On 29-May-20 3:53 PM, Lorenzo Pieralisi wrote: External email: Use caution opening links or attachments On Wed, May 20, 2020 at 11:39:08PM +0530, Vidya Sagar wrote: Thanks for pushing a patch to fix it. I've been under the wrong assumption that a failing pm_runtime_get_sync() wouldn't

Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error

2020-05-29 Thread Lorenzo Pieralisi
On Wed, May 20, 2020 at 11:39:08PM +0530, Vidya Sagar wrote: > Thanks for pushing a patch to fix it. I've been under the wrong assumption > that a failing pm_runtime_get_sync() wouldn't increment the usage counter. > With Thierry's and Bjorn's comments addressed > > Acked-by: Vidya Sagar

Re: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error

2020-05-20 Thread dinghao . liu
Thank you for your advice. I will fix these problems in the next edition of patch. Thierry Reding thierry.red...@gmail.com写道: > On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even > > it returns an error code. Thus a

Re: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error

2020-05-20 Thread dinghao . liu
Thank you for your advice. I think tegra194 is a good choice and I will use it in the next edition of patch. Bjorn Helgaas helg...@kernel.org写道: > On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote: > > On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote: > > >

Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error

2020-05-20 Thread Vidya Sagar
Thanks for pushing a patch to fix it. I've been under the wrong assumption that a failing pm_runtime_get_sync() wouldn't increment the usage counter. With Thierry's and Bjorn's comments addressed Acked-by: Vidya Sagar On 20-May-20 10:07 PM, Bjorn Helgaas wrote: External email: Use caution

Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error

2020-05-20 Thread Bjorn Helgaas
On Wed, May 20, 2020 at 04:40:12PM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. > > Also This driver forgets to call

Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error

2020-05-20 Thread Bjorn Helgaas
On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote: > On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even > > it returns an error code. Thus a pairing decrement is needed on > > s/even it/even when it/ >

Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error

2020-05-20 Thread Thierry Reding
On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > it returns an error code. Thus a pairing decrement is needed on s/even it/even when it/ Might also be a good idea to use a different subject prefix because I was

Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error

2020-05-20 Thread Thierry Reding
On Wed, May 20, 2020 at 04:40:12PM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > it returns an error code. Thus a pairing decrement is needed on s/even it/even when it/ > the error handling path to keep the counter balanced. > > Also This