Re: [PATCH] acpi/apei: Fix in-correct return value

2016-10-22 Thread Rafael J. Wysocki
On Saturday, October 22, 2016 06:37:35 PM Borislav Petkov wrote: > On Fri, Oct 21, 2016 at 11:28:29PM +0200, Rafael J. Wysocki wrote: > > Boris, all fine here? > > Short answer: Yeah, looks ok to me. > > Longer answer: I mean, this way ghes_proc() *actually* propagates the > return value of

Re: [PATCH] acpi/apei: Fix in-correct return value

2016-10-22 Thread Rafael J. Wysocki
On Saturday, October 22, 2016 06:37:35 PM Borislav Petkov wrote: > On Fri, Oct 21, 2016 at 11:28:29PM +0200, Rafael J. Wysocki wrote: > > Boris, all fine here? > > Short answer: Yeah, looks ok to me. > > Longer answer: I mean, this way ghes_proc() *actually* propagates the > return value of

Re: [PATCH] acpi/apei: Fix in-correct return value

2016-10-22 Thread Borislav Petkov
On Fri, Oct 21, 2016 at 11:28:29PM +0200, Rafael J. Wysocki wrote: > Boris, all fine here? Short answer: Yeah, looks ok to me. Longer answer: I mean, this way ghes_proc() *actually* propagates the return value of ghes_read_estatus() and we don't do any processing if it failed. Which doesn't

Re: [PATCH] acpi/apei: Fix in-correct return value

2016-10-22 Thread Borislav Petkov
On Fri, Oct 21, 2016 at 11:28:29PM +0200, Rafael J. Wysocki wrote: > Boris, all fine here? Short answer: Yeah, looks ok to me. Longer answer: I mean, this way ghes_proc() *actually* propagates the return value of ghes_read_estatus() and we don't do any processing if it failed. Which doesn't

Re: [PATCH] acpi/apei: Fix in-correct return value

2016-10-21 Thread Rafael J. Wysocki
On Tuesday, October 18, 2016 05:07:19 PM Punit Agrawal wrote: > Although ghes_proc tests for error while reading the error status, it > always return success (0). Fix this by propagating the return value. > > Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory > error

Re: [PATCH] acpi/apei: Fix in-correct return value

2016-10-21 Thread Rafael J. Wysocki
On Tuesday, October 18, 2016 05:07:19 PM Punit Agrawal wrote: > Although ghes_proc tests for error while reading the error status, it > always return success (0). Fix this by propagating the return value. > > Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory > error

Re: [PATCH] acpi/apei: Fix in-correct return value

2016-10-21 Thread Punit Agrawal
"Baicar, Tyler" writes: > On 10/18/2016 10:07 AM, Punit Agrawal wrote: >> Although ghes_proc tests for error while reading the error status, it >> always return success (0). Fix this by propagating the return value. >> >> Fixes: d334a49113a4a33 ("ACPI, APEI, Generic

Re: [PATCH] acpi/apei: Fix in-correct return value

2016-10-21 Thread Punit Agrawal
"Baicar, Tyler" writes: > On 10/18/2016 10:07 AM, Punit Agrawal wrote: >> Although ghes_proc tests for error while reading the error status, it >> always return success (0). Fix this by propagating the return value. >> >> Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory

Re: [PATCH] acpi/apei: Fix in-correct return value

2016-10-20 Thread Baicar, Tyler
On 10/18/2016 10:07 AM, Punit Agrawal wrote: Although ghes_proc tests for error while reading the error status, it always return success (0). Fix this by propagating the return value. Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory error support") Signed-of-by: Punit

Re: [PATCH] acpi/apei: Fix in-correct return value

2016-10-20 Thread Baicar, Tyler
On 10/18/2016 10:07 AM, Punit Agrawal wrote: Although ghes_proc tests for error while reading the error status, it always return success (0). Fix this by propagating the return value. Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory error support") Signed-of-by: Punit