Re: [PATCH] arm: kgdb: Don't try to stop the machine when setting breakpoints

2015-08-25 Thread Kees Cook
On Tue, Aug 25, 2015 at 3:02 PM, Douglas Anderson wrote: > In (23a4e40 arm: kgdb: Handle read-only text / modules) we moved to > using patch_text() to set breakpoints so that we could handle the case > when we had CONFIG_DEBUG_RODATA. That patch used patch_text(). > Unfortunately, patch_text()

Re: [PATCH] arm: kgdb: Don't try to stop the machine when setting breakpoints

2015-08-25 Thread Stephen Boyd
On 08/25, Douglas Anderson wrote: > In (23a4e40 arm: kgdb: Handle read-only text / modules) we moved to > using patch_text() to set breakpoints so that we could handle the case > when we had CONFIG_DEBUG_RODATA. That patch used patch_text(). > Unfortunately, patch_text() assumes that we're not in

Re: [PATCH] arm: kgdb: Don't try to stop the machine when setting breakpoints

2015-08-25 Thread Stephen Boyd
On 08/25, Douglas Anderson wrote: In (23a4e40 arm: kgdb: Handle read-only text / modules) we moved to using patch_text() to set breakpoints so that we could handle the case when we had CONFIG_DEBUG_RODATA. That patch used patch_text(). Unfortunately, patch_text() assumes that we're not in

Re: [PATCH] arm: kgdb: Don't try to stop the machine when setting breakpoints

2015-08-25 Thread Kees Cook
On Tue, Aug 25, 2015 at 3:02 PM, Douglas Anderson diand...@chromium.org wrote: In (23a4e40 arm: kgdb: Handle read-only text / modules) we moved to using patch_text() to set breakpoints so that we could handle the case when we had CONFIG_DEBUG_RODATA. That patch used patch_text().