Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

[Bjorn Andersson]

On Thu 11 Jan 18:33 PST 2018, Jeremy McNicoll wrote:

> On Thu, Dec 28, 2017 at 02:38:29AM -0500, zhuoweizh...@yahoo.com wrote:
> > From: Zhuowei Zhang 
> > 
> > Support pstore-ramoops for retrieving kernel oops and panics after reboot.
> > 
> > The address and configs are taken from the downstream kernel's device tree.
> > 
> > Signed-off-by: Zhuowei Zhang 

Hi Zhuowei,

This patch looks good, but I'm unable to find the original patch in my
inbox, at lkml.org or at patchwork.kernel.org. Can you please resend the
original patch to linux-arm-...@vger.kernel.org, with Kees' R-b and
Jeremy's A-b.

Regards,
Bjorn

Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

[Bjorn Andersson]

On Thu 11 Jan 18:33 PST 2018, Jeremy McNicoll wrote:

> On Thu, Dec 28, 2017 at 02:38:29AM -0500, zhuoweizh...@yahoo.com wrote:
> > From: Zhuowei Zhang 
> > 
> > Support pstore-ramoops for retrieving kernel oops and panics after reboot.
> > 
> > The address and configs are taken from the downstream kernel's device tree.
> > 
> > Signed-off-by: Zhuowei Zhang 

Hi Zhuowei,

This patch looks good, but I'm unable to find the original patch in my
inbox, at lkml.org or at patchwork.kernel.org. Can you please resend the
original patch to linux-arm-...@vger.kernel.org, with Kees' R-b and
Jeremy's A-b.

Regards,
Bjorn

Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

[Jeremy McNicoll]

On Thu, Dec 28, 2017 at 02:38:29AM -0500, zhuoweizh...@yahoo.com wrote:
> From: Zhuowei Zhang 
> 
> Support pstore-ramoops for retrieving kernel oops and panics after reboot.
> 
> The address and configs are taken from the downstream kernel's device tree.
> 
> Signed-off-by: Zhuowei Zhang 
> ---
>  arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 15 +++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts 
> b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> index dfa08f5..9ce3a6e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> @@ -37,4 +37,19 @@
>   pinctrl-1 = <_uart2_sleep>;
>   };
>   };
> +
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + ramoops@1fe0 {
> + compatible = "ramoops";
> + reg = <0 0x1fe0 0 0x0020>;

Downstream doesn't use 0x0 to denote 0.  I am fine with this, if 
someone has a concern or issue with it we can change it before merging.


> + console-size = <0x10>;
> + record-size = <0x1>;
> + ftrace-size = <0x1>;
> + pmsg-size = <0x8>;

We could pad this with leading 0's but I find this much easier
to read.

> + };
> + };
>  };

Thank you very much for taking the time to send this.  


Acked-by: Jeremy McNicoll 

Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

[Jeremy McNicoll]

On Thu, Dec 28, 2017 at 02:38:29AM -0500, zhuoweizh...@yahoo.com wrote:
> From: Zhuowei Zhang 
> 
> Support pstore-ramoops for retrieving kernel oops and panics after reboot.
> 
> The address and configs are taken from the downstream kernel's device tree.
> 
> Signed-off-by: Zhuowei Zhang 
> ---
>  arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 15 +++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts 
> b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> index dfa08f5..9ce3a6e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> @@ -37,4 +37,19 @@
>   pinctrl-1 = <_uart2_sleep>;
>   };
>   };
> +
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + ramoops@1fe0 {
> + compatible = "ramoops";
> + reg = <0 0x1fe0 0 0x0020>;

Downstream doesn't use 0x0 to denote 0.  I am fine with this, if 
someone has a concern or issue with it we can change it before merging.


> + console-size = <0x10>;
> + record-size = <0x1>;
> + ftrace-size = <0x1>;
> + pmsg-size = <0x8>;

We could pad this with leading 0's but I find this much easier
to read.

> + };
> + };
>  };

Thank you very much for taking the time to send this.  


Acked-by: Jeremy McNicoll 

Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

[Kees Cook]

On Wed, Dec 27, 2017 at 11:38 PM,   wrote:
> From: Zhuowei Zhang 
>
> Support pstore-ramoops for retrieving kernel oops and panics after reboot.
>
> The address and configs are taken from the downstream kernel's device tree.
>
> Signed-off-by: Zhuowei Zhang 

Reviewed-by: Kees Cook 

-Kees

> ---
>  arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 15 +++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts 
> b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> index dfa08f5..9ce3a6e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> @@ -37,4 +37,19 @@
> pinctrl-1 = <_uart2_sleep>;
> };
> };
> +
> +   reserved-memory {
> +   #address-cells = <2>;
> +   #size-cells = <2>;
> +   ranges;
> +
> +   ramoops@1fe0 {
> +   compatible = "ramoops";
> +   reg = <0 0x1fe0 0 0x0020>;
> +   console-size = <0x10>;
> +   record-size = <0x1>;
> +   ftrace-size = <0x1>;
> +   pmsg-size = <0x8>;
> +   };
> +   };
>  };
> --
> 1.9.1
>



-- 
Kees Cook
Pixel Security

Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

[Kees Cook]

On Wed, Dec 27, 2017 at 11:38 PM,   wrote:
> From: Zhuowei Zhang 
>
> Support pstore-ramoops for retrieving kernel oops and panics after reboot.
>
> The address and configs are taken from the downstream kernel's device tree.
>
> Signed-off-by: Zhuowei Zhang 

Reviewed-by: Kees Cook 

-Kees

> ---
>  arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 15 +++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts 
> b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> index dfa08f5..9ce3a6e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> @@ -37,4 +37,19 @@
> pinctrl-1 = <_uart2_sleep>;
> };
> };
> +
> +   reserved-memory {
> +   #address-cells = <2>;
> +   #size-cells = <2>;
> +   ranges;
> +
> +   ramoops@1fe0 {
> +   compatible = "ramoops";
> +   reg = <0 0x1fe0 0 0x0020>;
> +   console-size = <0x10>;
> +   record-size = <0x1>;
> +   ftrace-size = <0x1>;
> +   pmsg-size = <0x8>;
> +   };
> +   };
>  };
> --
> 1.9.1
>



-- 
Kees Cook
Pixel Security