Re: [PATCH] ata: make ata_port_operations const

2017-08-08 Thread Bhumika Goyal
On Mon, Aug 7, 2017 at 10:04 PM, Joe Perches wrote: > On Mon, 2017-08-07 at 09:29 -0700, Tejun Heo wrote: >> Hello, >> >> On Mon, Aug 07, 2017 at 08:54:21PM +0530, Bhumika Goyal wrote: >> > I compiled the .o files and checked the size before and after >> > compilation. After making the structure c

Re: [PATCH] ata: make ata_port_operations const

2017-08-07 Thread Joe Perches
On Mon, 2017-08-07 at 09:29 -0700, Tejun Heo wrote: > Hello, > > On Mon, Aug 07, 2017 at 08:54:21PM +0530, Bhumika Goyal wrote: > > I compiled the .o files and checked the size before and after > > compilation. After making the structure const, bytes should move from > > data to text segment of th

Re: [PATCH] ata: make ata_port_operations const

2017-08-07 Thread Tejun Heo
Hello, On Mon, Aug 07, 2017 at 08:54:21PM +0530, Bhumika Goyal wrote: > I compiled the .o files and checked the size before and after > compilation. After making the structure const, bytes should move from > data to text segment of the memory and this is what happened. So, this > is how I tested i

Re: [PATCH] ata: make ata_port_operations const

2017-08-07 Thread Bhumika Goyal
On Mon, Aug 7, 2017 at 8:37 PM, Tejun Heo wrote: > Hello, > > On Mon, Aug 07, 2017 at 04:02:02PM +0530, Bhumika Goyal wrote: >> Make ata_port_operations structures const as it is only stored in the >> inherits field of an ata_port_operations structure. Therefore make it >> const. >> >> Signed-off-

Re: [PATCH] ata: make ata_port_operations const

2017-08-07 Thread Tejun Heo
Hello, On Mon, Aug 07, 2017 at 04:02:02PM +0530, Bhumika Goyal wrote: > Make ata_port_operations structures const as it is only stored in the > inherits field of an ata_port_operations structure. Therefore make it > const. > > Signed-off-by: Bhumika Goyal How did you test the patch? Thanks. -