Hi Gustavo,
On Thu, Oct 12, 2017 at 11:35 PM, Gustavo A. R. Silva
<garsi...@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> In this particular case, notice that I replaced the "no break here,
> fall through" comments with "fall through" comments, which is what
> GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
> ---
> drivers/auxdisplay/panel.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
> index 6911acd..8b80a97 100644
> --- a/drivers/auxdisplay/panel.c
> +++ b/drivers/auxdisplay/panel.c
> @@ -1372,7 +1372,7 @@ static void panel_process_inputs(void)
> break;
> input->rise_timer = 0;
> input->state = INPUT_ST_RISING;
> - /* no break here, fall through */
> + /* fall through */
> case INPUT_ST_RISING:
> if ((phys_curr & input->mask) != input->value) {
> input->state = INPUT_ST_LOW;
> @@ -1385,11 +1385,11 @@ static void panel_process_inputs(void)
> }
> input->high_timer = 0;
> input->state = INPUT_ST_HIGH;
> - /* no break here, fall through */
> + /* fall through */
> case INPUT_ST_HIGH:
> if (input_state_high(input))
> break;
> - /* no break here, fall through */
> + /* fall through */
Thanks! I will put it in my queue (I sent a similar one a few days
ago, so I will pick yours).
Cheers,
Miguel
> case INPUT_ST_FALLING:
> input_state_falling(input);
> }
> --
> 2.7.4
>
