Re: [PATCH] backlight: add PWM dependencies

2014-02-26 Thread Thierry Reding
On Mon, Feb 10, 2014 at 12:09:29PM +0100, Linus Walleij wrote: > On Mon, Feb 10, 2014 at 11:40 AM, Thierry Reding > wrote: > > > it seems like at least BACKLIGHT_LP8788 is missing a corresponding > > dependency as well. > > > > I have applied Sascha's patch to remove the obsolete HAVE_PWM

Re: [PATCH] backlight: add PWM dependencies

2014-02-26 Thread Thierry Reding
On Mon, Feb 10, 2014 at 12:09:29PM +0100, Linus Walleij wrote: On Mon, Feb 10, 2014 at 11:40 AM, Thierry Reding thierry.red...@gmail.com wrote: it seems like at least BACKLIGHT_LP8788 is missing a corresponding dependency as well. I have applied Sascha's patch to remove the obsolete

Re: [PATCH] backlight: add PWM dependencies

2014-02-10 Thread Linus Walleij
On Mon, Feb 10, 2014 at 11:40 AM, Thierry Reding wrote: > it seems like at least BACKLIGHT_LP8788 is missing a corresponding > dependency as well. > > I have applied Sascha's patch to remove the obsolete HAVE_PWM symbol, > and this will fix at least the build issues. However it will also cause >

Re: [PATCH] backlight: add PWM dependencies

2014-02-10 Thread Thierry Reding
On Tue, Feb 04, 2014 at 01:57:14PM +0100, Linus Walleij wrote: > In some compilations the LM3630A and LP855X backlight drivers > fail like this: > > drivers/built-in.o: In function `lm3630a_pwm_ctrl': > drivers/video/backlight/lm3630a_bl.c:168: undefined reference to `pwm_config' >

Re: [PATCH] backlight: add PWM dependencies

2014-02-10 Thread Thierry Reding
On Tue, Feb 04, 2014 at 01:57:14PM +0100, Linus Walleij wrote: In some compilations the LM3630A and LP855X backlight drivers fail like this: drivers/built-in.o: In function `lm3630a_pwm_ctrl': drivers/video/backlight/lm3630a_bl.c:168: undefined reference to `pwm_config'

Re: [PATCH] backlight: add PWM dependencies

2014-02-10 Thread Linus Walleij
On Mon, Feb 10, 2014 at 11:40 AM, Thierry Reding thierry.red...@gmail.com wrote: it seems like at least BACKLIGHT_LP8788 is missing a corresponding dependency as well. I have applied Sascha's patch to remove the obsolete HAVE_PWM symbol, and this will fix at least the build issues. However

Re: [PATCH] backlight: add PWM dependencies

2014-02-07 Thread Arnd Bergmann
On Friday 07 February 2014, Jingoo Han wrote: > How about the following? > > [PATCH 1/7] ARM: pxa: don't select HAVE_PWM > [PATCH 2/7] ARM: lpc32xx: don't select HAVE_PWM > [PATCH 3/7] ARM: remove HAVE_PWM config option > [PATCH 4/7] MIPS: jz4740: don't select HAVE_PWM > [PATCH 5/7]

Re: [PATCH] backlight: add PWM dependencies

2014-02-07 Thread Arnd Bergmann
On Friday 07 February 2014, Jingoo Han wrote: How about the following? [PATCH 1/7] ARM: pxa: don't select HAVE_PWM [PATCH 2/7] ARM: lpc32xx: don't select HAVE_PWM [PATCH 3/7] ARM: remove HAVE_PWM config option [PATCH 4/7] MIPS: jz4740: don't select HAVE_PWM [PATCH 5/7] Input:

Re: [PATCH] backlight: add PWM dependencies

2014-02-06 Thread Jingoo Han
On Friday, February 07, 2014 1:08 AM, Arnd Bergmann wrote: > On Thursday 06 February 2014, Jingoo Han wrote: > > In the case of "CONFIG_HAVE_PWM=y && CONFIG_PWM=n", it makes > > the problem. > > > > The HAVE_PWM symbol is only for legacy platforms that provide > > the PWM API without using the

Re: [PATCH] backlight: add PWM dependencies

2014-02-06 Thread Arnd Bergmann
On Thursday 06 February 2014 17:08:05 Arnd Bergmann wrote: > > Finally, I have recently encountered a couple of drivers > (BACKLIGHT_LM3630A, BACKLIGHT_LP855X, BACKLIGHT_LP8788) that use > the PWM interfaces but are missing a 'depends on PWM'. This is > strictly speaking a different problem, but

Re: [PATCH] backlight: add PWM dependencies

2014-02-06 Thread Arnd Bergmann
On Thursday 06 February 2014, Jingoo Han wrote: > In the case of "CONFIG_HAVE_PWM=y && CONFIG_PWM=n", it makes > the problem. > > The HAVE_PWM symbol is only for legacy platforms that provide > the PWM API without using the generic framework. PXA looks to > use the generic PWM framework. Then,

Re: [PATCH] backlight: add PWM dependencies

2014-02-06 Thread Linus Walleij
On Thu, Feb 6, 2014 at 8:23 AM, Jingoo Han wrote: > In the case of "CONFIG_HAVE_PWM=y && CONFIG_PWM=n", it makes > the problem. > > The HAVE_PWM symbol is only for legacy platforms that provide > the PWM API without using the generic framework. PXA looks to > use the generic PWM framework. Then,

Re: [PATCH] backlight: add PWM dependencies

2014-02-06 Thread Linus Walleij
On Thu, Feb 6, 2014 at 8:23 AM, Jingoo Han jg1@samsung.com wrote: In the case of CONFIG_HAVE_PWM=y CONFIG_PWM=n, it makes the problem. The HAVE_PWM symbol is only for legacy platforms that provide the PWM API without using the generic framework. PXA looks to use the generic PWM

Re: [PATCH] backlight: add PWM dependencies

2014-02-06 Thread Arnd Bergmann
On Thursday 06 February 2014, Jingoo Han wrote: In the case of CONFIG_HAVE_PWM=y CONFIG_PWM=n, it makes the problem. The HAVE_PWM symbol is only for legacy platforms that provide the PWM API without using the generic framework. PXA looks to use the generic PWM framework. Then, how about

Re: [PATCH] backlight: add PWM dependencies

2014-02-06 Thread Arnd Bergmann
On Thursday 06 February 2014 17:08:05 Arnd Bergmann wrote: Finally, I have recently encountered a couple of drivers (BACKLIGHT_LM3630A, BACKLIGHT_LP855X, BACKLIGHT_LP8788) that use the PWM interfaces but are missing a 'depends on PWM'. This is strictly speaking a different problem, but we

Re: [PATCH] backlight: add PWM dependencies

2014-02-06 Thread Jingoo Han
On Friday, February 07, 2014 1:08 AM, Arnd Bergmann wrote: On Thursday 06 February 2014, Jingoo Han wrote: In the case of CONFIG_HAVE_PWM=y CONFIG_PWM=n, it makes the problem. The HAVE_PWM symbol is only for legacy platforms that provide the PWM API without using the generic framework.

Re: [PATCH] backlight: add PWM dependencies

2014-02-05 Thread Jingoo Han
On Thursday, February 06, 2014 3:50 PM, Jingoo Han wrote: > On Wednesday, February 05, 2014 5:58 PM, Linus Walleij wrote: > > On Wed, Feb 5, 2014 at 6:01 AM, Jingoo Han wrote: > > > On Tuesday, February 04, 2014 9:57 PM, Linus Walleij wrote: > > >> > > >> In some compilations the LM3630A and

Re: [PATCH] backlight: add PWM dependencies

2014-02-05 Thread Jingoo Han
On Wednesday, February 05, 2014 5:58 PM, Linus Walleij wrote: > On Wed, Feb 5, 2014 at 6:01 AM, Jingoo Han wrote: > > On Tuesday, February 04, 2014 9:57 PM, Linus Walleij wrote: > >> > >> In some compilations the LM3630A and LP855X backlight drivers > >> fail like this: > >> > >>

Re: [PATCH] backlight: add PWM dependencies

2014-02-05 Thread Linus Walleij
On Wed, Feb 5, 2014 at 6:01 AM, Jingoo Han wrote: > On Tuesday, February 04, 2014 9:57 PM, Linus Walleij wrote: >> >> In some compilations the LM3630A and LP855X backlight drivers >> fail like this: >> >> drivers/built-in.o: In function `lm3630a_pwm_ctrl': >>

Re: [PATCH] backlight: add PWM dependencies

2014-02-05 Thread Linus Walleij
On Wed, Feb 5, 2014 at 6:01 AM, Jingoo Han jg1@samsung.com wrote: On Tuesday, February 04, 2014 9:57 PM, Linus Walleij wrote: In some compilations the LM3630A and LP855X backlight drivers fail like this: drivers/built-in.o: In function `lm3630a_pwm_ctrl':

Re: [PATCH] backlight: add PWM dependencies

2014-02-05 Thread Jingoo Han
On Wednesday, February 05, 2014 5:58 PM, Linus Walleij wrote: On Wed, Feb 5, 2014 at 6:01 AM, Jingoo Han jg1@samsung.com wrote: On Tuesday, February 04, 2014 9:57 PM, Linus Walleij wrote: In some compilations the LM3630A and LP855X backlight drivers fail like this:

Re: [PATCH] backlight: add PWM dependencies

2014-02-05 Thread Jingoo Han
On Thursday, February 06, 2014 3:50 PM, Jingoo Han wrote: On Wednesday, February 05, 2014 5:58 PM, Linus Walleij wrote: On Wed, Feb 5, 2014 at 6:01 AM, Jingoo Han jg1@samsung.com wrote: On Tuesday, February 04, 2014 9:57 PM, Linus Walleij wrote: In some compilations the LM3630A and

Re: [PATCH] backlight: add PWM dependencies

2014-02-04 Thread Jingoo Han
On Tuesday, February 04, 2014 9:57 PM, Linus Walleij wrote: > > In some compilations the LM3630A and LP855X backlight drivers > fail like this: > > drivers/built-in.o: In function `lm3630a_pwm_ctrl': > drivers/video/backlight/lm3630a_bl.c:168: undefined reference to `pwm_config' >

Re: [PATCH] backlight: add PWM dependencies

2014-02-04 Thread Jingoo Han
On Tuesday, February 04, 2014 9:57 PM, Linus Walleij wrote: In some compilations the LM3630A and LP855X backlight drivers fail like this: drivers/built-in.o: In function `lm3630a_pwm_ctrl': drivers/video/backlight/lm3630a_bl.c:168: undefined reference to `pwm_config'