Re: [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request()

[Jens Axboe]

On 7/4/20 1:28 AM, Baolin Wang wrote:
> We've already validated the 'q->elevator' before calling 
> ->ops.completed_request()
> in blk_mq_sched_completed_request(), thus no need to validate 
> rq->internal_tag again,
> and remove it.

Applied, but I reformatted and edited your commit message.

-- 
Jens Axboe

Re: [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request()

[Ming Lei]

On Fri, Jul 10, 2020 at 04:23:04PM +0800, Baolin Wang wrote:
> Hi,
> 
> On Sat, Jul 04, 2020 at 03:28:21PM +0800, Baolin Wang wrote:
> > We've already validated the 'q->elevator' before calling 
> > ->ops.completed_request()
> > in blk_mq_sched_completed_request(), thus no need to validate 
> > rq->internal_tag again,
> > and remove it.
> 
> A gentle ping?

Reviewed-by: Ming Lei 

-- 
Ming

Re: [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request()

[Baolin Wang]

Hi,

On Sat, Jul 04, 2020 at 03:28:21PM +0800, Baolin Wang wrote:
> We've already validated the 'q->elevator' before calling 
> ->ops.completed_request()
> in blk_mq_sched_completed_request(), thus no need to validate 
> rq->internal_tag again,
> and remove it.

A gentle ping?

> 
> Signed-off-by: Baolin Wang 
> ---
>  block/blk-mq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index abcf590f6238..78572b2e1675 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -550,8 +550,7 @@ inline void __blk_mq_end_request(struct request *rq, 
> blk_status_t error)
>   blk_stat_add(rq, now);
>   }
>  
> - if (rq->internal_tag != BLK_MQ_NO_TAG)
> - blk_mq_sched_completed_request(rq, now);
> + blk_mq_sched_completed_request(rq, now);
>  
>   blk_account_io_done(rq, now);
>  
> -- 
> 2.17.1