Re: [PATCH] block: Fix warning when I/O elevator is changed as request_queue is being removed

2017-08-28 Thread Jens Axboe
On 08/27/2017 07:36 PM, Ming Lei wrote: > On Wed, Aug 23, 2017 at 11:34 AM, Ming Lei wrote: >> On Wed, Aug 9, 2017 at 9:44 AM, Ming Lei wrote: >>> Hi David, >>> >>> On Wed, Aug 9, 2017 at 2:13 AM, David Jeffery wrote: On 08/07/2017 07:53 PM, Ming Lei wrote: > On Tue, Aug 8, 2017 at 3:38

Re: [PATCH] block: Fix warning when I/O elevator is changed as request_queue is being removed

2017-08-27 Thread Ming Lei
On Wed, Aug 23, 2017 at 11:34 AM, Ming Lei wrote: > On Wed, Aug 9, 2017 at 9:44 AM, Ming Lei wrote: >> Hi David, >> >> On Wed, Aug 9, 2017 at 2:13 AM, David Jeffery wrote: >>> On 08/07/2017 07:53 PM, Ming Lei wrote: On Tue, Aug 8, 2017 at 3:38 AM, David Jeffery wrote: >>> > > Signe

Re: [PATCH] block: Fix warning when I/O elevator is changed as request_queue is being removed

2017-08-22 Thread Ming Lei
On Wed, Aug 9, 2017 at 9:44 AM, Ming Lei wrote: > Hi David, > > On Wed, Aug 9, 2017 at 2:13 AM, David Jeffery wrote: >> On 08/07/2017 07:53 PM, Ming Lei wrote: >>> On Tue, Aug 8, 2017 at 3:38 AM, David Jeffery wrote: >> Signed-off-by: David Jeffery --- block/blk-sysfs.c |

Re: [PATCH] block: Fix warning when I/O elevator is changed as request_queue is being removed

2017-08-08 Thread Ming Lei
Hi David, On Wed, Aug 9, 2017 at 2:13 AM, David Jeffery wrote: > On 08/07/2017 07:53 PM, Ming Lei wrote: >> On Tue, Aug 8, 2017 at 3:38 AM, David Jeffery wrote: > >>> >>> Signed-off-by: David Jeffery >>> --- >>> block/blk-sysfs.c |2 ++ >>> block/elevator.c |4 >>> 2 files change

Re: [PATCH] block: Fix warning when I/O elevator is changed as request_queue is being removed

2017-08-08 Thread David Jeffery
On 08/07/2017 07:53 PM, Ming Lei wrote: > On Tue, Aug 8, 2017 at 3:38 AM, David Jeffery wrote: >> >> Signed-off-by: David Jeffery >> --- >> block/blk-sysfs.c |2 ++ >> block/elevator.c |4 >> 2 files changed, 6 insertions(+) >> >> >> diff --git a/block/blk-sysfs.c b/block/blk-sysf

Re: [PATCH] block: Fix warning when I/O elevator is changed as request_queue is being removed

2017-08-07 Thread Ming Lei
On Tue, Aug 8, 2017 at 3:38 AM, David Jeffery wrote: > There is a race between changing I/O elevator and request_queue removal > which can trigger the warning in kobject_add_internal. A program can > use sysfs to request a change of elevator at the same time another task > is unregistering the re