Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Mark Brown
On Mon, May 25, 2020 at 03:12:05PM +0200, Marc Kleine-Budde wrote: > On 5/25/20 2:57 PM, Mark Brown wrote: > > On Mon, May 25, 2020 at 02:41:31PM +0200, Marc Kleine-Budde wrote: > >> On 5/25/20 1:31 PM, Mark Brown wrote: > >> The core could merge several half duplex transfers (until there's as >

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Marc Kleine-Budde
On 5/25/20 2:57 PM, Mark Brown wrote: > On Mon, May 25, 2020 at 02:41:31PM +0200, Marc Kleine-Budde wrote: >> On 5/25/20 1:31 PM, Mark Brown wrote: > >>> This isn't something that every individual driver should be doing, such >>> rewriting should happen in the core so that everything sees the bene

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Mark Brown
On Mon, May 25, 2020 at 02:41:31PM +0200, Marc Kleine-Budde wrote: > On 5/25/20 1:31 PM, Mark Brown wrote: > > This isn't something that every individual driver should be doing, such > > rewriting should happen in the core so that everything sees the benefit. > The core could merge several half d

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Marc Kleine-Budde
On 5/25/20 1:31 PM, Mark Brown wrote: >>> Should I be submitting this patch with logic that only does >>> half-duplex if the spi controller doesn't support it (if >>> (spi->controller->flags & SPI_CONTROLLER_HALF_DUPLEX)) or is it >>> acceptable to simply make the driver half-duplex like this for a

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Mark Brown
On Mon, May 25, 2020 at 01:17:01PM +0200, Marc Kleine-Budde wrote: > On 5/21/20 10:19 PM, Tim Harvey wrote: > > > Should I be submitting this patch with logic that only does > > half-duplex if the spi controller doesn't support it (if > > (spi->controller->flags & SPI_CONTROLLER_HALF_DUPLEX)) or

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Marc Kleine-Budde
On 5/21/20 10:19 PM, Tim Harvey wrote: > On Wed, Feb 26, 2020 at 2:19 AM Marc Kleine-Budde wrote: > Sorry for the long delay... I'm finally getting back to this issue. > > I'm told by Marvell/Cavium that the OcteonTX SPI hardware does not > support full duplex although I don't see this in any of

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-21 Thread Mark Brown
On Thu, May 21, 2020 at 01:19:16PM -0700, Tim Harvey wrote: > Should I be submitting this patch with logic that only does > half-duplex if the spi controller doesn't support it (if > (spi->controller->flags & SPI_CONTROLLER_HALF_DUPLEX)) or is it > acceptable to simply make the driver half-duplex

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-21 Thread Tim Harvey
On Wed, Feb 26, 2020 at 2:19 AM Marc Kleine-Budde wrote: > > On 2/26/20 8:37 AM, Marc Kleine-Budde wrote: > >> Your right... there is the mcp251x_hw_rx_frame() call that also uses > >> spi_rx_buf after a synchronous transfer (I didn't see any others). > >> I'll look at this again. > > > > Have you