Re: [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration

[Stephen Boyd]

On 10/06, Javier Martinez Canillas wrote:
> The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and
> registration APIs") converted the driver to use the new provider API to
> register clocks using clk_hw.
> 
> But unfortunately, in the conversion it missed to set the num_clks value
> which lead to the following error when trying to register a clk provider:
> 
> [1.963782] of_clk_max77686_get: invalid index 0
> [1.967460] ERROR: could not get clock /rtc@1007:rtc_src(1)
> [1.973638] s3c-rtc 1007.rtc: failed to find rtc source clock
> 
> Fix it by correctly set the max77686_clk_driver_data num_clks member.
> 
> Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and 
> registration APIs")
> Reported-by: Markus Reichl 
> Suggested-by: Tobias Jakobi 
> Signed-off-by: Javier Martinez Canillas 
> Tested-by: Markus Reichl 
> 
> ---

Applied to clk-fixes

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration

[Chanwoo Choi]

Hi Javier,

On 2016년 10월 06일 23:59, Javier Martinez Canillas wrote:
> The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and
> registration APIs") converted the driver to use the new provider API to
> register clocks using clk_hw.
> 
> But unfortunately, in the conversion it missed to set the num_clks value
> which lead to the following error when trying to register a clk provider:
> 
> [1.963782] of_clk_max77686_get: invalid index 0
> [1.967460] ERROR: could not get clock /rtc@1007:rtc_src(1)
> [1.973638] s3c-rtc 1007.rtc: failed to find rtc source clock
> 
> Fix it by correctly set the max77686_clk_driver_data num_clks member.
> 
> Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and 
> registration APIs")
> Reported-by: Markus Reichl 
> Suggested-by: Tobias Jakobi 
> Signed-off-by: Javier Martinez Canillas 
> Tested-by: Markus Reichl 
> 
> ---
> 
>  drivers/clk/clk-max77686.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c
> index b637f5979023..eb953d3b0b69 100644
> --- a/drivers/clk/clk-max77686.c
> +++ b/drivers/clk/clk-max77686.c
> @@ -216,6 +216,7 @@ static int max77686_clk_probe(struct platform_device 
> *pdev)
>   return -EINVAL;
>   }
>  
> + drv_data->num_clks = num_clks;
>   drv_data->max_clk_data = devm_kcalloc(dev, num_clks,
> sizeof(*drv_data->max_clk_data),
> GFP_KERNEL);
> 

Looks good to me.

Reviewed-by: Chanwoo Choi 

-- 
Best Regards,
Chanwoo Choi

Re: [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration

[Krzysztof Kozlowski]

On Thu, Oct 06, 2016 at 11:59:59AM -0300, Javier Martinez Canillas wrote:
> The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and
> registration APIs") converted the driver to use the new provider API to
> register clocks using clk_hw.
> 
> But unfortunately, in the conversion it missed to set the num_clks value
> which lead to the following error when trying to register a clk provider:
> 
> [1.963782] of_clk_max77686_get: invalid index 0
> [1.967460] ERROR: could not get clock /rtc@1007:rtc_src(1)
> [1.973638] s3c-rtc 1007.rtc: failed to find rtc source clock
> 
> Fix it by correctly set the max77686_clk_driver_data num_clks member.
> 
> Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and 
> registration APIs")
> Reported-by: Markus Reichl 
> Suggested-by: Tobias Jakobi 
> Signed-off-by: Javier Martinez Canillas 
> Tested-by: Markus Reichl 
> 
> ---
> 
>  drivers/clk/clk-max77686.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof