Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap

2016-09-19 Thread arvind Yadav 



On Wednesday 14 September 2016 11:54 PM, Stephen Boyd wrote:

On 09/14, arvind.yadav...@gmail.com wrote:

@@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node 
*np)
return;
  
  err:

+   if (reg)

This is always true? Why check?
I have removed this check. Please review updated patch.

+   iounmap(reg);
if (clk_data)
kfree(clk_data->clks);
kfree(clk_data);
--
1.7.9.5

Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap

2016-09-14 Thread Stephen Boyd 
On 09/14, arvind.yadav...@gmail.com wrote:
> @@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node 
> *np)
>   return;
>  
>  err:
> + if (reg)

This is always true? Why check?

> + iounmap(reg);
>   if (clk_data)
>   kfree(clk_data->clks);
>   kfree(clk_data);
> -- 
> 1.7.9.5
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project