Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-11 Thread Doug Anderson
Will, On Thu, Sep 11, 2014 at 2:57 AM, Will Deacon wrote: > On Wed, Sep 10, 2014 at 08:50:16PM +0100, Doug Anderson wrote: >> On Wed, Sep 10, 2014 at 11:46 AM, Will Deacon wrote: >> > If `where we're at' is trying to boot an ARMv7 product, then you can boot >> > in >> > secure svc and lose

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-11 Thread Will Deacon
On Wed, Sep 10, 2014 at 08:50:16PM +0100, Doug Anderson wrote: > On Wed, Sep 10, 2014 at 11:46 AM, Will Deacon wrote: > > If `where we're at' is trying to boot an ARMv7 product, then you can boot in > > secure svc and lose virtualisation support. Looking forward to ARMv8, this > > isn't going to

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-11 Thread Will Deacon
On Wed, Sep 10, 2014 at 08:50:16PM +0100, Doug Anderson wrote: On Wed, Sep 10, 2014 at 11:46 AM, Will Deacon will.dea...@arm.com wrote: If `where we're at' is trying to boot an ARMv7 product, then you can boot in secure svc and lose virtualisation support. Looking forward to ARMv8, this

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-11 Thread Doug Anderson
Will, On Thu, Sep 11, 2014 at 2:57 AM, Will Deacon will.dea...@arm.com wrote: On Wed, Sep 10, 2014 at 08:50:16PM +0100, Doug Anderson wrote: On Wed, Sep 10, 2014 at 11:46 AM, Will Deacon will.dea...@arm.com wrote: If `where we're at' is trying to boot an ARMv7 product, then you can boot in

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Will, On Wed, Sep 10, 2014 at 11:46 AM, Will Deacon wrote: > On Wed, Sep 10, 2014 at 07:09:59PM +0100, Doug Anderson wrote: >> On Wed, Sep 10, 2014 at 10:34 AM, Will Deacon wrote: >> > Setting aside the security model, booting in secure mode can also have a >> > significant impact on the

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Will Deacon
On Wed, Sep 10, 2014 at 07:09:59PM +0100, Doug Anderson wrote: > On Wed, Sep 10, 2014 at 10:34 AM, Will Deacon wrote: > > Setting aside the security model, booting in secure mode can also have a > > significant impact on the programming model of system IP, not just the CPU. > > For example, the

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Hi, On Wed, Sep 10, 2014 at 10:52 AM, Doug Anderson wrote: > Mark, > > On Wed, Sep 10, 2014 at 10:27 AM, Mark Rutland wrote: >> Hi Sonny, >> >> On Wed, Aug 27, 2014 at 10:03:39PM +0100, Sonny Rao wrote: >>> This is a bug fix for using physical arch timers when >>> the arch_timer_use_virtual

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Will, On Wed, Sep 10, 2014 at 10:34 AM, Will Deacon wrote: > Setting aside the security model, booting in secure mode can also have a > significant impact on the programming model of system IP, not just the CPU. > For example, the SMMU register file suddenly looks different and the way in >

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Sonny Rao
On Wed, Sep 10, 2014 at 10:52 AM, Doug Anderson wrote: > Mark, > > On Wed, Sep 10, 2014 at 10:27 AM, Mark Rutland wrote: >> Hi Sonny, >> >> On Wed, Aug 27, 2014 at 10:03:39PM +0100, Sonny Rao wrote: >>> This is a bug fix for using physical arch timers when >>> the arch_timer_use_virtual boolean

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Mark, On Wed, Sep 10, 2014 at 10:27 AM, Mark Rutland wrote: > Hi Sonny, > > On Wed, Aug 27, 2014 at 10:03:39PM +0100, Sonny Rao wrote: >> This is a bug fix for using physical arch timers when >> the arch_timer_use_virtual boolean is false. It restores the >> arch_counter_get_cntpct() function

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Will Deacon
On Wed, Sep 10, 2014 at 06:17:23PM +0100, Doug Anderson wrote: > On Mon, Sep 8, 2014 at 6:54 AM, Catalin Marinas > wrote: > > On Fri, Sep 05, 2014 at 11:11:47PM +0100, Doug Anderson wrote: > >> On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: > >> > Not if you boot Linux at hyp, as we've

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Mark Rutland
Hi Sonny, On Wed, Aug 27, 2014 at 10:03:39PM +0100, Sonny Rao wrote: > This is a bug fix for using physical arch timers when > the arch_timer_use_virtual boolean is false. It restores the > arch_counter_get_cntpct() function after removal in > > 0d651e4e "clocksource: arch_timer: use virtual

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Mark, On Wed, Sep 10, 2014 at 8:55 AM, Mark Rutland wrote: > That's not true in general as other secure initialization will still be > necessary, and the extent and character of that initialization is going > to be implementation specific. Can you give more examples of what you mean by

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Catalin, On Mon, Sep 8, 2014 at 6:54 AM, Catalin Marinas wrote: > On Fri, Sep 05, 2014 at 11:11:47PM +0100, Doug Anderson wrote: >> On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: >> > Not if you boot Linux at hyp, as we've recommended for this precise >> > reason. That doesn't fix other

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Olof Johansson
On Wed, Sep 10, 2014 at 8:55 AM, Mark Rutland wrote: > On Wed, Sep 10, 2014 at 03:58:15PM +0100, Christopher Covington wrote: >> On 09/05/2014 06:11 PM, Doug Anderson wrote: >> > Mark, >> > >> > On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: >> >> Not if you boot Linux at hyp, as we've

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Catalin Marinas
On Fri, Sep 05, 2014 at 11:11:47PM +0100, Doug Anderson wrote: > On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: > > Not if you boot Linux at hyp, as we've recommended for this precise > > reason. That doesn't fix other things like CNTFRQ if the secure > > initialisation doesn't poke that,

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Mark Rutland
On Wed, Sep 10, 2014 at 03:58:15PM +0100, Christopher Covington wrote: > On 09/05/2014 06:11 PM, Doug Anderson wrote: > > Mark, > > > > On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: > >> Not if you boot Linux at hyp, as we've recommended for this precise > >> reason. That doesn't fix

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Catalin Marinas
On Wed, Sep 10, 2014 at 03:58:15PM +0100, Christopher Covington wrote: > On 09/05/2014 06:11 PM, Doug Anderson wrote: > > On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: > >> Not if you boot Linux at hyp, as we've recommended for this precise > >> reason. That doesn't fix other things like

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Christopher Covington
On 09/05/2014 06:11 PM, Doug Anderson wrote: > Mark, > > On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: >> Not if you boot Linux at hyp, as we've recommended for this precise >> reason. That doesn't fix other things like CNTFRQ if the secure >> initialisation doesn't poke that, however. >

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Christopher Covington
On 09/05/2014 06:11 PM, Doug Anderson wrote: Mark, On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: Not if you boot Linux at hyp, as we've recommended for this precise reason. That doesn't fix other things like CNTFRQ if the secure initialisation doesn't poke that,

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Catalin Marinas
On Wed, Sep 10, 2014 at 03:58:15PM +0100, Christopher Covington wrote: On 09/05/2014 06:11 PM, Doug Anderson wrote: On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: Not if you boot Linux at hyp, as we've recommended for this precise reason. That doesn't fix other

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Mark Rutland
On Wed, Sep 10, 2014 at 03:58:15PM +0100, Christopher Covington wrote: On 09/05/2014 06:11 PM, Doug Anderson wrote: Mark, On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: Not if you boot Linux at hyp, as we've recommended for this precise reason. That doesn't

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Catalin Marinas
On Fri, Sep 05, 2014 at 11:11:47PM +0100, Doug Anderson wrote: On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: Not if you boot Linux at hyp, as we've recommended for this precise reason. That doesn't fix other things like CNTFRQ if the secure initialisation doesn't

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Olof Johansson
On Wed, Sep 10, 2014 at 8:55 AM, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Sep 10, 2014 at 03:58:15PM +0100, Christopher Covington wrote: On 09/05/2014 06:11 PM, Doug Anderson wrote: Mark, On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: Not if you boot

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Catalin, On Mon, Sep 8, 2014 at 6:54 AM, Catalin Marinas catalin.mari...@arm.com wrote: On Fri, Sep 05, 2014 at 11:11:47PM +0100, Doug Anderson wrote: On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: Not if you boot Linux at hyp, as we've recommended for this precise

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Mark, On Wed, Sep 10, 2014 at 8:55 AM, Mark Rutland mark.rutl...@arm.com wrote: That's not true in general as other secure initialization will still be necessary, and the extent and character of that initialization is going to be implementation specific. Can you give more examples of what you

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Mark Rutland
Hi Sonny, On Wed, Aug 27, 2014 at 10:03:39PM +0100, Sonny Rao wrote: This is a bug fix for using physical arch timers when the arch_timer_use_virtual boolean is false. It restores the arch_counter_get_cntpct() function after removal in 0d651e4e clocksource: arch_timer: use virtual counters

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Will Deacon
On Wed, Sep 10, 2014 at 06:17:23PM +0100, Doug Anderson wrote: On Mon, Sep 8, 2014 at 6:54 AM, Catalin Marinas catalin.mari...@arm.com wrote: On Fri, Sep 05, 2014 at 11:11:47PM +0100, Doug Anderson wrote: On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: Not if

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Mark, On Wed, Sep 10, 2014 at 10:27 AM, Mark Rutland mark.rutl...@arm.com wrote: Hi Sonny, On Wed, Aug 27, 2014 at 10:03:39PM +0100, Sonny Rao wrote: This is a bug fix for using physical arch timers when the arch_timer_use_virtual boolean is false. It restores the arch_counter_get_cntpct()

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Sonny Rao
On Wed, Sep 10, 2014 at 10:52 AM, Doug Anderson diand...@chromium.org wrote: Mark, On Wed, Sep 10, 2014 at 10:27 AM, Mark Rutland mark.rutl...@arm.com wrote: Hi Sonny, On Wed, Aug 27, 2014 at 10:03:39PM +0100, Sonny Rao wrote: This is a bug fix for using physical arch timers when the

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Will, On Wed, Sep 10, 2014 at 10:34 AM, Will Deacon will.dea...@arm.com wrote: Setting aside the security model, booting in secure mode can also have a significant impact on the programming model of system IP, not just the CPU. For example, the SMMU register file suddenly looks different and

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Hi, On Wed, Sep 10, 2014 at 10:52 AM, Doug Anderson diand...@chromium.org wrote: Mark, On Wed, Sep 10, 2014 at 10:27 AM, Mark Rutland mark.rutl...@arm.com wrote: Hi Sonny, On Wed, Aug 27, 2014 at 10:03:39PM +0100, Sonny Rao wrote: This is a bug fix for using physical arch timers when the

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Will Deacon
On Wed, Sep 10, 2014 at 07:09:59PM +0100, Doug Anderson wrote: On Wed, Sep 10, 2014 at 10:34 AM, Will Deacon will.dea...@arm.com wrote: Setting aside the security model, booting in secure mode can also have a significant impact on the programming model of system IP, not just the CPU. For

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-10 Thread Doug Anderson
Will, On Wed, Sep 10, 2014 at 11:46 AM, Will Deacon will.dea...@arm.com wrote: On Wed, Sep 10, 2014 at 07:09:59PM +0100, Doug Anderson wrote: On Wed, Sep 10, 2014 at 10:34 AM, Will Deacon will.dea...@arm.com wrote: Setting aside the security model, booting in secure mode can also have a

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-05 Thread Doug Anderson
Mark, On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: > Not if you boot Linux at hyp, as we've recommended for this precise > reason. That doesn't fix other things like CNTFRQ if the secure > initialisation doesn't poke that, however. I'll freely admit that I'm out of my league and out of

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-05 Thread Doug Anderson
Mark, On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: Not if you boot Linux at hyp, as we've recommended for this precise reason. That doesn't fix other things like CNTFRQ if the secure initialisation doesn't poke that, however. I'll freely admit that I'm out of my

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-04 Thread Mark Rutland
On Thu, Sep 04, 2014 at 06:01:27PM +0100, Sonny Rao wrote: > On Fri, Aug 29, 2014 at 3:04 AM, Mark Rutland wrote: > > On Fri, Aug 29, 2014 at 01:10:49AM +0100, Sonny Rao wrote: > >> On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: > >> > On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-04 Thread Lorenzo Pieralisi
On Thu, Sep 04, 2014 at 06:01:27PM +0100, Sonny Rao wrote: [...] > > If an OS is booted at PL2 it can access the physical counters, and > > should do so in case something like KVM will be used later. The OS can > > write to CNTVOFF at PL2, and if it sets CNTVOFF to zero the physical and > >

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-04 Thread Sonny Rao
On Fri, Aug 29, 2014 at 3:04 AM, Mark Rutland wrote: > On Fri, Aug 29, 2014 at 01:10:49AM +0100, Sonny Rao wrote: >> On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: >> > On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: >> >> Hi, >> >> >> >> On Wed, Aug 27, 2014 at 7:58 PM,

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-04 Thread Sonny Rao
On Fri, Aug 29, 2014 at 3:04 AM, Mark Rutland mark.rutl...@arm.com wrote: On Fri, Aug 29, 2014 at 01:10:49AM +0100, Sonny Rao wrote: On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: Hi, On Wed, Aug

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-04 Thread Lorenzo Pieralisi
On Thu, Sep 04, 2014 at 06:01:27PM +0100, Sonny Rao wrote: [...] If an OS is booted at PL2 it can access the physical counters, and should do so in case something like KVM will be used later. The OS can write to CNTVOFF at PL2, and if it sets CNTVOFF to zero the physical and virtual

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-09-04 Thread Mark Rutland
On Thu, Sep 04, 2014 at 06:01:27PM +0100, Sonny Rao wrote: On Fri, Aug 29, 2014 at 3:04 AM, Mark Rutland mark.rutl...@arm.com wrote: On Fri, Aug 29, 2014 at 01:10:49AM +0100, Sonny Rao wrote: On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Aug 28, 2014 at

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-29 Thread Mark Rutland
On Fri, Aug 29, 2014 at 01:10:49AM +0100, Sonny Rao wrote: > On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: > > On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: > >> Hi, > >> > >> On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson wrote: > >> > On Wed, Aug 27, 2014 at 5:56 PM,

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-29 Thread Mark Rutland
On Fri, Aug 29, 2014 at 01:10:49AM +0100, Sonny Rao wrote: On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: Hi, On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson o...@lixom.net wrote: On Wed, Aug 27,

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-28 Thread Sonny Rao
On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland wrote: > On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: >> Hi, >> >> On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson wrote: >> > On Wed, Aug 27, 2014 at 5:56 PM, Stephen Boyd wrote: >> >> On 08/27/14 15:33, Olof Johansson wrote: >>

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:09:32PM +0100, Christopher Covington wrote: > Hi Mark, Hi Christopher, > On 08/28/2014 05:35 AM, Mark Rutland wrote: > > On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: > >> Hi, > >> > >> On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson wrote: > >>> On

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-28 Thread Christopher Covington
Hi Mark, On 08/28/2014 05:35 AM, Mark Rutland wrote: > On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: >> Hi, >> >> On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson wrote: >>> On Wed, Aug 27, 2014 at 5:56 PM, Stephen Boyd wrote: On 08/27/14 15:33, Olof Johansson wrote: >

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: > Hi, > > On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson wrote: > > On Wed, Aug 27, 2014 at 5:56 PM, Stephen Boyd wrote: > >> On 08/27/14 15:33, Olof Johansson wrote: > >>> On Wed, Aug 27, 2014 at 3:26 PM, Stephen Boyd > >>>

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-28 Thread Marc Zyngier
[cc-ing Will for the VDSO bits] Hi Sonny, On 27/08/14 22:03, Sonny Rao wrote: > This is a bug fix for using physical arch timers when > the arch_timer_use_virtual boolean is false. It restores the > arch_counter_get_cntpct() function after removal in > > 0d651e4e "clocksource: arch_timer: use

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-28 Thread Marc Zyngier
[cc-ing Will for the VDSO bits] Hi Sonny, On 27/08/14 22:03, Sonny Rao wrote: This is a bug fix for using physical arch timers when the arch_timer_use_virtual boolean is false. It restores the arch_counter_get_cntpct() function after removal in 0d651e4e clocksource: arch_timer: use

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: Hi, On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson o...@lixom.net wrote: On Wed, Aug 27, 2014 at 5:56 PM, Stephen Boyd sb...@codeaurora.org wrote: On 08/27/14 15:33, Olof Johansson wrote: On Wed, Aug 27, 2014 at 3:26 PM,

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-28 Thread Christopher Covington
Hi Mark, On 08/28/2014 05:35 AM, Mark Rutland wrote: On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: Hi, On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson o...@lixom.net wrote: On Wed, Aug 27, 2014 at 5:56 PM, Stephen Boyd sb...@codeaurora.org wrote: On 08/27/14 15:33, Olof

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:09:32PM +0100, Christopher Covington wrote: Hi Mark, Hi Christopher, On 08/28/2014 05:35 AM, Mark Rutland wrote: On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: Hi, On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson o...@lixom.net wrote: On Wed,

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-28 Thread Sonny Rao
On Thu, Aug 28, 2014 at 2:35 AM, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Aug 28, 2014 at 04:33:31AM +0100, Doug Anderson wrote: Hi, On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson o...@lixom.net wrote: On Wed, Aug 27, 2014 at 5:56 PM, Stephen Boyd sb...@codeaurora.org wrote: On

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Doug Anderson
Hi, On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson wrote: > On Wed, Aug 27, 2014 at 5:56 PM, Stephen Boyd wrote: >> On 08/27/14 15:33, Olof Johansson wrote: >>> On Wed, Aug 27, 2014 at 3:26 PM, Stephen Boyd wrote: >>> Is there any reason why the virtual counter can't be read? Maybe we're

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Olof Johansson
On Wed, Aug 27, 2014 at 5:56 PM, Stephen Boyd wrote: > On 08/27/14 15:33, Olof Johansson wrote: >> On Wed, Aug 27, 2014 at 3:26 PM, Stephen Boyd wrote: >> >>> Is there any reason why the virtual counter can't be read? Maybe we're >>> the hyp and we need to make sure we don't use the virtual

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Stephen Boyd
On 08/27/14 15:33, Olof Johansson wrote: > On Wed, Aug 27, 2014 at 3:26 PM, Stephen Boyd wrote: > >> Is there any reason why the virtual counter can't be read? Maybe we're >> the hyp and we need to make sure we don't use the virtual timer so that >> the guest can use it, but that doesn't have any

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Olof Johansson
On Wed, Aug 27, 2014 at 3:26 PM, Stephen Boyd wrote: > +Mark (author of change in question) > > On 08/27/14 14:27, Sonny Rao wrote: >> On Wed, Aug 27, 2014 at 2:19 PM, Olof Johansson wrote: >>> On Wed, Aug 27, 2014 at 2:03 PM, Sonny Rao wrote: This is a bug fix for using physical arch

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Stephen Boyd
+Mark (author of change in question) On 08/27/14 14:27, Sonny Rao wrote: > On Wed, Aug 27, 2014 at 2:19 PM, Olof Johansson wrote: >> On Wed, Aug 27, 2014 at 2:03 PM, Sonny Rao wrote: >>> This is a bug fix for using physical arch timers when >>> the arch_timer_use_virtual boolean is false. It

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Sonny Rao
On Wed, Aug 27, 2014 at 2:19 PM, Olof Johansson wrote: > On Wed, Aug 27, 2014 at 2:03 PM, Sonny Rao wrote: >> This is a bug fix for using physical arch timers when >> the arch_timer_use_virtual boolean is false. It restores the >> arch_counter_get_cntpct() function after removal in >> >>

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Olof Johansson
On Wed, Aug 27, 2014 at 2:03 PM, Sonny Rao wrote: > This is a bug fix for using physical arch timers when > the arch_timer_use_virtual boolean is false. It restores the > arch_counter_get_cntpct() function after removal in > > 0d651e4e "clocksource: arch_timer: use virtual counters" > > and

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Olof Johansson
On Wed, Aug 27, 2014 at 2:03 PM, Sonny Rao sonny...@chromium.org wrote: This is a bug fix for using physical arch timers when the arch_timer_use_virtual boolean is false. It restores the arch_counter_get_cntpct() function after removal in 0d651e4e clocksource: arch_timer: use virtual

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Sonny Rao
On Wed, Aug 27, 2014 at 2:19 PM, Olof Johansson o...@lixom.net wrote: On Wed, Aug 27, 2014 at 2:03 PM, Sonny Rao sonny...@chromium.org wrote: This is a bug fix for using physical arch timers when the arch_timer_use_virtual boolean is false. It restores the arch_counter_get_cntpct() function

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Stephen Boyd
+Mark (author of change in question) On 08/27/14 14:27, Sonny Rao wrote: On Wed, Aug 27, 2014 at 2:19 PM, Olof Johansson o...@lixom.net wrote: On Wed, Aug 27, 2014 at 2:03 PM, Sonny Rao sonny...@chromium.org wrote: This is a bug fix for using physical arch timers when the

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Olof Johansson
On Wed, Aug 27, 2014 at 3:26 PM, Stephen Boyd sb...@codeaurora.org wrote: +Mark (author of change in question) On 08/27/14 14:27, Sonny Rao wrote: On Wed, Aug 27, 2014 at 2:19 PM, Olof Johansson o...@lixom.net wrote: On Wed, Aug 27, 2014 at 2:03 PM, Sonny Rao sonny...@chromium.org wrote:

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Stephen Boyd
On 08/27/14 15:33, Olof Johansson wrote: On Wed, Aug 27, 2014 at 3:26 PM, Stephen Boyd sb...@codeaurora.org wrote: Is there any reason why the virtual counter can't be read? Maybe we're the hyp and we need to make sure we don't use the virtual timer so that the guest can use it, but that

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Olof Johansson
On Wed, Aug 27, 2014 at 5:56 PM, Stephen Boyd sb...@codeaurora.org wrote: On 08/27/14 15:33, Olof Johansson wrote: On Wed, Aug 27, 2014 at 3:26 PM, Stephen Boyd sb...@codeaurora.org wrote: Is there any reason why the virtual counter can't be read? Maybe we're the hyp and we need to make sure

Re: [PATCH] clocksource: arch_timer: Fix code to use physical timers when requested

2014-08-27 Thread Doug Anderson
Hi, On Wed, Aug 27, 2014 at 7:58 PM, Olof Johansson o...@lixom.net wrote: On Wed, Aug 27, 2014 at 5:56 PM, Stephen Boyd sb...@codeaurora.org wrote: On 08/27/14 15:33, Olof Johansson wrote: On Wed, Aug 27, 2014 at 3:26 PM, Stephen Boyd sb...@codeaurora.org wrote: Is there any reason why the