Re: [PATCH] cpufreq: imx6q: add return value check for voltage scale
On 05-11-18, 00:59, Anson Huang wrote:
> Add return value check for voltage scale when ARM clock
> rate change fail.
>
> Signed-off-by: Anson Huang
> ---
> drivers/cpufreq/imx6q-cpufreq.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
> index 8cfee0a..d8c3595 100644
> --- a/drivers/cpufreq/imx6q-cpufreq.c
> +++ b/drivers/cpufreq/imx6q-cpufreq.c
> @@ -160,8 +160,13 @@ static int imx6q_set_target(struct cpufreq_policy
> *policy, unsigned int index)
> /* Ensure the arm clock divider is what we expect */
> ret = clk_set_rate(clks[ARM].clk, new_freq * 1000);
> if (ret) {
> + int ret1;
> +
> dev_err(cpu_dev, "failed to set clock rate: %d\n", ret);
> - regulator_set_voltage_tol(arm_reg, volt_old, 0);
> + ret1 = regulator_set_voltage_tol(arm_reg, volt_old, 0);
> + if (ret1)
> + dev_warn(cpu_dev,
> + "failed to restore vddarm voltage: %d\n",
> ret1);
> return ret;
> }
>
Acked-by: Viresh Kumar
--
viresh
Re: [PATCH] cpufreq: imx6q: add return value check for voltage scale
On 05-11-18, 00:59, Anson Huang wrote:
> Add return value check for voltage scale when ARM clock
> rate change fail.
>
> Signed-off-by: Anson Huang
> ---
> drivers/cpufreq/imx6q-cpufreq.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
> index 8cfee0a..d8c3595 100644
> --- a/drivers/cpufreq/imx6q-cpufreq.c
> +++ b/drivers/cpufreq/imx6q-cpufreq.c
> @@ -160,8 +160,13 @@ static int imx6q_set_target(struct cpufreq_policy
> *policy, unsigned int index)
> /* Ensure the arm clock divider is what we expect */
> ret = clk_set_rate(clks[ARM].clk, new_freq * 1000);
> if (ret) {
> + int ret1;
> +
> dev_err(cpu_dev, "failed to set clock rate: %d\n", ret);
> - regulator_set_voltage_tol(arm_reg, volt_old, 0);
> + ret1 = regulator_set_voltage_tol(arm_reg, volt_old, 0);
> + if (ret1)
> + dev_warn(cpu_dev,
> + "failed to restore vddarm voltage: %d\n",
> ret1);
> return ret;
> }
>
Acked-by: Viresh Kumar
--
viresh
