Re: [PATCH] dcache: fix locking bug in __dentry_path()

2014-01-24 Thread Denys Vlasenko
On 01/24/2014 01:24 PM, Al Viro wrote: > On Fri, Jan 24, 2014 at 11:21:26AM +0100, Denys Vlasenko wrote: >> If given buffer size is zero, we forget to rcu_read_unlock() >> on error path. > > Er... Where could we ever get called with size zero? IOW, the > real question is whether that check

Re: [PATCH] dcache: fix locking bug in __dentry_path()

2014-01-24 Thread Al Viro
On Fri, Jan 24, 2014 at 11:21:26AM +0100, Denys Vlasenko wrote: > If given buffer size is zero, we forget to rcu_read_unlock() > on error path. Er... Where could we ever get called with size zero? IOW, the real question is whether that check makes any sense. If nothing else, a much more

Re: [PATCH] dcache: fix locking bug in __dentry_path()

2014-01-24 Thread Al Viro
On Fri, Jan 24, 2014 at 11:21:26AM +0100, Denys Vlasenko wrote: If given buffer size is zero, we forget to rcu_read_unlock() on error path. Er... Where could we ever get called with size zero? IOW, the real question is whether that check makes any sense. If nothing else, a much more obvious

Re: [PATCH] dcache: fix locking bug in __dentry_path()

2014-01-24 Thread Denys Vlasenko
On 01/24/2014 01:24 PM, Al Viro wrote: On Fri, Jan 24, 2014 at 11:21:26AM +0100, Denys Vlasenko wrote: If given buffer size is zero, we forget to rcu_read_unlock() on error path. Er... Where could we ever get called with size zero? IOW, the real question is whether that check makes any