Re: [PATCH] dmaengine: at_xdmac: don't restore unsaved status

[Ludovic Desroches]

On Thu, Dec 01, 2016 at 11:49:03AM +0100, Alexandre Belloni wrote:
> save_gs is supposed to save the channel status in order to be restored at
> resume time but it is never updated and is always 0. Anyway, the channel
> status is updated in the per channel loop later in the resume function.
> 
> Signed-off-by: Alexandre Belloni 

Acked-by: Ludovic Desroches 

Thanks

> ---
>  drivers/dma/at_xdmac.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index b7d7f2d443a1..8c1abb794340 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -221,7 +221,6 @@ struct at_xdmac {
>   int irq;
>   struct clk  *clk;
>   u32 save_gim;
> - u32 save_gs;
>   struct dma_pool *at_xdmac_desc_pool;
>   struct at_xdmac_chanchan[0];
>  };
> @@ -1896,7 +1895,6 @@ static int atmel_xdmac_resume(struct device *dev)
>   }
>  
>   at_xdmac_write(atxdmac, AT_XDMAC_GIE, atxdmac->save_gim);
> - at_xdmac_write(atxdmac, AT_XDMAC_GE, atxdmac->save_gs);
>   list_for_each_entry_safe(chan, _chan, >dma.channels, 
> device_node) {
>   atchan = to_at_xdmac_chan(chan);
>   at_xdmac_chan_write(atchan, AT_XDMAC_CC, atchan->save_cc);
> -- 
> 2.10.2
> 

Re: [PATCH] dmaengine: at_xdmac: don't restore unsaved status

[Ludovic Desroches]

On Thu, Dec 01, 2016 at 11:49:03AM +0100, Alexandre Belloni wrote:
> save_gs is supposed to save the channel status in order to be restored at
> resume time but it is never updated and is always 0. Anyway, the channel
> status is updated in the per channel loop later in the resume function.
> 
> Signed-off-by: Alexandre Belloni 

Acked-by: Ludovic Desroches 

Thanks

> ---
>  drivers/dma/at_xdmac.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index b7d7f2d443a1..8c1abb794340 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -221,7 +221,6 @@ struct at_xdmac {
>   int irq;
>   struct clk  *clk;
>   u32 save_gim;
> - u32 save_gs;
>   struct dma_pool *at_xdmac_desc_pool;
>   struct at_xdmac_chanchan[0];
>  };
> @@ -1896,7 +1895,6 @@ static int atmel_xdmac_resume(struct device *dev)
>   }
>  
>   at_xdmac_write(atxdmac, AT_XDMAC_GIE, atxdmac->save_gim);
> - at_xdmac_write(atxdmac, AT_XDMAC_GE, atxdmac->save_gs);
>   list_for_each_entry_safe(chan, _chan, >dma.channels, 
> device_node) {
>   atchan = to_at_xdmac_chan(chan);
>   at_xdmac_chan_write(atchan, AT_XDMAC_CC, atchan->save_cc);
> -- 
> 2.10.2
> 

Re: [PATCH] dmaengine: at_xdmac: don't restore unsaved status

[Nicolas Ferre]

Le 01/12/2016 à 11:49, Alexandre Belloni a écrit :
> save_gs is supposed to save the channel status in order to be restored at
> resume time but it is never updated and is always 0. Anyway, the channel
> status is updated in the per channel loop later in the resume function.
> 
> Signed-off-by: Alexandre Belloni 

Indeed, seems superfluous...
Acked-by: Nicolas Ferre 

> ---
>  drivers/dma/at_xdmac.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index b7d7f2d443a1..8c1abb794340 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -221,7 +221,6 @@ struct at_xdmac {
>   int irq;
>   struct clk  *clk;
>   u32 save_gim;
> - u32 save_gs;
>   struct dma_pool *at_xdmac_desc_pool;
>   struct at_xdmac_chanchan[0];
>  };
> @@ -1896,7 +1895,6 @@ static int atmel_xdmac_resume(struct device *dev)
>   }
>  
>   at_xdmac_write(atxdmac, AT_XDMAC_GIE, atxdmac->save_gim);
> - at_xdmac_write(atxdmac, AT_XDMAC_GE, atxdmac->save_gs);
>   list_for_each_entry_safe(chan, _chan, >dma.channels, 
> device_node) {
>   atchan = to_at_xdmac_chan(chan);
>   at_xdmac_chan_write(atchan, AT_XDMAC_CC, atchan->save_cc);
> 


-- 
Nicolas Ferre

Re: [PATCH] dmaengine: at_xdmac: don't restore unsaved status

[Nicolas Ferre]

Le 01/12/2016 à 11:49, Alexandre Belloni a écrit :
> save_gs is supposed to save the channel status in order to be restored at
> resume time but it is never updated and is always 0. Anyway, the channel
> status is updated in the per channel loop later in the resume function.
> 
> Signed-off-by: Alexandre Belloni 

Indeed, seems superfluous...
Acked-by: Nicolas Ferre 

> ---
>  drivers/dma/at_xdmac.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index b7d7f2d443a1..8c1abb794340 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -221,7 +221,6 @@ struct at_xdmac {
>   int irq;
>   struct clk  *clk;
>   u32 save_gim;
> - u32 save_gs;
>   struct dma_pool *at_xdmac_desc_pool;
>   struct at_xdmac_chanchan[0];
>  };
> @@ -1896,7 +1895,6 @@ static int atmel_xdmac_resume(struct device *dev)
>   }
>  
>   at_xdmac_write(atxdmac, AT_XDMAC_GIE, atxdmac->save_gim);
> - at_xdmac_write(atxdmac, AT_XDMAC_GE, atxdmac->save_gs);
>   list_for_each_entry_safe(chan, _chan, >dma.channels, 
> device_node) {
>   atchan = to_at_xdmac_chan(chan);
>   at_xdmac_chan_write(atchan, AT_XDMAC_CC, atchan->save_cc);
> 


-- 
Nicolas Ferre