Re: [PATCH] dmaengine: dmatest: Remove use of VLAs

2018-04-10 Thread Vinod Koul
On Mon, Apr 09, 2018 at 04:14:20PM -0700, Laura Abbott wrote: > On 04/09/2018 03:48 PM, Sinan Kaya wrote: > >On 4/9/2018 5:06 PM, Laura Abbott wrote: > >>+ /* dst_cnt can't be more than u8 */ > >>+ dma_addr_t dma_pq[255]; > > > >This is 2k stack space on 64 bit a

Re: [PATCH] dmaengine: dmatest: Remove use of VLAs

2018-04-09 Thread kbuild test robot
Hi Laura, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.16 next-20180409] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

Re: [PATCH] dmaengine: dmatest: Remove use of VLAs

2018-04-09 Thread okaya
On 2018-04-09 19:14, Laura Abbott wrote: On 04/09/2018 03:48 PM, Sinan Kaya wrote: On 4/9/2018 5:06 PM, Laura Abbott wrote: + /* dst_cnt can't be more than u8 */ + dma_addr_t dma_pq[255]; This is 2k stack space on 64 bit architectures. Isn't that a

Re: [PATCH] dmaengine: dmatest: Remove use of VLAs

2018-04-09 Thread Laura Abbott
On 04/09/2018 03:48 PM, Sinan Kaya wrote: On 4/9/2018 5:06 PM, Laura Abbott wrote: + /* dst_cnt can't be more than u8 */ + dma_addr_t dma_pq[255]; This is 2k stack space on 64 bit architectures. Isn't that a lot? Depends on your definition of 'a l

Re: [PATCH] dmaengine: dmatest: Remove use of VLAs

2018-04-09 Thread Sinan Kaya
On 4/9/2018 5:06 PM, Laura Abbott wrote: > + /* dst_cnt can't be more than u8 */ > + dma_addr_t dma_pq[255]; This is 2k stack space on 64 bit architectures. Isn't that a lot? -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm