Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

On 8 August 2016 at 12:43, Yakir Yang wrote: > + Archit > > Tomeu, > > Thanks for the update :-) > > But you have missed three tiny align problems, please see my inline notes, > wish you could fix them. After that this patch looks good to me, so: > > Reviewed-by: Yakir Yang

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

On 8 August 2016 at 12:43, Yakir Yang wrote: > + Archit > > Tomeu, > > Thanks for the update :-) > > But you have missed three tiny align problems, please see my inline notes, > wish you could fix them. After that this patch looks good to me, so: > > Reviewed-by: Yakir Yang Hi Yakir, thanks

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

+ Archit Tomeu, Thanks for the update :-) But you have missed three tiny align problems, please see my inline notes, wish you could fix them. After that this patch looks good to me, so: Reviewed-by: Yakir Yang I guess this patch should go through Archit's drm_bridge

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

+ Archit Tomeu, Thanks for the update :-) But you have missed three tiny align problems, please see my inline notes, wish you could fix them. After that this patch looks good to me, so: Reviewed-by: Yakir Yang I guess this patch should go through Archit's drm_bridge tree, so I added him

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

On Fri, Aug 5, 2016 at 8:59 AM, Tomeu Vizoso wrote: > Remove code for reading the EDID and DPCD fields and use the helpers > instead. > > Besides the obvious code reduction, other helpers are being added to the > core that could be used in this driver and will be good

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

On Fri, Aug 5, 2016 at 8:59 AM, Tomeu Vizoso wrote: > Remove code for reading the EDID and DPCD fields and use the helpers > instead. > > Besides the obvious code reduction, other helpers are being added to the > core that could be used in this driver and will be good to be able to > use them

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

Tomeu, o_O Ignore my previous email, seems I make a mistaken about the email format, and mess up the patch format. I have move my previous comments to this one :-) On 08/04/2016 02:23 PM, Tomeu Vizoso wrote: Remove code for reading the EDID and DPCD fields and use the helpers instead.

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

Tomeu, o_O Ignore my previous email, seems I make a mistaken about the email format, and mess up the patch format. I have move my previous comments to this one :-) On 08/04/2016 02:23 PM, Tomeu Vizoso wrote: Remove code for reading the EDID and DPCD fields and use the helpers instead.

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

Tomeu, Nice job ! Have a few nits bellow. ;) On 08/04/2016 02:23 PM, Tomeu Vizoso wrote: Remove code for reading the EDID and DPCD fields and use the helpers instead. Besides the obvious code reduction, other helpers are being added to the core that could be used in this driver and will be

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

Tomeu, Nice job ! Have a few nits bellow. ;) On 08/04/2016 02:23 PM, Tomeu Vizoso wrote: Remove code for reading the EDID and DPCD fields and use the helpers instead. Besides the obvious code reduction, other helpers are being added to the core that could be used in this driver and will be

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

On Thu, Aug 4, 2016 at 2:23 AM, Tomeu Vizoso wrote: > Remove code for reading the EDID and DPCD fields and use the helpers > instead. > > Besides the obvious code reduction, other helpers are being added to the > core that could be used in this driver and will be good

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

On Thu, Aug 4, 2016 at 2:23 AM, Tomeu Vizoso wrote: > Remove code for reading the EDID and DPCD fields and use the helpers > instead. > > Besides the obvious code reduction, other helpers are being added to the > core that could be used in this driver and will be good to be able to > use them

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

Hello Tomeu, On 08/04/2016 02:23 AM, Tomeu Vizoso wrote: > Remove code for reading the EDID and DPCD fields and use the helpers > instead. > > Besides the obvious code reduction, other helpers are being added to the > core that could be used in this driver and will be good to be able to > use

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

Hello Tomeu, On 08/04/2016 02:23 AM, Tomeu Vizoso wrote: > Remove code for reading the EDID and DPCD fields and use the helpers > instead. > > Besides the obvious code reduction, other helpers are being added to the > core that could be used in this driver and will be good to be able to > use