Re: [PATCH] drm/p[111: add CONFIG_OF dependency
On Thu, Feb 22, 2018 at 9:08 PM, Eric Anholtwrote: > Arnd Bergmann writes: > >> We cannot select a symbol without meeting its other dependencies: >> >> warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct >> dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) >> drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': >> drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has >> no member named 'of_node' >> vga->bridge.of_node = pdev->dev.of_node; >> ^ >> >> Here it seems reasonable to depend on CONFIG_OF, as all platforms >> using this driver already require that anyway. > > Looks like we'll be going with > > https://patchwork.freedesktop.org/patch/205580/ Ok, even better! Arnd
Re: [PATCH] drm/p[111: add CONFIG_OF dependency
On Thu, Feb 22, 2018 at 9:08 PM, Eric Anholt wrote: > Arnd Bergmann writes: > >> We cannot select a symbol without meeting its other dependencies: >> >> warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct >> dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) >> drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': >> drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has >> no member named 'of_node' >> vga->bridge.of_node = pdev->dev.of_node; >> ^ >> >> Here it seems reasonable to depend on CONFIG_OF, as all platforms >> using this driver already require that anyway. > > Looks like we'll be going with > > https://patchwork.freedesktop.org/patch/205580/ Ok, even better! Arnd
Re: [PATCH] drm/p[111: add CONFIG_OF dependency
Arnd Bergmannwrites: > We cannot select a symbol without meeting its other dependencies: > > warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct > dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) > drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': > drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has > no member named 'of_node' > vga->bridge.of_node = pdev->dev.of_node; > ^ > > Here it seems reasonable to depend on CONFIG_OF, as all platforms > using this driver already require that anyway. Looks like we'll be going with https://patchwork.freedesktop.org/patch/205580/ signature.asc Description: PGP signature
Re: [PATCH] drm/p[111: add CONFIG_OF dependency
Arnd Bergmann writes: > We cannot select a symbol without meeting its other dependencies: > > warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct > dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) > drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': > drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has > no member named 'of_node' > vga->bridge.of_node = pdev->dev.of_node; > ^ > > Here it seems reasonable to depend on CONFIG_OF, as all platforms > using this driver already require that anyway. Looks like we'll be going with https://patchwork.freedesktop.org/patch/205580/ signature.asc Description: PGP signature