Re: [PATCH] ext4: do not advertise encryption support when disabled
On Mon, Oct 10, 2016 at 12:05:31PM -0700, Eric Biggers wrote: > The sysfs file /sys/fs/ext4/features/encryption was present on kernels > compiled with CONFIG_EXT4_FS_ENCRYPTION=n. This was misleading because > such kernels do not actually support ext4 encryption. Therefore, only > provide this file on kernels compiled with CONFIG_EXT4_FS_ENCRYPTION=y. > > Note: since the ext4 feature files are all hardcoded to have a contents > of "supported", it really is the presence or absence of the file that is > significant, not the contents (and this change reflects that). > > Signed-off-by: Eric BiggersThanks, applied. - Ted
Re: [PATCH] ext4: do not advertise encryption support when disabled
On Mon, Oct 10, 2016 at 12:05:31PM -0700, Eric Biggers wrote: > The sysfs file /sys/fs/ext4/features/encryption was present on kernels > compiled with CONFIG_EXT4_FS_ENCRYPTION=n. This was misleading because > such kernels do not actually support ext4 encryption. Therefore, only > provide this file on kernels compiled with CONFIG_EXT4_FS_ENCRYPTION=y. > > Note: since the ext4 feature files are all hardcoded to have a contents > of "supported", it really is the presence or absence of the file that is > significant, not the contents (and this change reflects that). > > Signed-off-by: Eric Biggers Thanks, applied. - Ted