On Mon, Sep 18, 2017 at 05:15:01PM +0200, Greg KH wrote:
> On Thu, Sep 14, 2017 at 03:54:22PM -0700, Luis R. Rodriguez wrote:
> > +enum fw_priv_reqs {
> > + FW_PRIV_REQ_FALLBACK= 1 << 0,
> > + FW_PRIV_REQ_FALLBACK_UEVENT = 1 << 1,
> > + FW_PRIV_REQ_NO_CACHE
On Mon, Sep 18, 2017 at 05:15:01PM +0200, Greg KH wrote:
> On Thu, Sep 14, 2017 at 03:54:22PM -0700, Luis R. Rodriguez wrote:
> > +enum fw_priv_reqs {
> > + FW_PRIV_REQ_FALLBACK= 1 << 0,
> > + FW_PRIV_REQ_FALLBACK_UEVENT = 1 << 1,
> > + FW_PRIV_REQ_NO_CACHE
On Fri, Sep 15, 2017 at 10:30:46AM +0200, Martin Fuzzey wrote:
> On 15/09/17 00:54, Luis R. Rodriguez wrote:
> > The above benefits makes the code much easier to understand and maintain.
>
> Yes I agree it is much cleaner that way.
>
> A couple of nitpicks below.
>
> > +/**
> > + * enum
On Fri, Sep 15, 2017 at 10:30:46AM +0200, Martin Fuzzey wrote:
> On 15/09/17 00:54, Luis R. Rodriguez wrote:
> > The above benefits makes the code much easier to understand and maintain.
>
> Yes I agree it is much cleaner that way.
>
> A couple of nitpicks below.
>
> > +/**
> > + * enum
On Thu, Sep 14, 2017 at 03:54:22PM -0700, Luis R. Rodriguez wrote:
> +enum fw_priv_reqs {
> + FW_PRIV_REQ_FALLBACK= 1 << 0,
> + FW_PRIV_REQ_FALLBACK_UEVENT = 1 << 1,
> + FW_PRIV_REQ_NO_CACHE= 1 << 2,
> + FW_PRIV_REQ_OPTIONAL
On Thu, Sep 14, 2017 at 03:54:22PM -0700, Luis R. Rodriguez wrote:
> +enum fw_priv_reqs {
> + FW_PRIV_REQ_FALLBACK= 1 << 0,
> + FW_PRIV_REQ_FALLBACK_UEVENT = 1 << 1,
> + FW_PRIV_REQ_NO_CACHE= 1 << 2,
> + FW_PRIV_REQ_OPTIONAL
Hi Luis,
On 15/09/17 00:54, Luis R. Rodriguez wrote:
The firmware API has a slew of private options available, which can
sometimes be hard to understand. When new functionality is introduced
we also tend to have modify a slew of internal helpers.
Just stuff all common private requirements into
Hi Luis,
On 15/09/17 00:54, Luis R. Rodriguez wrote:
The firmware API has a slew of private options available, which can
sometimes be hard to understand. When new functionality is introduced
we also tend to have modify a slew of internal helpers.
Just stuff all common private requirements into
8 matches
Mail list logo