Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Thomas Gleixner
On Mon, 19 Sep 2016, Thomas Gleixner wrote: > On Mon, 19 Sep 2016, Marc Zyngier wrote: > > On 19/09/16 10:12, Thomas Gleixner wrote: > > > On Mon, 19 Sep 2016, Marc Zyngier wrote: > > >> if (handle != handle_bad_irq && is_chained) { > > >> +unsigned int type = > > >>

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Thomas Gleixner
On Mon, 19 Sep 2016, Thomas Gleixner wrote: > On Mon, 19 Sep 2016, Marc Zyngier wrote: > > On 19/09/16 10:12, Thomas Gleixner wrote: > > > On Mon, 19 Sep 2016, Marc Zyngier wrote: > > >> if (handle != handle_bad_irq && is_chained) { > > >> +unsigned int type = > > >>

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Sep 19, 2016 at 11:28 AM, Thomas Gleixner wrote: > On Mon, 19 Sep 2016, Marc Zyngier wrote: >> On 19/09/16 10:12, Thomas Gleixner wrote: >> > On Mon, 19 Sep 2016, Marc Zyngier wrote: >> >>if (handle != handle_bad_irq && is_chained) { >> >> +

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Sep 19, 2016 at 11:28 AM, Thomas Gleixner wrote: > On Mon, 19 Sep 2016, Marc Zyngier wrote: >> On 19/09/16 10:12, Thomas Gleixner wrote: >> > On Mon, 19 Sep 2016, Marc Zyngier wrote: >> >>if (handle != handle_bad_irq && is_chained) { >> >> + unsigned int type =

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Thomas Gleixner
On Mon, 19 Sep 2016, Marc Zyngier wrote: > On 19/09/16 10:12, Thomas Gleixner wrote: > > On Mon, 19 Sep 2016, Marc Zyngier wrote: > >>if (handle != handle_bad_irq && is_chained) { > >> + unsigned int type = irqd_get_trigger_type(>irq_data); > >> + > >>/* > >> *

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Thomas Gleixner
On Mon, 19 Sep 2016, Marc Zyngier wrote: > On 19/09/16 10:12, Thomas Gleixner wrote: > > On Mon, 19 Sep 2016, Marc Zyngier wrote: > >>if (handle != handle_bad_irq && is_chained) { > >> + unsigned int type = irqd_get_trigger_type(>irq_data); > >> + > >>/* > >> *

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Geert Uytterhoeven
Hi Marc, On Mon, Sep 19, 2016 at 10:49 AM, Marc Zyngier wrote: > There is no point in trying to configure the trigger of a chained > interrupt if no trigger information has been configured. At best > this is ignored, and at the worse this confuses the underlying > irqchip

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Geert Uytterhoeven
Hi Marc, On Mon, Sep 19, 2016 at 10:49 AM, Marc Zyngier wrote: > There is no point in trying to configure the trigger of a chained > interrupt if no trigger information has been configured. At best > this is ignored, and at the worse this confuses the underlying > irqchip (which is likely not to

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Marc Zyngier
On 19/09/16 10:12, Thomas Gleixner wrote: > On Mon, 19 Sep 2016, Marc Zyngier wrote: >> There is no point in trying to configure the trigger of a chained >> interrupt if no trigger information has been configured. At best >> this is ignored, and at the worse this confuses the underlying >> irqchip

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Marc Zyngier
On 19/09/16 10:12, Thomas Gleixner wrote: > On Mon, 19 Sep 2016, Marc Zyngier wrote: >> There is no point in trying to configure the trigger of a chained >> interrupt if no trigger information has been configured. At best >> this is ignored, and at the worse this confuses the underlying >> irqchip

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Thomas Gleixner
On Mon, 19 Sep 2016, Marc Zyngier wrote: > There is no point in trying to configure the trigger of a chained > interrupt if no trigger information has been configured. At best > this is ignored, and at the worse this confuses the underlying > irqchip (which is likely not to handle such a thing),

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

2016-09-19 Thread Thomas Gleixner
On Mon, 19 Sep 2016, Marc Zyngier wrote: > There is no point in trying to configure the trigger of a chained > interrupt if no trigger information has been configured. At best > this is ignored, and at the worse this confuses the underlying > irqchip (which is likely not to handle such a thing),