Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get()
On Wed, Oct 12, 2016 at 6:40 PM, Benjamin Tissoires wrote: > From: David Arcari > > acpi_dev_gpio_irq_get() currently ignores the error returned > by acpi_get_gpiod_by_index() and overwrites it with -ENOENT. > > Problem is this error can be -EPROBE_DEFER, which just blows > up some drivers when the module ordering is not correct. > > Cc: sta...@vger.kernel.org > Signed-off-by: David Arcari > Signed-off-by: Benjamin Tissoires Patch applied for fixes with Mika's ACK. Yours, Linus Walleij
Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get()
On Wed, Oct 12, 2016 at 06:40:30PM +0200, Benjamin Tissoires wrote: > From: David Arcari > > acpi_dev_gpio_irq_get() currently ignores the error returned > by acpi_get_gpiod_by_index() and overwrites it with -ENOENT. > > Problem is this error can be -EPROBE_DEFER, which just blows > up some drivers when the module ordering is not correct. > > Cc: sta...@vger.kernel.org > Signed-off-by: David Arcari > Signed-off-by: Benjamin Tissoires Acked-by: Mika Westerberg
Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get()
On Wed, Oct 12, 2016 at 6:40 PM, Benjamin Tissoires wrote: > From: David Arcari > > acpi_dev_gpio_irq_get() currently ignores the error returned > by acpi_get_gpiod_by_index() and overwrites it with -ENOENT. > > Problem is this error can be -EPROBE_DEFER, which just blows > up some drivers when the module ordering is not correct. > > Cc: sta...@vger.kernel.org > Signed-off-by: David Arcari > Signed-off-by: Benjamin Tissoires > --- > > Hi David, > > I am planning on sending this to the list, any last minute comments? Of course, I forgot to remove our internal sync comment. David's answer was "No. This looks good to me.", so I just went ahead and send the patch. Cheers, Benjamin
