On Wed, 31 Jan 2018 22:26:14 +0100
SF Markus Elfring <elfr...@users.sourceforge.net> wrote:
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Wed, 31 Jan 2018 22:20:56 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Marcus,
If making changes like this I would suggest only sending one until
you have have a response from the relevant maintainer.
It would save you time as often these sorts of changes are
a matter of personal taste and weighing up of costs vs gains
- hence it is not obvious that they will be accepted.
Jonathan
> ---
> drivers/iio/accel/hid-sensor-accel-3d.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c
> b/drivers/iio/accel/hid-sensor-accel-3d.c
> index c066a3bdbff7..3d0acde40285 100644
> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
> @@ -383,11 +383,9 @@ static int hid_accel_3d_probe(struct platform_device
> *pdev)
> return ret;
> }
> indio_dev->channels = kmemdup(channel_spec, channel_size, GFP_KERNEL);
> -
> - if (!indio_dev->channels) {
> - dev_err(&pdev->dev, "failed to duplicate channels\n");
> + if (!indio_dev->channels)
> return -ENOMEM;
> - }
> +
> ret = accel_3d_parse_report(pdev, hsdev,
> (struct iio_chan_spec *)indio_dev->channels,
> hsdev->usage, accel_state);
