Re: [PATCH] i2c-omap: always send stop after nack

2013-08-20 Thread Grygorii Strashko
On 08/19/2013 03:11 PM, Wolfram Sang wrote: Hi, Which means your original patch starts to make a lot more sense. I wonder is this is really what we should be doing though - breaking out of the loop, I mean. Yup, that is fine. I applied the old patch with Acks from Hein and Felipe to -next.

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-20 Thread Grygorii Strashko
On 08/19/2013 03:11 PM, Wolfram Sang wrote: Hi, Which means your original patch starts to make a lot more sense. I wonder is this is really what we should be doing though - breaking out of the loop, I mean. Yup, that is fine. I applied the old patch with Acks from Hein and Felipe to -next.

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-19 Thread Wolfram Sang
On Mon, Aug 19, 2013 at 08:57:02AM -0500, Felipe Balbi wrote: > On Mon, Aug 19, 2013 at 02:11:23PM +0200, Wolfram Sang wrote: > > Hi, > > > > > > Which means your original patch starts to make a lot more sense. I > > > > wonder is this is really what we should be doing though - breaking out > > >

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-19 Thread Felipe Balbi
On Mon, Aug 19, 2013 at 02:11:23PM +0200, Wolfram Sang wrote: > Hi, > > > > Which means your original patch starts to make a lot more sense. I > > > wonder is this is really what we should be doing though - breaking out > > > of the loop, I mean. > > Yup, that is fine. I applied the old patch

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-19 Thread Wolfram Sang
Hi, > > Which means your original patch starts to make a lot more sense. I > > wonder is this is really what we should be doing though - breaking out > > of the loop, I mean. Yup, that is fine. I applied the old patch with Acks from Hein and Felipe to -next. Thanks! > It looks like TI's

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-19 Thread Wolfram Sang
Hi, Which means your original patch starts to make a lot more sense. I wonder is this is really what we should be doing though - breaking out of the loop, I mean. Yup, that is fine. I applied the old patch with Acks from Hein and Felipe to -next. Thanks! It looks like TI's i2c-davinci

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-19 Thread Felipe Balbi
On Mon, Aug 19, 2013 at 02:11:23PM +0200, Wolfram Sang wrote: Hi, Which means your original patch starts to make a lot more sense. I wonder is this is really what we should be doing though - breaking out of the loop, I mean. Yup, that is fine. I applied the old patch with Acks from

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-19 Thread Wolfram Sang
On Mon, Aug 19, 2013 at 08:57:02AM -0500, Felipe Balbi wrote: On Mon, Aug 19, 2013 at 02:11:23PM +0200, Wolfram Sang wrote: Hi, Which means your original patch starts to make a lot more sense. I wonder is this is really what we should be doing though - breaking out of the loop, I

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Hein Tibosch
Hi Grygorii, Filipe, On 7/16/2013 9:00 PM, Felipe Balbi wrote: > On Tue, Jul 16, 2013 at 03:08:04PM +0300, Grygorii Strashko wrote: >> Hi Felipe, >> On 07/16/2013 02:27 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Tue, Jul 16, 2013 at 02:01:11PM +0300, Grygorii Strashko wrote: On a

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Felipe Balbi
Hi, (when replying, can you add some blank lines around your reply and the previous mail, it's quite difficult to find your replies with so many quote marks (>) around) On Tue, Jul 16, 2013 at 03:08:04PM +0300, Grygorii Strashko wrote: > Hi Felipe, > On 07/16/2013 02:27 PM, Felipe Balbi wrote: >

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Grygorii Strashko
Hi Felipe, On 07/16/2013 02:27 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 02:01:11PM +0300, Grygorii Strashko wrote: On a OMAP4460, i2c-bus-3: A driver (lm75) is causing many 'timeout waiting for bus ready' errors. SDA remains high (as it should), but SCL remains low after a NACK.

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 02:01:11PM +0300, Grygorii Strashko wrote: > On a OMAP4460, i2c-bus-3: > > A driver (lm75) is causing many 'timeout waiting for bus ready' errors. > SDA remains high (as it should), but SCL remains low after a NACK. > The bus becomes _unusable for

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Grygorii Strashko
Hi Hein, Felipe On 07/16/2013 12:42 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 05:33:47PM +0800, Hein Tibosch wrote: On 7/16/2013 5:03 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: Hi Vikram, On a OMAP4460, i2c-bus-3: A driver (lm75)

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Hein Tibosch
On 7/16/2013 5:03 PM, Felipe Balbi wrote: > Hi, > > On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: >> Hi Vikram, >> >> On a OMAP4460, i2c-bus-3: >> >> A driver (lm75) is causing many 'timeout waiting for bus ready' errors. >> SDA remains high (as it should), but SCL remains low

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 05:33:47PM +0800, Hein Tibosch wrote: > On 7/16/2013 5:03 PM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: > >> Hi Vikram, > >> > >> On a OMAP4460, i2c-bus-3: > >> > >> A driver (lm75) is causing many 'timeout

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: > Hi Vikram, > > On a OMAP4460, i2c-bus-3: > > A driver (lm75) is causing many 'timeout waiting for bus ready' errors. > SDA remains high (as it should), but SCL remains low after a NACK. > The bus becomes _unusable for other

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: Hi Vikram, On a OMAP4460, i2c-bus-3: A driver (lm75) is causing many 'timeout waiting for bus ready' errors. SDA remains high (as it should), but SCL remains low after a NACK. The bus becomes _unusable for other clients_.

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 05:33:47PM +0800, Hein Tibosch wrote: On 7/16/2013 5:03 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: Hi Vikram, On a OMAP4460, i2c-bus-3: A driver (lm75) is causing many 'timeout waiting for bus ready'

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Hein Tibosch
On 7/16/2013 5:03 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: Hi Vikram, On a OMAP4460, i2c-bus-3: A driver (lm75) is causing many 'timeout waiting for bus ready' errors. SDA remains high (as it should), but SCL remains low after a NACK. The

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Grygorii Strashko
Hi Hein, Felipe On 07/16/2013 12:42 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 05:33:47PM +0800, Hein Tibosch wrote: On 7/16/2013 5:03 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: Hi Vikram, On a OMAP4460, i2c-bus-3: A driver (lm75)

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 02:01:11PM +0300, Grygorii Strashko wrote: On a OMAP4460, i2c-bus-3: A driver (lm75) is causing many 'timeout waiting for bus ready' errors. SDA remains high (as it should), but SCL remains low after a NACK. The bus becomes _unusable for other clients_. While

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Grygorii Strashko
Hi Felipe, On 07/16/2013 02:27 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 02:01:11PM +0300, Grygorii Strashko wrote: On a OMAP4460, i2c-bus-3: A driver (lm75) is causing many 'timeout waiting for bus ready' errors. SDA remains high (as it should), but SCL remains low after a NACK.

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Felipe Balbi
Hi, (when replying, can you add some blank lines around your reply and the previous mail, it's quite difficult to find your replies with so many quote marks () around) On Tue, Jul 16, 2013 at 03:08:04PM +0300, Grygorii Strashko wrote: Hi Felipe, On 07/16/2013 02:27 PM, Felipe Balbi wrote: Hi,

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Hein Tibosch
Hi Grygorii, Filipe, On 7/16/2013 9:00 PM, Felipe Balbi wrote: On Tue, Jul 16, 2013 at 03:08:04PM +0300, Grygorii Strashko wrote: Hi Felipe, On 07/16/2013 02:27 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 02:01:11PM +0300, Grygorii Strashko wrote: On a OMAP4460, i2c-bus-3: A