Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Thomas Sailer

Alan Cox wrote:

> What format is it that causes the problems, the only badly supported key format
> right know I know of is 16bit bigendian. That needs some small esd patches.

S8 is a not very well supported format.

And btw there are many applications that cannot live with esd for
latency
reasons.

Tom
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Alan Cox

> Anything in between is IMO silly. Killing the format
> conversion drops the advantage of running many existing
> applications but don't bring you much closer to the goal
> of simplicity.

Those applications already have to deal with the fact some devices only
support 48KHz 16bit stereo audio. I run a full desktop environment on such
hardware without problems.

What format is it that causes the problems, the only badly supported key format
right know I know of is 16bit bigendian. That needs some small esd patches.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Jeff Garzik

On Mon, 4 Dec 2000, Thomas Sailer wrote:
> And before killing format conversion you should kill
> the mmap stunt, because the format conversion complexity
> (~25 LOC) is by far dwarfed by the mmap emulation stuff.

mmap -emulation- ??  Ug.  Is Quake really worth that much? :)


> The underlying question is:
> 
> - do we want an usb audio driver that supports the OSS
>   interface and with which most existing applications work

of course

> Anything in between is IMO silly. Killing the format
> conversion drops the advantage of running many existing
> applications but don't bring you much closer to the goal
> of simplicity.

OSS has always implied that the software performs conversions when the
hardware cannot support certain formats.  And the kernel direction has
always been to -remove- any software conversion code.  We removed
SoftOSS, for example.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Thomas Sailer

Alan Cox wrote:

> Definitely we should

If you start killing format conversion then >99% of the
existing applications won't work anymore with usbaudio.
At that point you can dump the OSS interface just as well.

And before killing format conversion you should kill
the mmap stunt, because the format conversion complexity
(~25 LOC) is by far dwarfed by the mmap emulation stuff.

The underlying question is:

- do we want an usb audio driver that supports the OSS
  interface and with which most existing applications work

- or do we want a simple driver with its own non-OSS
  interface.

Anything in between is IMO silly. Killing the format
conversion drops the advantage of running many existing
applications but don't bring you much closer to the goal
of simplicity.

Tom
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Alan Cox

> > Tjeerd. I deliberately applied only small bits of your patch before because
> > the mono mode stuff clutters the driver horribly and is not in the right place.
> > It belongs in the application/libraries
> 
> Then you should kill parts of drivers/usb/audio - it contains format conversions.

Definitely we should

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Pavel Machek

Hi!

> > It implements mono output and fixes a bug in the dma logic (reset necessary 
> > because some descriptors are already prefetched and are not updated
> 
> This is wrong. Linus please do not apply this patch, or if you have done back
> it out. Not only does it do format conversions in kernel (which is a strict
> not to be done in the sound driver policy) it also makes it impossible to make
> mmap work correctly with the OSS API definitions.
> 
> Tjeerd. I deliberately applied only small bits of your patch before because
> the mono mode stuff clutters the driver horribly and is not in the right place.
> It belongs in the application/libraries

Then you should kill parts of drivers/usb/audio - it contains format conversions.
-- 
I'm [EMAIL PROTECTED] "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Pavel Machek

Hi!

  It implements mono output and fixes a bug in the dma logic (reset necessary 
  because some descriptors are already prefetched and are not updated
 
 This is wrong. Linus please do not apply this patch, or if you have done back
 it out. Not only does it do format conversions in kernel (which is a strict
 not to be done in the sound driver policy) it also makes it impossible to make
 mmap work correctly with the OSS API definitions.
 
 Tjeerd. I deliberately applied only small bits of your patch before because
 the mono mode stuff clutters the driver horribly and is not in the right place.
 It belongs in the application/libraries

Then you should kill parts of drivers/usb/audio - it contains format conversions.
-- 
I'm [EMAIL PROTECTED] "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Alan Cox

  Tjeerd. I deliberately applied only small bits of your patch before because
  the mono mode stuff clutters the driver horribly and is not in the right place.
  It belongs in the application/libraries
 
 Then you should kill parts of drivers/usb/audio - it contains format conversions.

Definitely we should

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Thomas Sailer

Alan Cox wrote:

 Definitely we should

If you start killing format conversion then 99% of the
existing applications won't work anymore with usbaudio.
At that point you can dump the OSS interface just as well.

And before killing format conversion you should kill
the mmap stunt, because the format conversion complexity
(~25 LOC) is by far dwarfed by the mmap emulation stuff.

The underlying question is:

- do we want an usb audio driver that supports the OSS
  interface and with which most existing applications work

- or do we want a simple driver with its own non-OSS
  interface.

Anything in between is IMO silly. Killing the format
conversion drops the advantage of running many existing
applications but don't bring you much closer to the goal
of simplicity.

Tom
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Jeff Garzik

On Mon, 4 Dec 2000, Thomas Sailer wrote:
 And before killing format conversion you should kill
 the mmap stunt, because the format conversion complexity
 (~25 LOC) is by far dwarfed by the mmap emulation stuff.

mmap -emulation- ??  Ug.  Is Quake really worth that much? :)


 The underlying question is:
 
 - do we want an usb audio driver that supports the OSS
   interface and with which most existing applications work

of course

 Anything in between is IMO silly. Killing the format
 conversion drops the advantage of running many existing
 applications but don't bring you much closer to the goal
 of simplicity.

OSS has always implied that the software performs conversions when the
hardware cannot support certain formats.  And the kernel direction has
always been to -remove- any software conversion code.  We removed
SoftOSS, for example.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Alan Cox

 Anything in between is IMO silly. Killing the format
 conversion drops the advantage of running many existing
 applications but don't bring you much closer to the goal
 of simplicity.

Those applications already have to deal with the fact some devices only
support 48KHz 16bit stereo audio. I run a full desktop environment on such
hardware without problems.

What format is it that causes the problems, the only badly supported key format
right know I know of is 16bit bigendian. That needs some small esd patches.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-04 Thread Thomas Sailer

Alan Cox wrote:

 What format is it that causes the problems, the only badly supported key format
 right know I know of is 16bit bigendian. That needs some small esd patches.

S8 is a not very well supported format.

And btw there are many applications that cannot live with esd for
latency
reasons.

Tom
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-01 Thread Alan Cox

> It implements mono output and fixes a bug in the dma logic (reset necessary 
> because some descriptors are already prefetched and are not updated

This is wrong. Linus please do not apply this patch, or if you have done back
it out. Not only does it do format conversions in kernel (which is a strict
not to be done in the sound driver policy) it also makes it impossible to make
mmap work correctly with the OSS API definitions.

Tjeerd. I deliberately applied only small bits of your patch before because
the mono mode stuff clutters the driver horribly and is not in the right place.
It belongs in the application/libraries

Alan


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: [PATCH] i810_audio 2.4.0-test11

2000-12-01 Thread Alan Cox

 It implements mono output and fixes a bug in the dma logic (reset necessary 
 because some descriptors are already prefetched and are not updated

This is wrong. Linus please do not apply this patch, or if you have done back
it out. Not only does it do format conversions in kernel (which is a strict
not to be done in the sound driver policy) it also makes it impossible to make
mmap work correctly with the OSS API definitions.

Tjeerd. I deliberately applied only small bits of your patch before because
the mono mode stuff clutters the driver horribly and is not in the right place.
It belongs in the application/libraries

Alan


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/