Re: [PATCH] iio: as3935: improve error reporting in as3935_event_work

2016-06-26 Thread Jonathan Cameron
On 12/06/16 07:55, Matt Ranostay wrote: > > Also important to note these warnings are environment related (e.g. room with > lot of EMI noise) and unlikely a chip misconfiguration. Unless the tuning > capacitor setting is wrong of course Applied to the togreg branch of iio.git. Initially pushed

Re: [PATCH] iio: as3935: improve error reporting in as3935_event_work

2016-06-26 Thread Jonathan Cameron
On 12/06/16 07:55, Matt Ranostay wrote: > > Also important to note these warnings are environment related (e.g. room with > lot of EMI noise) and unlikely a chip misconfiguration. Unless the tuning > capacitor setting is wrong of course Applied to the togreg branch of iio.git. Initially pushed

Re: [PATCH] iio: as3935: improve error reporting in as3935_event_work

2016-06-12 Thread Matt Ranostay
Also important to note these warnings are environment related (e.g. room with lot of EMI noise) and unlikely a chip misconfiguration. Unless the tuning capacitor setting is wrong of course > On Jun 11, 2016, at 09:32, Jonathan Cameron wrote: > >> On 31/05/16 15:53, Andrew

Re: [PATCH] iio: as3935: improve error reporting in as3935_event_work

2016-06-12 Thread Matt Ranostay
Also important to note these warnings are environment related (e.g. room with lot of EMI noise) and unlikely a chip misconfiguration. Unless the tuning capacitor setting is wrong of course > On Jun 11, 2016, at 09:32, Jonathan Cameron wrote: > >> On 31/05/16 15:53, Andrew F. Davis wrote: >>>

Re: [PATCH] iio: as3935: improve error reporting in as3935_event_work

2016-06-11 Thread Jonathan Cameron
On 31/05/16 15:53, Andrew F. Davis wrote: > On 05/30/2016 09:52 AM, Arnd Bergmann wrote: >> gcc warns about a potentially uninitialized variable use >> in as3935_event_work: >> >> drivers/iio/proximity/as3935.c: In function ‘as3935_event_work’: >> drivers/iio/proximity/as3935.c:231:6: error: ‘val’

Re: [PATCH] iio: as3935: improve error reporting in as3935_event_work

2016-06-11 Thread Jonathan Cameron
On 31/05/16 15:53, Andrew F. Davis wrote: > On 05/30/2016 09:52 AM, Arnd Bergmann wrote: >> gcc warns about a potentially uninitialized variable use >> in as3935_event_work: >> >> drivers/iio/proximity/as3935.c: In function ‘as3935_event_work’: >> drivers/iio/proximity/as3935.c:231:6: error: ‘val’

Re: [PATCH] iio: as3935: improve error reporting in as3935_event_work

2016-05-31 Thread Andrew F. Davis
On 05/30/2016 09:52 AM, Arnd Bergmann wrote: > gcc warns about a potentially uninitialized variable use > in as3935_event_work: > > drivers/iio/proximity/as3935.c: In function ‘as3935_event_work’: > drivers/iio/proximity/as3935.c:231:6: error: ‘val’ may be used uninitialized > in this function

Re: [PATCH] iio: as3935: improve error reporting in as3935_event_work

2016-05-31 Thread Andrew F. Davis
On 05/30/2016 09:52 AM, Arnd Bergmann wrote: > gcc warns about a potentially uninitialized variable use > in as3935_event_work: > > drivers/iio/proximity/as3935.c: In function ‘as3935_event_work’: > drivers/iio/proximity/as3935.c:231:6: error: ‘val’ may be used uninitialized > in this function

Re: [PATCH] iio: as3935: improve error reporting in as3935_event_work

2016-05-30 Thread Matt Ranostay
Reviewed-by: Matt Ranostay On Mon, May 30, 2016 at 7:52 AM, Arnd Bergmann wrote: > gcc warns about a potentially uninitialized variable use > in as3935_event_work: > > drivers/iio/proximity/as3935.c: In function ‘as3935_event_work’: >

Re: [PATCH] iio: as3935: improve error reporting in as3935_event_work

2016-05-30 Thread Matt Ranostay
Reviewed-by: Matt Ranostay On Mon, May 30, 2016 at 7:52 AM, Arnd Bergmann wrote: > gcc warns about a potentially uninitialized variable use > in as3935_event_work: > > drivers/iio/proximity/as3935.c: In function ‘as3935_event_work’: > drivers/iio/proximity/as3935.c:231:6: error: ‘val’ may be