Re: [PATCH] irqchip/stm32-exti: map direct event to irq parent
On 7/17/20 2:37 PM, Marc Zyngier wrote:
On Fri, 10 Jul 2020 10:37:47 +0100,
Alexandre Torgue wrote:
Hi Marc,
On 7/10/20 11:31 AM, Marc Zyngier wrote:
Alexandre,
On Wed, 08 Jul 2020 05:57:24 +0100,
kernel test robot wrote:
[1 ]
Hi Alexandre,
I love your patch! Perhaps something to improve:
[auto build test WARNING on stm32/stm32-next]
[also build test WARNING on soc/for-next v5.8-rc4 next-20200707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Alexandre-Torgue/irqchip-stm32-exti-map-direct-event-to-irq-parent/20200706-161327
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
stm32-next
config: arm-randconfig-s031-20200707 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.2-31-gabbfd661-dirty
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
In file included from include/linux/build_bug.h:5,
from include/linux/bits.h:23,
from include/linux/bitops.h:5,
from drivers/irqchip/irq-stm32-exti.c:8:
drivers/irqchip/irq-stm32-exti.c: In function 'stm32_exti_h_domain_alloc':
drivers/irqchip/irq-stm32-exti.c:683:23: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]
683 | if (desc->irq_parent >= 0) {
| ^~
include/linux/compiler.h:58:52: note: in definition of macro
'__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond)
: __trace_if_value(cond))
|^~~~
drivers/irqchip/irq-stm32-exti.c:683:2: note: in expansion of macro 'if'
683 | if (desc->irq_parent >= 0) {
Do you plan to address this? Looks like an actual bug to me.
I'll fix it in v2, I was just waiting for other comments before
sending a v2. Do you prefer I send a v2 with this fix, and you'll do
your review on this v2 ?
I'm certainly not going to review something that has such a glaring
issue.
Ok, I'll then send v2 quickly.
M.
Re: [PATCH] irqchip/stm32-exti: map direct event to irq parent
On Fri, 10 Jul 2020 10:37:47 +0100,
Alexandre Torgue wrote:
>
> Hi Marc,
>
> On 7/10/20 11:31 AM, Marc Zyngier wrote:
> > Alexandre,
> >
> > On Wed, 08 Jul 2020 05:57:24 +0100,
> > kernel test robot wrote:
> >>
> >> [1 ]
> >> Hi Alexandre,
> >>
> >> I love your patch! Perhaps something to improve:
> >>
> >> [auto build test WARNING on stm32/stm32-next]
> >> [also build test WARNING on soc/for-next v5.8-rc4 next-20200707]
> >> [If your patch is applied to the wrong git tree, kindly drop us a note.
> >> And when submitting patch, we suggest to use as documented in
> >> https://git-scm.com/docs/git-format-patch]
> >>
> >> url:
> >> https://github.com/0day-ci/linux/commits/Alexandre-Torgue/irqchip-stm32-exti-map-direct-event-to-irq-parent/20200706-161327
> >> base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
> >> stm32-next
> >> config: arm-randconfig-s031-20200707 (attached as .config)
> >> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
> >> reproduce:
> >> wget
> >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> >> -O ~/bin/make.cross
> >> chmod +x ~/bin/make.cross
> >> # apt-get install sparse
> >> # sparse version: v0.6.2-31-gabbfd661-dirty
> >> # save the attached .config to linux build tree
> >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
> >> C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm
> >>
> >> If you fix the issue, kindly add following tag as appropriate
> >> Reported-by: kernel test robot
> >>
> >> All warnings (new ones prefixed by >>):
> >>
> >> In file included from include/linux/build_bug.h:5,
> >> from include/linux/bits.h:23,
> >> from include/linux/bitops.h:5,
> >> from drivers/irqchip/irq-stm32-exti.c:8:
> >> drivers/irqchip/irq-stm32-exti.c: In function
> >> 'stm32_exti_h_domain_alloc':
> >> drivers/irqchip/irq-stm32-exti.c:683:23: warning: comparison of
> >> unsigned expression >= 0 is always true [-Wtype-limits]
> >> 683 | if (desc->irq_parent >= 0) {
> >> | ^~
> >> include/linux/compiler.h:58:52: note: in definition of macro
> >> '__trace_if_var'
> >>58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ?
> >> (cond) : __trace_if_value(cond))
> >> |^~~~
> drivers/irqchip/irq-stm32-exti.c:683:2: note: in expansion of macro 'if'
> >> 683 | if (desc->irq_parent >= 0) {
> >
> > Do you plan to address this? Looks like an actual bug to me.
>
> I'll fix it in v2, I was just waiting for other comments before
> sending a v2. Do you prefer I send a v2 with this fix, and you'll do
> your review on this v2 ?
I'm certainly not going to review something that has such a glaring
issue.
M.
--
Without deviation from the norm, progress is not possible.
Re: [PATCH] irqchip/stm32-exti: map direct event to irq parent
Hi Marc,
On 7/10/20 11:31 AM, Marc Zyngier wrote:
Alexandre,
On Wed, 08 Jul 2020 05:57:24 +0100,
kernel test robot wrote:
[1 ]
Hi Alexandre,
I love your patch! Perhaps something to improve:
[auto build test WARNING on stm32/stm32-next]
[also build test WARNING on soc/for-next v5.8-rc4 next-20200707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Alexandre-Torgue/irqchip-stm32-exti-map-direct-event-to-irq-parent/20200706-161327
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
stm32-next
config: arm-randconfig-s031-20200707 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.2-31-gabbfd661-dirty
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
In file included from include/linux/build_bug.h:5,
from include/linux/bits.h:23,
from include/linux/bitops.h:5,
from drivers/irqchip/irq-stm32-exti.c:8:
drivers/irqchip/irq-stm32-exti.c: In function 'stm32_exti_h_domain_alloc':
drivers/irqchip/irq-stm32-exti.c:683:23: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]
683 | if (desc->irq_parent >= 0) {
| ^~
include/linux/compiler.h:58:52: note: in definition of macro
'__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) :
__trace_if_value(cond))
|^~~~
drivers/irqchip/irq-stm32-exti.c:683:2: note: in expansion of macro 'if'
683 | if (desc->irq_parent >= 0) {
Do you plan to address this? Looks like an actual bug to me.
I'll fix it in v2, I was just waiting for other comments before sending
a v2. Do you prefer I send a v2 with this fix, and you'll do your review
on this v2 ?
regards
alex
M.
Re: [PATCH] irqchip/stm32-exti: map direct event to irq parent
Alexandre,
On Wed, 08 Jul 2020 05:57:24 +0100,
kernel test robot wrote:
>
> [1 ]
> Hi Alexandre,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on stm32/stm32-next]
> [also build test WARNING on soc/for-next v5.8-rc4 next-20200707]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:
> https://github.com/0day-ci/linux/commits/Alexandre-Torgue/irqchip-stm32-exti-map-direct-event-to-irq-parent/20200706-161327
> base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
> stm32-next
> config: arm-randconfig-s031-20200707 (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
> reproduce:
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
> ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # apt-get install sparse
> # sparse version: v0.6.2-31-gabbfd661-dirty
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1
> CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot
>
> All warnings (new ones prefixed by >>):
>
>In file included from include/linux/build_bug.h:5,
> from include/linux/bits.h:23,
> from include/linux/bitops.h:5,
> from drivers/irqchip/irq-stm32-exti.c:8:
>drivers/irqchip/irq-stm32-exti.c: In function 'stm32_exti_h_domain_alloc':
>drivers/irqchip/irq-stm32-exti.c:683:23: warning: comparison of unsigned
> expression >= 0 is always true [-Wtype-limits]
> 683 | if (desc->irq_parent >= 0) {
> | ^~
>include/linux/compiler.h:58:52: note: in definition of macro
> '__trace_if_var'
> 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond)
> : __trace_if_value(cond))
> |^~~~
> >> drivers/irqchip/irq-stm32-exti.c:683:2: note: in expansion of macro 'if'
> 683 | if (desc->irq_parent >= 0) {
Do you plan to address this? Looks like an actual bug to me.
M.
--
Without deviation from the norm, progress is not possible.
Re: [PATCH] irqchip/stm32-exti: map direct event to irq parent
Hi Alexandre,
I love your patch! Perhaps something to improve:
[auto build test WARNING on stm32/stm32-next]
[also build test WARNING on soc/for-next v5.8-rc4 next-20200707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Alexandre-Torgue/irqchip-stm32-exti-map-direct-event-to-irq-parent/20200706-161327
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
stm32-next
config: arm-randconfig-s031-20200707 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.2-31-gabbfd661-dirty
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
In file included from include/linux/build_bug.h:5,
from include/linux/bits.h:23,
from include/linux/bitops.h:5,
from drivers/irqchip/irq-stm32-exti.c:8:
drivers/irqchip/irq-stm32-exti.c: In function 'stm32_exti_h_domain_alloc':
drivers/irqchip/irq-stm32-exti.c:683:23: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]
683 | if (desc->irq_parent >= 0) {
| ^~
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) :
__trace_if_value(cond))
|^~~~
>> drivers/irqchip/irq-stm32-exti.c:683:2: note: in expansion of macro 'if'
683 | if (desc->irq_parent >= 0) {
| ^~
drivers/irqchip/irq-stm32-exti.c:683:23: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]
683 | if (desc->irq_parent >= 0) {
| ^~
include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) :
__trace_if_value(cond))
| ^~~~
>> drivers/irqchip/irq-stm32-exti.c:683:2: note: in expansion of macro 'if'
683 | if (desc->irq_parent >= 0) {
| ^~
drivers/irqchip/irq-stm32-exti.c:683:23: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]
683 | if (desc->irq_parent >= 0) {
| ^~
include/linux/compiler.h:69:3: note: in definition of macro
'__trace_if_value'
69 | (cond) ? \
| ^~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__)
) )
|^~
>> drivers/irqchip/irq-stm32-exti.c:683:2: note: in expansion of macro 'if'
683 | if (desc->irq_parent >= 0) {
| ^~
vim +/if +683 drivers/irqchip/irq-stm32-exti.c
659
660 static int stm32_exti_h_domain_alloc(struct irq_domain *dm,
661 unsigned int virq,
662 unsigned int nr_irqs, void *data)
663 {
664 struct stm32_exti_host_data *host_data = dm->host_data;
665 struct stm32_exti_chip_data *chip_data;
666 const struct stm32_desc_irq *desc;
667 struct irq_fwspec *fwspec = data;
668 struct irq_fwspec p_fwspec;
669 irq_hw_number_t hwirq;
670 int bank;
671
672 hwirq = fwspec->param[0];
673 bank = hwirq / IRQS_PER_BANK;
674 chip_data = &host_data->chips_data[bank];
675
676
677 desc = stm32_exti_get_desc(host_data->drv_data, hwirq);
678 if (!desc)
679 return -EINVAL;
680
681 irq_domain_set_hwirq_and_chip(dm, virq, hwirq, desc->chip,
682chip_data);
> 683 if (desc->irq_parent >= 0) {
684 p_fwspec.fwnode = dm->parent->fwnode;
685 p_fwspec.param_count = 3;
686 p_fwspec.param[0] = GIC_SPI;
687 p_fwspec.param[1] = desc->irq_parent;
688 p_fwspec.param[2] = IRQ_TYPE_LEVEL_HIGH;
689
690 return irq_domain_alloc_irqs_parent(dm, virq, 1,
&p_fwspec);
691 }
692
693 return 0;
694 }
695
---
0-DAY CI Kernel Test Service
