Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 14:55 +0200, Paul Bolle wrote: > On Thu, 2016-10-13 at 15:44 +0300, Luca Coelho wrote: > >  Even though there is apparently something wrong with this part of the > > ACPI table on you laptop, since it doesn't match our specifications. > >  In any case, it's mostly harmless. >

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 14:55 +0200, Paul Bolle wrote: > On Thu, 2016-10-13 at 15:44 +0300, Luca Coelho wrote: > >  Even though there is apparently something wrong with this part of the > > ACPI table on you laptop, since it doesn't match our specifications. > >  In any case, it's mostly harmless. >

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 08:56 -0500, Chris Rorvick wrote: > Hi Luca, > > > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > > Could you please give this a spin? I have tested it with some handmade > > ACPI tables in QEMU and it seems to work fine now. > > > Tested-by: Chris Rorvick

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 08:56 -0500, Chris Rorvick wrote: > Hi Luca, > > > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > > Could you please give this a spin? I have tested it with some handmade > > ACPI tables in QEMU and it seems to work fine now. > > > Tested-by: Chris Rorvick > > I

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Chris Rorvick
Hi Luca, > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Chris Rorvick I think the debug output looks as expected, see below for

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Chris Rorvick
Hi Luca, > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Chris Rorvick I think the debug output looks as expected, see below for the first 20 lines

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
On Thu, 2016-10-13 at 15:44 +0300, Luca Coelho wrote: >  Even though there is apparently something wrong with this part of the > ACPI table on you laptop, since it doesn't match our specifications. >  In any case, it's mostly harmless. Would a correct implementation by Dell have any benefits for

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
On Thu, 2016-10-13 at 15:44 +0300, Luca Coelho wrote: >  Even though there is apparently something wrong with this part of the > ACPI table on you laptop, since it doesn't match our specifications. >  In any case, it's mostly harmless. Would a correct implementation by Dell have any benefits for

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 14:36 +0200, Paul Bolle wrote: > On Thu, 2016-10-13 at 14:30 +0300, Luca Coelho wrote: > > I forgot to say... could you load the iwlwifi module with debug=0x01 > > (module parameter), so we can see the messages the driver is printing > > when it doesn't find a proper

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 14:36 +0200, Paul Bolle wrote: > On Thu, 2016-10-13 at 14:30 +0300, Luca Coelho wrote: > > I forgot to say... could you load the iwlwifi module with debug=0x01 > > (module parameter), so we can see the messages the driver is printing > > when it doesn't find a proper

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
On Thu, 2016-10-13 at 14:30 +0300, Luca Coelho wrote: > I forgot to say... could you load the iwlwifi module with debug=0x01 > (module parameter), so we can see the messages the driver is printing > when it doesn't find a proper structure? That makes a lot of noise! Here's the first 100 lines or

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
On Thu, 2016-10-13 at 14:30 +0300, Luca Coelho wrote: > I forgot to say... could you load the iwlwifi module with debug=0x01 > (module parameter), so we can see the messages the driver is printing > when it doesn't find a proper structure? That makes a lot of noise! Here's the first 100 lines or

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 13:27 +0200, Paul Bolle wrote: > Luca, > > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > > Could you please give this a spin? I have tested it with some handmade > > ACPI tables in QEMU and it seems to work fine now. > > > Tested-by: Paul Bolle

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 13:27 +0200, Paul Bolle wrote: > Luca, > > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > > Could you please give this a spin? I have tested it with some handmade > > ACPI tables in QEMU and it seems to work fine now. > > > Tested-by: Paul Bolle > > Not that

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
Luca, On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Paul Bolle Not that this test was worth a lot: it builds cleanly (on top of

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
Luca, On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Paul Bolle Not that this test was worth a lot: it builds cleanly (on top of 4.8.1), the error at