Re: [PATCH] kbuild: Require W=1 for -Wimplicit-fallthrough with clang

2019-08-15 Thread Miguel Ojeda
On Fri, Aug 16, 2019 at 1:05 AM Nick Desaulniers wrote: > > On Thu, Aug 15, 2019 at 3:59 PM Miguel Ojeda > wrote: > > > > On Thu, Aug 15, 2019 at 10:45 PM Nathan Chancellor > > wrote: > > > * Revert commit bfd77145f35c ("Makefile: Convert -Wimplicit-fallthrough=3 > > > to just -Wimplicit-fallthr

Re: [PATCH] kbuild: Require W=1 for -Wimplicit-fallthrough with clang

2019-08-15 Thread Nick Desaulniers
On Thu, Aug 15, 2019 at 3:59 PM Miguel Ojeda wrote: > > On Thu, Aug 15, 2019 at 10:45 PM Nathan Chancellor > wrote: > > * Revert commit bfd77145f35c ("Makefile: Convert -Wimplicit-fallthrough=3 > > to just -Wimplicit-fallthrough for clang") for the time being and just > > rely on adding -Wimplici

Re: [PATCH] kbuild: Require W=1 for -Wimplicit-fallthrough with clang

2019-08-15 Thread Miguel Ojeda
On Thu, Aug 15, 2019 at 10:45 PM Nathan Chancellor wrote: > > I am still not a huge fan of the CONFIG_CC_IS_CLANG ifdefs but I don't > really see a much cleaner way to get around this. Some that come to > mind: Yeah... > * Revert commit bfd77145f35c ("Makefile: Convert -Wimplicit-fallthrough=3 >

Re: [PATCH] kbuild: Require W=1 for -Wimplicit-fallthrough with clang

2019-08-15 Thread Nick Desaulniers
On Thu, Aug 15, 2019 at 1:45 PM Nathan Chancellor wrote: > > On Thu, Aug 15, 2019 at 11:20:29AM -0700, 'Nathan Huckleberry' via Clang > Built Linux wrote: > > Clang is updating to support -Wimplicit-fallthrough on C > > https://reviews.llvm.org/D64838. Since clang does not > > support the comment

Re: [PATCH] kbuild: Require W=1 for -Wimplicit-fallthrough with clang

2019-08-15 Thread Nathan Chancellor
On Thu, Aug 15, 2019 at 11:20:29AM -0700, 'Nathan Huckleberry' via Clang Built Linux wrote: > Clang is updating to support -Wimplicit-fallthrough on C > https://reviews.llvm.org/D64838. Since clang does not > support the comment version of fallthrough annotations > this update causes an additional