Re: [PATCH] kbuild: check for pkg-config on make menu/n/g/xconfig

2018-03-12 Thread Randy Dunlap
On 03/11/2018 02:00 PM, Bjørn Forsman wrote: > On 11 March 2018 at 21:12, Randy Dunlap wrote: >> +pkgcfg=`which pkg-config >/dev/null 2>&1` > > Please use "command -v" instead of "which". command -v is in POSIX, so > the shell will have it for sure (builtin). which is not a builtin, it > is an ex

Re: [PATCH] kbuild: check for pkg-config on make menu/n/g/xconfig

2018-03-11 Thread Bjørn Forsman
On 11 March 2018 at 21:12, Randy Dunlap wrote: > +pkgcfg=`which pkg-config >/dev/null 2>&1` Please use "command -v" instead of "which". command -v is in POSIX, so the shell will have it for sure (builtin). which is not a builtin, it is an external command that may or may not be installed on the s