Re: [PATCH] kernel: event: core: Change return type to vm_fault_t

2018-05-17 Thread Souptick Joarder
On Thu, May 10, 2018 at 7:54 PM, Souptick Joarder wrote: > On Fri, Apr 20, 2018 at 5:18 PM, Souptick Joarder > wrote: >>> I'm fine with the patch, but shouldn't this be part of a larger series / >>> cocinelle script? >>> >> >> This one is trivial but

Re: [PATCH] kernel: event: core: Change return type to vm_fault_t

2018-05-17 Thread Souptick Joarder
On Thu, May 10, 2018 at 7:54 PM, Souptick Joarder wrote: > On Fri, Apr 20, 2018 at 5:18 PM, Souptick Joarder > wrote: >>> I'm fine with the patch, but shouldn't this be part of a larger series / >>> cocinelle script? >>> >> >> This one is trivial but many others are not. >> As part of this

Re: [PATCH] kernel: event: core: Change return type to vm_fault_t

2018-05-17 Thread Peter Zijlstra
On Thu, May 17, 2018 at 07:55:13PM +0530, Souptick Joarder wrote: > On Thu, May 10, 2018 at 7:54 PM, Souptick Joarder > wrote: > > On Fri, Apr 20, 2018 at 5:18 PM, Souptick Joarder > > wrote: > >>> I'm fine with the patch, but shouldn't this be part

Re: [PATCH] kernel: event: core: Change return type to vm_fault_t

2018-05-17 Thread Peter Zijlstra
On Thu, May 17, 2018 at 07:55:13PM +0530, Souptick Joarder wrote: > On Thu, May 10, 2018 at 7:54 PM, Souptick Joarder > wrote: > > On Fri, Apr 20, 2018 at 5:18 PM, Souptick Joarder > > wrote: > >>> I'm fine with the patch, but shouldn't this be part of a larger series / > >>> cocinelle script?

Re: [PATCH] kernel: event: core: Change return type to vm_fault_t

2018-05-10 Thread Souptick Joarder
On Fri, Apr 20, 2018 at 5:18 PM, Souptick Joarder wrote: >> I'm fine with the patch, but shouldn't this be part of a larger series / >> cocinelle script? >> > > This one is trivial but many others are not. > As part of this clean up we have fixed many > existing bugs in

Re: [PATCH] kernel: event: core: Change return type to vm_fault_t

2018-05-10 Thread Souptick Joarder
On Fri, Apr 20, 2018 at 5:18 PM, Souptick Joarder wrote: >> I'm fine with the patch, but shouldn't this be part of a larger series / >> cocinelle script? >> > > This one is trivial but many others are not. > As part of this clean up we have fixed many > existing bugs in fault handlers of drivers/

Re: [PATCH] kernel: event: core: Change return type to vm_fault_t

2018-04-20 Thread Souptick Joarder
> I'm fine with the patch, but shouldn't this be part of a larger series / > cocinelle script? > This one is trivial but many others are not. As part of this clean up we have fixed many existing bugs in fault handlers of drivers/ file systems. Also we are replacing existing vm_insert_foo() with

Re: [PATCH] kernel: event: core: Change return type to vm_fault_t

2018-04-20 Thread Souptick Joarder
> I'm fine with the patch, but shouldn't this be part of a larger series / > cocinelle script? > This one is trivial but many others are not. As part of this clean up we have fixed many existing bugs in fault handlers of drivers/ file systems. Also we are replacing existing vm_insert_foo() with

Re: [PATCH] kernel: event: core: Change return type to vm_fault_t

2018-04-20 Thread Peter Zijlstra
On Sun, Apr 15, 2018 at 01:58:31AM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler and > page_mkwrite handler in struct vm_operations_struct. > > Signed-off-by: Souptick Joarder > Reviewed-by: Matthew Wilcox > --- >

Re: [PATCH] kernel: event: core: Change return type to vm_fault_t

2018-04-20 Thread Peter Zijlstra
On Sun, Apr 15, 2018 at 01:58:31AM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler and > page_mkwrite handler in struct vm_operations_struct. > > Signed-off-by: Souptick Joarder > Reviewed-by: Matthew Wilcox > --- > kernel/events/core.c | 4 ++-- > 1 file