Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-13 Thread Alexey Dobriyan
On Tue, Feb 13, 2018 at 07:18:08PM +0200, Andy Shevchenko wrote: > On Tue, Feb 13, 2018 at 7:11 PM, Alexey Dobriyan wrote: > > On Tue, Feb 13, 2018 at 06:02:27PM +0200, Andy Shevchenko wrote: > >> On Sat, Feb 10, 2018 at 11:11 PM, Alexey Dobriyan > >>

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-13 Thread Alexey Dobriyan
On Tue, Feb 13, 2018 at 07:18:08PM +0200, Andy Shevchenko wrote: > On Tue, Feb 13, 2018 at 7:11 PM, Alexey Dobriyan wrote: > > On Tue, Feb 13, 2018 at 06:02:27PM +0200, Andy Shevchenko wrote: > >> On Sat, Feb 10, 2018 at 11:11 PM, Alexey Dobriyan > >> wrote: > >> > Once upon a time module

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-13 Thread Alexey Dobriyan
On Mon, Feb 12, 2018 at 09:03:06AM -0800, Kees Cook wrote: > On Mon, Feb 12, 2018 at 3:58 AM, Alexey Dobriyan wrote: > > On Sun, Feb 11, 2018 at 01:27:58PM -0800, Kees Cook wrote: > >> On Sat, Feb 10, 2018 at 1:11 PM, Alexey Dobriyan > >> wrote: > >> >

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-13 Thread Alexey Dobriyan
On Mon, Feb 12, 2018 at 09:03:06AM -0800, Kees Cook wrote: > On Mon, Feb 12, 2018 at 3:58 AM, Alexey Dobriyan wrote: > > On Sun, Feb 11, 2018 at 01:27:58PM -0800, Kees Cook wrote: > >> On Sat, Feb 10, 2018 at 1:11 PM, Alexey Dobriyan > >> wrote: > >> > Once upon a time module parameter parsing

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-13 Thread Andy Shevchenko
On Tue, Feb 13, 2018 at 7:11 PM, Alexey Dobriyan wrote: > On Tue, Feb 13, 2018 at 06:02:27PM +0200, Andy Shevchenko wrote: >> On Sat, Feb 10, 2018 at 11:11 PM, Alexey Dobriyan >> wrote: >> > Once upon a time module parameter parsing code accepted >> >

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-13 Thread Andy Shevchenko
On Tue, Feb 13, 2018 at 7:11 PM, Alexey Dobriyan wrote: > On Tue, Feb 13, 2018 at 06:02:27PM +0200, Andy Shevchenko wrote: >> On Sat, Feb 10, 2018 at 11:11 PM, Alexey Dobriyan >> wrote: >> > Once upon a time module parameter parsing code accepted >> > 0, 1, y, n, Y and N for boolean values.

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-13 Thread Alexey Dobriyan
On Tue, Feb 13, 2018 at 06:02:27PM +0200, Andy Shevchenko wrote: > On Sat, Feb 10, 2018 at 11:11 PM, Alexey Dobriyan wrote: > > Once upon a time module parameter parsing code accepted > > 0, 1, y, n, Y and N for boolean values. Gratituous but contained > > to module code and

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-13 Thread Alexey Dobriyan
On Tue, Feb 13, 2018 at 06:02:27PM +0200, Andy Shevchenko wrote: > On Sat, Feb 10, 2018 at 11:11 PM, Alexey Dobriyan wrote: > > Once upon a time module parameter parsing code accepted > > 0, 1, y, n, Y and N for boolean values. Gratituous but contained > > to module code and thus tolerable. > > >

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-13 Thread Andy Shevchenko
On Sat, Feb 10, 2018 at 11:11 PM, Alexey Dobriyan wrote: > Once upon a time module parameter parsing code accepted > 0, 1, y, n, Y and N for boolean values. Gratituous but contained > to module code and thus tolerable. > > Commit ef951599074ba4fad2d0efa0a977129b41e6d203 >

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-13 Thread Andy Shevchenko
On Sat, Feb 10, 2018 at 11:11 PM, Alexey Dobriyan wrote: > Once upon a time module parameter parsing code accepted > 0, 1, y, n, Y and N for boolean values. Gratituous but contained > to module code and thus tolerable. > > Commit ef951599074ba4fad2d0efa0a977129b41e6d203 > ("lib: move strtobool()

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-12 Thread Kees Cook
On Mon, Feb 12, 2018 at 3:58 AM, Alexey Dobriyan wrote: > On Sun, Feb 11, 2018 at 01:27:58PM -0800, Kees Cook wrote: >> On Sat, Feb 10, 2018 at 1:11 PM, Alexey Dobriyan wrote: >> > Once upon a time module parameter parsing code accepted >> > 0, 1, y, n,

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-12 Thread Kees Cook
On Mon, Feb 12, 2018 at 3:58 AM, Alexey Dobriyan wrote: > On Sun, Feb 11, 2018 at 01:27:58PM -0800, Kees Cook wrote: >> On Sat, Feb 10, 2018 at 1:11 PM, Alexey Dobriyan wrote: >> > Once upon a time module parameter parsing code accepted >> > 0, 1, y, n, Y and N for boolean values. Gratituous but

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-12 Thread Alexey Dobriyan
On Sun, Feb 11, 2018 at 01:27:58PM -0800, Kees Cook wrote: > On Sat, Feb 10, 2018 at 1:11 PM, Alexey Dobriyan wrote: > > Once upon a time module parameter parsing code accepted > > 0, 1, y, n, Y and N for boolean values. Gratituous but contained > > to module code and thus

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-12 Thread Alexey Dobriyan
On Sun, Feb 11, 2018 at 01:27:58PM -0800, Kees Cook wrote: > On Sat, Feb 10, 2018 at 1:11 PM, Alexey Dobriyan wrote: > > Once upon a time module parameter parsing code accepted > > 0, 1, y, n, Y and N for boolean values. Gratituous but contained > > to module code and thus tolerable. > > And

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-11 Thread Kees Cook
On Sat, Feb 10, 2018 at 1:11 PM, Alexey Dobriyan wrote: > Once upon a time module parameter parsing code accepted > 0, 1, y, n, Y and N for boolean values. Gratituous but contained > to module code and thus tolerable. And kernel command line. > Commit

Re: [PATCH] kstrtox: make kstrtobool_from_user() very strict

2018-02-11 Thread Kees Cook
On Sat, Feb 10, 2018 at 1:11 PM, Alexey Dobriyan wrote: > Once upon a time module parameter parsing code accepted > 0, 1, y, n, Y and N for boolean values. Gratituous but contained > to module code and thus tolerable. And kernel command line. > Commit ef951599074ba4fad2d0efa0a977129b41e6d203 >