Re: [PATCH] kvmppc: Implement H_LOGICAL_CI_{LOAD,STORE} in KVM

2015-02-02 Thread David Gibson 
On Mon, Feb 02, 2015 at 09:59:16AM +0100, Paolo Bonzini wrote:
> 
> 
> On 02/02/2015 08:45, David Gibson wrote:
> > +   case H_LOGICAL_CI_LOAD:
> > +   ret = kvmppc_h_logical_ci_load(vcpu);
> > +   if (ret == H_TOO_HARD) {
> > +   printk("Punting H_LOGICAL_CI_LOAD\n");
> > +   return RESUME_HOST;
> > +   }
> > +   break;
> > +   case H_LOGICAL_CI_STORE:
> > +   ret = kvmppc_h_logical_ci_store(vcpu);
> > +   if (ret == H_TOO_HARD) {
> > +   printk("Punting H_LOGICAL_CI_STORE\n");
> > +   return RESUME_HOST;
> > +   }
> > +   break;
> > case H_SET_MODE:
> > ret = kvmppc_h_set_mode(vcpu, kvmppc_get_gpr(vcpu, 4),
> > kvmppc_get_gpr(vcpu, 5),
> 
> KERN_DEBUG I guess?  Or even no printk at all perhaps.

Oh, bugger, removed most of the debug code, but not all of it.

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


pgpm80fmKY_Fo.pgp
Description: PGP signature

Re: [PATCH] kvmppc: Implement H_LOGICAL_CI_{LOAD,STORE} in KVM

2015-02-02 Thread Paolo Bonzini 


On 02/02/2015 08:45, David Gibson wrote:
> + case H_LOGICAL_CI_LOAD:
> + ret = kvmppc_h_logical_ci_load(vcpu);
> + if (ret == H_TOO_HARD) {
> + printk("Punting H_LOGICAL_CI_LOAD\n");
> + return RESUME_HOST;
> + }
> + break;
> + case H_LOGICAL_CI_STORE:
> + ret = kvmppc_h_logical_ci_store(vcpu);
> + if (ret == H_TOO_HARD) {
> + printk("Punting H_LOGICAL_CI_STORE\n");
> + return RESUME_HOST;
> + }
> + break;
>   case H_SET_MODE:
>   ret = kvmppc_h_set_mode(vcpu, kvmppc_get_gpr(vcpu, 4),
>   kvmppc_get_gpr(vcpu, 5),

KERN_DEBUG I guess?  Or even no printk at all perhaps.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] kvmppc: Implement H_LOGICAL_CI_{LOAD,STORE} in KVM

2015-02-02 Thread Paolo Bonzini 


On 02/02/2015 08:45, David Gibson wrote:
 + case H_LOGICAL_CI_LOAD:
 + ret = kvmppc_h_logical_ci_load(vcpu);
 + if (ret == H_TOO_HARD) {
 + printk(Punting H_LOGICAL_CI_LOAD\n);
 + return RESUME_HOST;
 + }
 + break;
 + case H_LOGICAL_CI_STORE:
 + ret = kvmppc_h_logical_ci_store(vcpu);
 + if (ret == H_TOO_HARD) {
 + printk(Punting H_LOGICAL_CI_STORE\n);
 + return RESUME_HOST;
 + }
 + break;
   case H_SET_MODE:
   ret = kvmppc_h_set_mode(vcpu, kvmppc_get_gpr(vcpu, 4),
   kvmppc_get_gpr(vcpu, 5),

KERN_DEBUG I guess?  Or even no printk at all perhaps.

Paolo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] kvmppc: Implement H_LOGICAL_CI_{LOAD,STORE} in KVM

2015-02-02 Thread David Gibson 
On Mon, Feb 02, 2015 at 09:59:16AM +0100, Paolo Bonzini wrote:
 
 
 On 02/02/2015 08:45, David Gibson wrote:
  +   case H_LOGICAL_CI_LOAD:
  +   ret = kvmppc_h_logical_ci_load(vcpu);
  +   if (ret == H_TOO_HARD) {
  +   printk(Punting H_LOGICAL_CI_LOAD\n);
  +   return RESUME_HOST;
  +   }
  +   break;
  +   case H_LOGICAL_CI_STORE:
  +   ret = kvmppc_h_logical_ci_store(vcpu);
  +   if (ret == H_TOO_HARD) {
  +   printk(Punting H_LOGICAL_CI_STORE\n);
  +   return RESUME_HOST;
  +   }
  +   break;
  case H_SET_MODE:
  ret = kvmppc_h_set_mode(vcpu, kvmppc_get_gpr(vcpu, 4),
  kvmppc_get_gpr(vcpu, 5),
 
 KERN_DEBUG I guess?  Or even no printk at all perhaps.

Oh, bugger, removed most of the debug code, but not all of it.

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


pgpm80fmKY_Fo.pgp
Description: PGP signature