Re: [PATCH] l2tp: Add protocol field decompression

2018-12-16 Thread Guillaume Nault
On Sun, Dec 16, 2018 at 08:36:42PM +0200, Sam Protsenko wrote: > Hi Guillaume, > > On Sun, Dec 16, 2018 at 6:29 PM Guillaume Nault wrote: > > > > If you all agree, can we please revert this patch and properly > > implement PFC in ppp_generic.c? > > How about instead of reverting I will try to

Re: [PATCH] l2tp: Add protocol field decompression

2018-12-16 Thread Sam Protsenko
Hi Guillaume, On Sun, Dec 16, 2018 at 6:29 PM Guillaume Nault wrote: > > On Fri, Dec 14, 2018 at 07:59:21PM +0200, Sam Protsenko wrote: > > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > > in PPP packet will be received without leading 0x00. See section 6.5 in > > RFC

Re: [PATCH] l2tp: Add protocol field decompression

2018-12-16 Thread Guillaume Nault
On Fri, Dec 14, 2018 at 07:59:21PM +0200, Sam Protsenko wrote: > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > in PPP packet will be received without leading 0x00. See section 6.5 in > RFC 1661 for details. So let's decompress protocol field if needed, the > same way

Re: [PATCH] l2tp: Add protocol field decompression

2018-12-15 Thread David Miller
From: Sam Protsenko Date: Fri, 14 Dec 2018 19:59:21 +0200 > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > in PPP packet will be received without leading 0x00. See section 6.5 in > RFC 1661 for details. So let's decompress protocol field if needed, the > same way it's