Re: [PATCH] lightnvm: pblk: remove unused variable

[Javier Gonzalez]

> On 26 Feb 2018, at 19.20, Matias Bjørling  wrote:
> 
> On 02/26/2018 02:18 PM, Javier González wrote:
>> Remove unused variable after a previous cleanup (a8112b631adb)
>> Signed-off-by: Javier González 
>> ---
>>  drivers/lightnvm/pblk-core.c | 3 ---
>>  1 file changed, 3 deletions(-)
>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>> index ce6a7cfdba66..e6cb4317bb50 100644
>> --- a/drivers/lightnvm/pblk-core.c
>> +++ b/drivers/lightnvm/pblk-core.c
>> @@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct 
>> pblk_line *line,
>>  struct nvm_geo *geo = >geo;
>>  struct pblk_line_meta *lm = >lm;
>>  struct pblk_line_mgmt *l_mg = >l_mg;
>> -int nr_bb = 0;
>>  u64 off;
>>  int bit = -1;
>>  int emeta_secs;
>> @@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct 
>> pblk_line *line,
>>  bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
>>  lm->sec_per_line);
>>  line->sec_in_line -= geo->c.clba;
>> -if (bit >= lm->emeta_bb)
>> -nr_bb++;
>>  }
>>  /* Mark smeta metadata sectors as bad sectors */
> 
> Should Fixes be added?

It's not a bug as such, that's why I didn't add it. But be welcome to do
so if you think it's better.


signature.asc
Description: Message signed with OpenPGP

Re: [PATCH] lightnvm: pblk: remove unused variable

[Javier Gonzalez]

> On 26 Feb 2018, at 19.20, Matias Bjørling  wrote:
> 
> On 02/26/2018 02:18 PM, Javier González wrote:
>> Remove unused variable after a previous cleanup (a8112b631adb)
>> Signed-off-by: Javier González 
>> ---
>>  drivers/lightnvm/pblk-core.c | 3 ---
>>  1 file changed, 3 deletions(-)
>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>> index ce6a7cfdba66..e6cb4317bb50 100644
>> --- a/drivers/lightnvm/pblk-core.c
>> +++ b/drivers/lightnvm/pblk-core.c
>> @@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct 
>> pblk_line *line,
>>  struct nvm_geo *geo = >geo;
>>  struct pblk_line_meta *lm = >lm;
>>  struct pblk_line_mgmt *l_mg = >l_mg;
>> -int nr_bb = 0;
>>  u64 off;
>>  int bit = -1;
>>  int emeta_secs;
>> @@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct 
>> pblk_line *line,
>>  bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
>>  lm->sec_per_line);
>>  line->sec_in_line -= geo->c.clba;
>> -if (bit >= lm->emeta_bb)
>> -nr_bb++;
>>  }
>>  /* Mark smeta metadata sectors as bad sectors */
> 
> Should Fixes be added?

It's not a bug as such, that's why I didn't add it. But be welcome to do
so if you think it's better.


signature.asc
Description: Message signed with OpenPGP

Re: [PATCH] lightnvm: pblk: remove unused variable

[Matias Bjørling]

On 02/26/2018 02:18 PM, Javier González wrote:

Remove unused variable after a previous cleanup (a8112b631adb)

Signed-off-by: Javier González 
---
  drivers/lightnvm/pblk-core.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index ce6a7cfdba66..e6cb4317bb50 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct 
pblk_line *line,
struct nvm_geo *geo = >geo;
struct pblk_line_meta *lm = >lm;
struct pblk_line_mgmt *l_mg = >l_mg;
-   int nr_bb = 0;
u64 off;
int bit = -1;
int emeta_secs;
@@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct 
pblk_line *line,
bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
lm->sec_per_line);
line->sec_in_line -= geo->c.clba;
-   if (bit >= lm->emeta_bb)
-   nr_bb++;
}
  
  	/* Mark smeta metadata sectors as bad sectors */




Should Fixes be added?

Re: [PATCH] lightnvm: pblk: remove unused variable

[Matias Bjørling]

On 02/26/2018 02:18 PM, Javier González wrote:

Remove unused variable after a previous cleanup (a8112b631adb)

Signed-off-by: Javier González 
---
  drivers/lightnvm/pblk-core.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index ce6a7cfdba66..e6cb4317bb50 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct 
pblk_line *line,
struct nvm_geo *geo = >geo;
struct pblk_line_meta *lm = >lm;
struct pblk_line_mgmt *l_mg = >l_mg;
-   int nr_bb = 0;
u64 off;
int bit = -1;
int emeta_secs;
@@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct 
pblk_line *line,
bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
lm->sec_per_line);
line->sec_in_line -= geo->c.clba;
-   if (bit >= lm->emeta_bb)
-   nr_bb++;
}
  
  	/* Mark smeta metadata sectors as bad sectors */




Should Fixes be added?