Re: [PATCH] mbcache: Speed up cache entry creation

2019-07-25 Thread Andreas Dilger
On Jul 23, 2019, at 10:01 PM, Sultan Alsawaf wrote: > > On Tue, Jul 23, 2019 at 10:56:05AM -0600, Andreas Dilger wrote: >> Do you have any kind of performance metrics that show this is an actual >> improvement in performance? This would be either macro-level benchmarks >> (e.g. fio, but this

Re: [PATCH] mbcache: Speed up cache entry creation

2019-07-23 Thread Sultan Alsawaf
On Tue, Jul 23, 2019 at 10:56:05AM -0600, Andreas Dilger wrote: > Do you have any kind of performance metrics that show this is an actual > improvement in performance? This would be either macro-level benchmarks > (e.g. fio, but this seems unlikely to show any benefit), or micro-level >

Re: [PATCH] mbcache: Speed up cache entry creation

2019-07-23 Thread Andreas Dilger
On Jul 22, 2019, at 11:35 PM, Sultan Alsawaf wrote: > > From: Sultan Alsawaf > > In order to prevent redundant entry creation by racing against itself, > mb_cache_entry_create scans through a hash-list of all current entries > in order to see if another allocation for the requested new entry