Re: [PATCH] mdio_bus: fix devm_mdiobus_alloc_size export
From: Arnd Bergmann Date: Thu, 8 May 2014 16:46:52 +0200 > commit 6d48f44b7b2 "mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free" > introduced a new function devm_mdiobus_alloc_size() but added an export > for a different function devm_mdiobus_alloc(), which was obviously > a simple mistake that leads to build error whenever this function is > used from a loadable module: > > ERROR: "devm_mdiobus_alloc_size" [drivers/net/ethernet/ti/davinci_mdio.ko] > undefined! > > Signed-off-by: Arnd Bergmann Applied to net-next, thanks Arnd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mdio_bus: fix devm_mdiobus_alloc_size export
On Thu, May 8, 2014 at 8:16 PM, Arnd Bergmann wrote: > commit 6d48f44b7b2 "mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free" > introduced a new function devm_mdiobus_alloc_size() but added an export > for a different function devm_mdiobus_alloc(), which was obviously > a simple mistake that leads to build error whenever this function is > used from a loadable module: > > ERROR: "devm_mdiobus_alloc_size" [drivers/net/ethernet/ti/davinci_mdio.ko] > undefined! > > Signed-off-by: Arnd Bergmann > Cc: Grygorii Strashko > Cc: Florian Fainelli > Cc: Sergei Shtylyov > Cc: Lad, Prabhakar > Cc: David S. Miller > Cc: net...@vger.kernel.org Acked-by: Lad, Prabhakar Thanks, --Prabhakar Lad > --- > drivers/net/phy/mdio_bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c > index 68a9a38..a628496 100644 > --- a/drivers/net/phy/mdio_bus.c > +++ b/drivers/net/phy/mdio_bus.c > @@ -117,7 +117,7 @@ struct mii_bus *devm_mdiobus_alloc_size(struct device > *dev, int sizeof_priv) > > return bus; > } > -EXPORT_SYMBOL_GPL(devm_mdiobus_alloc); > +EXPORT_SYMBOL_GPL(devm_mdiobus_alloc_size); > > /** > * devm_mdiobus_free - Resource-managed mdiobus_free() > -- > 1.8.3.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mdio_bus: fix devm_mdiobus_alloc_size export
On Thu, May 8, 2014 at 8:16 PM, Arnd Bergmann a...@arndb.de wrote: commit 6d48f44b7b2 mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free introduced a new function devm_mdiobus_alloc_size() but added an export for a different function devm_mdiobus_alloc(), which was obviously a simple mistake that leads to build error whenever this function is used from a loadable module: ERROR: devm_mdiobus_alloc_size [drivers/net/ethernet/ti/davinci_mdio.ko] undefined! Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Grygorii Strashko grygorii.stras...@ti.com Cc: Florian Fainelli f.faine...@gmail.com Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Cc: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: David S. Miller da...@davemloft.net Cc: net...@vger.kernel.org Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad --- drivers/net/phy/mdio_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 68a9a38..a628496 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -117,7 +117,7 @@ struct mii_bus *devm_mdiobus_alloc_size(struct device *dev, int sizeof_priv) return bus; } -EXPORT_SYMBOL_GPL(devm_mdiobus_alloc); +EXPORT_SYMBOL_GPL(devm_mdiobus_alloc_size); /** * devm_mdiobus_free - Resource-managed mdiobus_free() -- 1.8.3.2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mdio_bus: fix devm_mdiobus_alloc_size export
From: Arnd Bergmann a...@arndb.de Date: Thu, 8 May 2014 16:46:52 +0200 commit 6d48f44b7b2 mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free introduced a new function devm_mdiobus_alloc_size() but added an export for a different function devm_mdiobus_alloc(), which was obviously a simple mistake that leads to build error whenever this function is used from a loadable module: ERROR: devm_mdiobus_alloc_size [drivers/net/ethernet/ti/davinci_mdio.ko] undefined! Signed-off-by: Arnd Bergmann a...@arndb.de Applied to net-next, thanks Arnd. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mdio_bus: fix devm_mdiobus_alloc_size export
Hi Arnd, On 05/08/2014 05:46 PM, Arnd Bergmann wrote: commit 6d48f44b7b2 "mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free" introduced a new function devm_mdiobus_alloc_size() but added an export for a different function devm_mdiobus_alloc(), which was obviously a simple mistake that leads to build error whenever this function is used from a loadable module: ERROR: "devm_mdiobus_alloc_size" [drivers/net/ethernet/ti/davinci_mdio.ko] undefined! Sorry for that, and thanks a lot for the fix. Signed-off-by: Arnd Bergmann Cc: Grygorii Strashko Cc: Florian Fainelli Cc: Sergei Shtylyov Cc: Lad, Prabhakar Cc: David S. Miller Cc: net...@vger.kernel.org --- drivers/net/phy/mdio_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 68a9a38..a628496 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -117,7 +117,7 @@ struct mii_bus *devm_mdiobus_alloc_size(struct device *dev, int sizeof_priv) return bus; } -EXPORT_SYMBOL_GPL(devm_mdiobus_alloc); +EXPORT_SYMBOL_GPL(devm_mdiobus_alloc_size); /** * devm_mdiobus_free - Resource-managed mdiobus_free() Regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mdio_bus: fix devm_mdiobus_alloc_size export
Hi Arnd, On 05/08/2014 05:46 PM, Arnd Bergmann wrote: commit 6d48f44b7b2 mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free introduced a new function devm_mdiobus_alloc_size() but added an export for a different function devm_mdiobus_alloc(), which was obviously a simple mistake that leads to build error whenever this function is used from a loadable module: ERROR: devm_mdiobus_alloc_size [drivers/net/ethernet/ti/davinci_mdio.ko] undefined! Sorry for that, and thanks a lot for the fix. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Grygorii Strashko grygorii.stras...@ti.com Cc: Florian Fainelli f.faine...@gmail.com Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Cc: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: David S. Miller da...@davemloft.net Cc: net...@vger.kernel.org --- drivers/net/phy/mdio_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 68a9a38..a628496 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -117,7 +117,7 @@ struct mii_bus *devm_mdiobus_alloc_size(struct device *dev, int sizeof_priv) return bus; } -EXPORT_SYMBOL_GPL(devm_mdiobus_alloc); +EXPORT_SYMBOL_GPL(devm_mdiobus_alloc_size); /** * devm_mdiobus_free - Resource-managed mdiobus_free() Regards, -grygorii -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/